chore: Remove legacy columns from managed accounts SDK (#4175)

- Remove unnecessary fields from Managed Account after 2024_08 BCR is
generally enabled. We already sourced this data from renamed columns in
the SDK conversion implementation.
- The acceptance tests are skipped for now in the pipeline, but I
verified the change manually.
- Add the retry in assertions due to create propagation time.
- Adjust a few assertions.
- Remove unnecessary BCR acceptance test.

## References
https://docs.snowflake.com/en/release-notes/bcr-bundles/2024_08/bcr-1738

Author: sfc-gh-jmichalak

pkg/sdk/managed_accounts_def.go

@@ -3,14 +3,11 @@ package sdk
 import g "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk/generator/gen"
 
 var managedAccountDbRow = g.DbStruct("managedAccountDBRow").
-	OptionalText("name").
 	OptionalText("account_name").
 	Text("cloud").
 	Text("region").
-	OptionalText("locator").
 	OptionalText("account_locator").
 	Text("created_on").
-	OptionalText("url").
 	OptionalText("account_url").
 	Text("account_locator_url").
 	Bool("is_reader").

pkg/sdk/managed_accounts_gen.go

@@ -4,6 +4,7 @@ package testint
 
 import (
 	"testing"
+	"time"
 
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/helpers/random"
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/testenvs"
@@ -20,7 +21,7 @@ func TestInt_ManagedAccounts(t *testing.T) {
 	client := testClient(t)
 	ctx := testContext(t)
 
-	assertManagedAccount := func(t *testing.T, managedAccount *sdk.ManagedAccount, id sdk.AccountObjectIdentifier, comment string) {
+	assertManagedAccount := func(t *testing.T, managedAccount *sdk.ManagedAccount, id sdk.AccountObjectIdentifier, comment *string) {
 		t.Helper()
 		assert.Equal(t, id.Name(), managedAccount.Name)
 		assert.Equal(t, "aws", managedAccount.Cloud)
@@ -60,8 +61,12 @@ func TestInt_ManagedAccounts(t *testing.T) {
 		require.NoError(t, err)
 		t.Cleanup(cleanupMangedAccountProvider(id))
 
-		managedAccount, err := client.ManagedAccounts.ShowByID(ctx, id)
-		require.NoError(t, err)
+		var managedAccount *sdk.ManagedAccount
+		require.Eventually(t, func() bool {
+			var err error
+			managedAccount, err = client.ManagedAccounts.ShowByID(ctx, id)
+			return err == nil
+		}, 10*time.Second, 2*time.Second)
 
 		return managedAccount
 	}
@@ -76,7 +81,7 @@ func TestInt_ManagedAccounts(t *testing.T) {
 
 		managedAccount := createManagedAccountWithRequest(t, request)
 
-		assertManagedAccount(t, managedAccount, request.GetName(), "")
+		assertManagedAccount(t, managedAccount, request.GetName(), nil)
 	})
 
 	t.Run("create managed account: full", func(t *testing.T) {
@@ -85,7 +90,7 @@ func TestInt_ManagedAccounts(t *testing.T) {
 
 		managedAccount := createManagedAccountWithRequest(t, request)
 
-		assertManagedAccount(t, managedAccount, request.GetName(), "some comment")
+		assertManagedAccount(t, managedAccount, request.GetName(), sdk.String("some comment"))
 	})
 
 	t.Run("drop managed account: existing", func(t *testing.T) {
@@ -117,7 +122,7 @@ func TestInt_ManagedAccounts(t *testing.T) {
 		returnedManagedAccounts, err := client.ManagedAccounts.Show(ctx, showRequest)
 		require.NoError(t, err)
 
-		assert.Len(t, returnedManagedAccounts, 2)
+		assert.GreaterOrEqual(t, len(returnedManagedAccounts), 2)
 		assert.Contains(t, returnedManagedAccounts, *managedAccount1)
 		assert.Contains(t, returnedManagedAccounts, *managedAccount2)
 	})

pkg/sdk/managed_accounts_impl_gen.go

@@ -10,7 +10,6 @@ import (
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance/testenvs"
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/provider/resources"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
-	"github.com/hashicorp/terraform-plugin-testing/plancheck"
 	"github.com/hashicorp/terraform-plugin-testing/tfversion"
 )
 
@@ -55,41 +54,6 @@ func TestAcc_ManagedAccount(t *testing.T) {
 	})
 }
 
-func TestAcc_ManagedAccount_HandleShowOutputChanges_BCR_2024_08(t *testing.T) {
-	// TODO [SNOW-1011985]: unskip the tests
-	testenvs.SkipTestIfSet(t, testenvs.SkipManagedAccountTest, "error: 090337 (23001): Number of managed accounts allowed exceeded the limit. Please contact Snowflake support")
-
-	id := testClient().Ids.RandomAccountObjectIdentifier()
-	adminName := random.AdminName()
-	adminPass := random.Password()
-
-	resource.Test(t, resource.TestCase{
-		ProtoV6ProviderFactories: TestAccProtoV6ProviderFactories,
-		TerraformVersionChecks: []tfversion.TerraformVersionCheck{
-			tfversion.RequireAbove(tfversion.Version1_5_0),
-		},
-		CheckDestroy: CheckDestroy(t, resources.ManagedAccount),
-		Steps: []resource.TestStep{
-			{
-				Config: managedAccountConfig(id.Name(), adminName, adminPass),
-				ConfigPlanChecks: resource.ConfigPlanChecks{
-					PreApply: []plancheck.PlanCheck{
-						plancheck.ExpectResourceAction("snowflake_managed_account.test", plancheck.ResourceActionNoop),
-					},
-				},
-				Check: resource.ComposeTestCheckFunc(
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "name", id.Name()),
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "fully_qualified_name", id.FullyQualifiedName()),
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "admin_name", adminName),
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "admin_password", adminPass),
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "comment", managedAccountComment),
-					resource.TestCheckResourceAttr("snowflake_managed_account.test", "type", "READER"),
-				),
-			},
-		},
-	})
-}
-
 func managedAccountConfig(accName, aName, aPass string) string {
 	return fmt.Sprintf(`
 resource "snowflake_managed_account" "test" {