Skip to content

Conversation

@sfc-gh-dszmolka
Copy link
Contributor

Description

Still no code was changed. Continuation of #2687 ; closure works now.

Adding debug allowed to see where we crashing

-bash: command substitution: line 36: syntax error near unexpected token `('
-bash: command substitution: line 36: `      ch.setFormatter(logging.Formatter('%(asctime)s - %(threadName)s %(filename)s:%(lineno)d - %(funcName)s() - %(levelname)s - %(message)s'))'

which is the 'add logs' field; so trying to cram it in a heredoc, worked locally.

@sfc-gh-dszmolka sfc-gh-dszmolka requested a review from a team as a code owner December 4, 2025 08:43
@sfc-gh-dszmolka sfc-gh-dszmolka added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Dec 4, 2025
@semgrep-app-snowflakedb
Copy link

Semgrep found 1 run-shell-injection finding:

Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".

@sfc-gh-dszmolka sfc-gh-dszmolka merged commit f55ff4d into main Dec 4, 2025
134 of 142 checks passed
@sfc-gh-dszmolka sfc-gh-dszmolka deleted the NO-SNOW-fix-jira-creation-closure-4 branch December 4, 2025 11:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants