Skip to content

Conversation

@jeffsawatzky
Copy link

@jeffsawatzky jeffsawatzky commented May 6, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2090775: converter doesn't properly convert lists of bytes #2311

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    When the converter is converting a list, it isn't running to_snowflake on each element like it does when it is a single parameter.

  4. (Optional) PR for stored-proc connector:

@github-actions
Copy link

github-actions bot commented May 6, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeffsawatzky
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jeffsawatzky
Copy link
Author

recheck

@sfc-gh-pbulawa
Copy link
Contributor

Thank you for the PR. Could you please add a test for that case?

@jeffsawatzky
Copy link
Author

@sfc-gh-pbulawa I added a test.

@sfc-gh-pbulawa
Copy link
Contributor

@jeffsawatzky, the test is failing. Could you check the cause, please, and fix it?

Copy link
Contributor

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warnings

@jeffsawatzky
Copy link
Author

I don't have time to fix this. I have a workaround so that will just have to do for now.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-2090775: converter doesn't properly convert lists of bytes

2 participants