Don't silenty fail on auth config file corruption

zefhemel · zefhemel · commit 4d38ca3a22d1 · 2026-04-24T16:34:10.000+02:00
diff --git a/server/crypto.go b/server/crypto.go
@@ -42,7 +42,7 @@ func CreateAuthenticator(path string, authOptions *AuthOptions) (*Authenticator,
 	var auth Authenticator
 	auth.path = path
 	if err := json.Unmarshal(jsonBytes, &auth); err != nil {
-		log.Printf("Could not parse .silverbullet.auth.json, resetting")
+		return nil, fmt.Errorf("could not parse %s: %w (remove or fix the file to proceed)", path, err)
 	}
 	if err := auth.init(authOptions); err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func CreateAuthenticator(path string, authOptions AuthOptions) (Authenticator,`
`42`	`42`	`var auth Authenticator`
`43`	`43`	`auth.path = path`
`44`	`44`	`if err := json.Unmarshal(jsonBytes, &auth); err != nil {`
`45`		`- log.Printf("Could not parse .silverbullet.auth.json, resetting")`
	`45`	`+ return nil, fmt.Errorf("could not parse %s: %w (remove or fix the file to proceed)", path, err)`
`46`	`46`	`}`
`47`	`47`	`if err := auth.init(authOptions); err != nil {`
`48`	`48`	`return nil, err`