Skip to content

Commit b5a6bdf

Browse files
committed
Separate terms and glosses tests
1 parent f88004a commit b5a6bdf

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/SIL.Machine/Corpora/ParatextProjectTermsParserBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public static IReadOnlyList<string> GetRenderings(string rendering)
231231
{
232232
return Regex
233233
.Split(rendering.Trim(), @"\|\|")
234-
.Select(r => CleanTerm(r))
234+
.Select(r => CleanTerm(r).Trim())
235235
.Select(r => r.Replace("*", ""))
236236
.Where(r => r != "")
237237
.ToList();

tests/SIL.Machine.Tests/Corpora/ParatextProjectTermsParserTests.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,17 +159,24 @@ public void TestStripParens(string testString, string expectedOutput, char left
159159

160160
[Test]
161161
[TestCase("", new string[] { })]
162-
[TestCase("*Abba* /", new string[] { "Abba" })]
163-
[TestCase("Abba|| ", new string[] { "Abba" })]
164-
[TestCase("Abba||Abbah?", new string[] { "Abba", "Abbah" })]
165-
[TestCase("Abba (note)", new string[] { "Abba" })]
166162
[TestCase("Abba (note)", new string[] { "Abba" })]
167163
[TestCase("Ahasuerus, Xerxes; Assuerus", new string[] { "Ahasuerus", "Xerxes", "Assuerus" })]
168164
public void TestGetGlosses(string glossString, IReadOnlyList<string> expectedOutput)
169165
{
170166
Assert.That(ParatextProjectTermsParserBase.GetGlosses(glossString), Is.EqualTo(expectedOutput));
171167
}
172168

169+
[Test]
170+
[TestCase("", new string[] { })]
171+
[TestCase("*Abba*", new string[] { "Abba" })]
172+
[TestCase("Abba|| ", new string[] { "Abba" })]
173+
[TestCase("Abba||Abbah", new string[] { "Abba", "Abbah" })]
174+
[TestCase("Abba (note)", new string[] { "Abba" })]
175+
public void TestGetRenderings(string renderingString, IReadOnlyList<string> expectedOutput)
176+
{
177+
Assert.That(ParatextProjectTermsParserBase.GetRenderings(renderingString), Is.EqualTo(expectedOutput));
178+
}
179+
173180
private class TestEnvironment(
174181
ParatextProjectSettings? settings = null,
175182
Dictionary<string, string>? files = null,

0 commit comments

Comments
 (0)