Add 'parent' property

Author: Enkidu93

machine/corpora/paratext_project_settings.py

@@ -24,7 +24,7 @@ class ParatextProjectSettings:
     translation_type: str
     parent_guid: Optional[str] = None
     parent_name: Optional[str] = None
-    _parent_has_been_set: bool = False
+    _parent: Optional["ParatextProjectSettings"] = None
 
     def get_book_id(self, file_name: str) -> Optional[str]:
         """Returns None when the file name doesn't match the pattern of a book file name for the project."""
@@ -67,19 +67,21 @@ def has_parent(self) -> bool:
         return self.parent_guid is not None
 
     @property
-    def parent_has_been_set(self) -> bool:
-        return self._parent_has_been_set
+    def parent(self) -> Optional["ParatextProjectSettings"]:
+        return self._parent
+
+    @parent.setter
+    def parent(self, value: "ParatextProjectSettings"):
+        if not self.is_daughter_project_of(value):
+            raise ValueError(f"Project {value.name} is not the parent project of project {self.name}.")
+        self._parent = value
+        self.versification = value.versification
 
     def is_daughter_project_of(self, other_project: "ParatextProjectSettings") -> bool:
         if not self.has_parent:
             return False
         return self.parent_guid == other_project.guid
 
-    def set_parent_project(self, other_project: "ParatextProjectSettings"):
-        # TODO anything else we should set? From what I can tell, stylesheets are not inherited
-        self.versification = other_project.versification
-        self._parent_has_been_set = True
-
 
 def _get_book_file_name_digits(book_id: str) -> str:
     book_num = book_id_to_number(book_id)

machine/corpora/paratext_project_settings_parser_base.py

@@ -118,11 +118,6 @@ def parse(self) -> ParatextProjectSettings:
         )
 
         if self.parent_paratext_project_settings is not None and settings.has_parent:
-            if not settings.is_daughter_project_of(self.parent_paratext_project_settings):
-                raise ValueError(
-                    f"Project {self.parent_paratext_project_settings.name} is "
-                    f"not the parent project of project {settings.name}."
-                )
-            settings.set_parent_project(self.parent_paratext_project_settings)
+            settings.parent = self.parent_paratext_project_settings
 
         return settings

tests/corpora/test_file_paratext_project_settings_parser.py

@@ -17,11 +17,11 @@ def test_is_daughter_project() -> None:
     assert settings.has_parent
     assert settings.is_daughter_project_of(settings)
     assert settings.translation_type == "Standard"
-    assert not settings.parent_has_been_set
+    assert settings.parent is None
 
     parser = FileParatextProjectSettingsParser(USFM_TEST_PROJECT_PATH, settings)
     settings = parser.parse()
     assert settings.has_parent
     assert settings.is_daughter_project_of(settings)
     assert settings.translation_type == "Standard"
-    assert settings.parent_has_been_set
+    assert settings.parent is not None

tests/corpora/test_zip_paratext_project_settings_parser.py

@@ -24,15 +24,15 @@ def test_is_daughter_project() -> None:
         assert settings.has_parent
         assert settings.is_daughter_project_of(settings)
         assert settings.translation_type == "Standard"
-        assert not settings.parent_has_been_set
+        assert settings.parent is None
 
         env.parser = ZipParatextProjectSettingsParser(env.zip_file, settings)
 
         settings = env.parser.parse()
         assert settings.has_parent
         assert settings.is_daughter_project_of(settings)
         assert settings.translation_type == "Standard"
-        assert settings.parent_has_been_set
+        assert settings.parent is not None
 
 
 class _TestEnvironment(ContextManager["_TestEnvironment"]):