Implement GenerateAssemblyInfo template reintegration (Spec 002)

This change standardizes assembly metadata across all 101 managed projects by enforcing the CommonAssemblyInfoTemplate policy and restoring custom attributes lost during previous migrations.

Key changes:
- Added `scripts/GenerateAssemblyInfo/` automation suite:
  - `audit_generate_assembly_info.py`: Inventories project state (Template-only vs. Custom).
  - `convert_generate_assembly_info.py`: Links `Src/CommonAssemblyInfo.cs`, sets `<GenerateAssemblyInfo>false`, and restores missing `AssemblyInfo.cs` files from git history.
  - `validate_generate_assembly_info.py`: Enforces structural compliance and invokes MSBuild/Reflection checks.
  - `reflect_attributes.ps1`: Verifies assembly attributes (Company, Product, Copyright) in build output.
- Updated `Directory.Build.props` to document the new AssemblyInfo policy and disable determinism for wildcard versioning.
- Updated `.github/instructions/managed.instructions.md` with developer guidelines for the template.
- Finalized `specs/002-convergence-generate-assembly-Implement GenerateAssemblyInfo template reintegration (Spec 002)

This change standardizes assembly metadata across all 101 managed projects by enforcing the CommonAssemblyInfoTemplate policy and restoring custom attributes lost during previous migrations.

Key changes:
- Added `scripts/GenerateAssemblyInfo/` automation suite:
  - `audit_generate_assembly_info.py`: Inventories project state (Template-only vs. Custom).
  - `convert_generate_assembly_info.py`: Links `Src/CommonAssemblyInfo.cs`, sets `<GenerateAssemblyInfo>false`, and restores missing `AssemblyInfo.cs` files from git history.
  - `validate_generate_assembly_info.py`: Enforces structural compliance and invokes MSBuild/Reflection checks.
  - `reflect_attributes.ps1`: Verifies assembly attributes (Company, Product, Copyright) in build output.
- Updated `Directory.Build.props` to document the new AssemblyInfo policy and disable determinism for wildcard versioning.
- Updated `.github/instructions/managed.instructions.md` with developer guidelines for the template.
- Finalized `specs/002-convergence-generate-assembly-

Author: johnml1135

.github/instructions/build.instructions.md

@@ -185,9 +185,31 @@ dotnet restore FieldWorks.proj --packages packages/
 - **`Build/SetupInclude.targets`**: Environment setup; touch only when absolutely needed
 - **`Directory.Build.props`**: Shared properties for all projects; changes affect everyone
 
+## Running Tests
+
+### With MSBuild (current method)
+```powershell
+# Run all tests
+msbuild FieldWorks.proj /p:Configuration=Debug /p:Platform=x64 /p:action=test
+
+# Run specific test target
+msbuild Build\FieldWorks.targets /t:CacheLightTests /p:Configuration=Debug /p:Platform=x64 /p:action=test
+```
+
+Test results: `Output/Debug/<ProjectName>.dll-nunit-output.xml`
+
+### With dotnet test (under development)
+```powershell
+# Future simplified approach
+dotnet test FieldWorks.sln --configuration Debug
+```
+
+See `.github/instructions/testing.instructions.md` for detailed test execution guidance.
+
 ## References
 - **CI/CD**: `.github/workflows/` for CI steps
 - **Build Infrastructure**: `Build/` for targets/props and build infrastructure
 - **Traversal Project**: `FieldWorks.proj` for declarative build order
 - **Shared Properties**: `Directory.Build.props` for all projects
 - **Native Build**: `Build/mkall.targets` for C++ build orchestration
+- **Testing**: `.github/instructions/testing.instructions.md` for test execution

.github/instructions/managed.instructions.md

@@ -23,6 +23,11 @@ This file describes conventions, deterministic requirements, and best practices
 ## Key Rules
 - Use existing patterns for localization, unit tests, and avoid runtime-incompatible behaviors.
 - Keep public APIs stable and documented with XML docs.
+- **AssemblyInfo Policy**:
+  - All managed projects must link `Src/CommonAssemblyInfo.cs` via `<Compile Include="..\..\CommonAssemblyInfo.cs" Link="Properties\CommonAssemblyInfo.cs" />`.
+  - Set `<GenerateAssemblyInfo>false</GenerateAssemblyInfo>` to prevent SDK duplicate attribute errors.
+  - Restore and maintain project-specific `AssemblyInfo*.cs` files if custom attributes are required.
+  - Use `scripts/GenerateAssemblyInfo/validate_generate_assembly_info.py` to verify compliance.
 
 ## Test exclusion conversion playbook (Pattern A standard)
 - Always prefer explicit `<ProjectName>Tests/**` exclusions. For nested test folders add matching explicit entries (for example `Component/ComponentTests/**`).

.github/instructions/testing.instructions.md

@@ -10,7 +10,9 @@ Guidance for writing deterministic unit and integration tests for FieldWorks and
 
 ## Context loading
 - Locate tests near their components (e.g., `Src/<Component>.Tests`). Some integration scenarios use `TestLangProj/` data.
-- Determine test runner: SDK-style projects use `dotnet test`; .NET Framework often uses NUnit Console.
+- **Current test infrastructure**: MSBuild-based with NUnit Console Runner via `Build/FieldWorks.targets`
+- **Future direction**: Migrating to `dotnet test` (VSTest platform) for modern CI/CD integration
+- Test projects are marked with `<IsTestProject>true</IsTestProject>` and automatically receive modern test packages via `Directory.Build.props`
 
 ## Deterministic requirements
 - Keep tests hermetic: avoid external state; use test data under version control.
@@ -24,11 +26,59 @@ Guidance for writing deterministic unit and integration tests for FieldWorks and
 ## Key Rules
 - Keep tests deterministic and fast where possible; add integration tests only for end-to-end scenarios.
 - Name tests clearly for reviewer understanding.
+- Tests use NUnit 3.x framework with `[Test]` and `[TestFixture]` attributes.
+
+## Running Tests
+
+### Current Method: MSBuild with `action=test` (Recommended for Now)
+
+The established approach uses custom MSBuild tasks that invoke NUnit Console Runner:
 
-## Examples
 ```powershell
-# dotnet test --filter Category=Unit
+# Run all tests during build
+.\build.ps1 -Configuration Debug
+# Or explicitly:
+msbuild FieldWorks.proj /p:Configuration=Debug /p:Platform=x64 /p:action=test
+
+# Run tests for a specific component
+msbuild Build\FieldWorks.targets /t:CacheLightTests /p:Configuration=Debug /p:Platform=x64 /p:action=test
+```
+
+**How it works**:
+- Tests are executed via NUnit Console Runner: `packages/NUnit.ConsoleRunner.3.12.0/tools/nunit3-console.exe`
+- Test results: `Output/Debug/<ProjectName>.dll-nunit-output.xml`
+- Each test target in `Build/FieldWorks.targets` has an `NUnit3` task that runs when `action=test`
+
+### Future Method: `dotnet test` (Under Development)
+
+A modernized `dotnet test` workflow is planned:
+
+```powershell
+# Target workflow (not fully functional yet):
+dotnet test FieldWorks.sln --configuration Debug
+
+# Or specific projects:
+dotnet test Src/InstallValidator/InstallValidatorTests/InstallValidatorTests.csproj
+```
+
+**Current Status**:
+- Test projects now reference `Microsoft.NET.Test.Sdk` and `NUnit3TestAdapter` via `Directory.Build.props`
+- Adapter discovery with .NET Framework 4.8 projects needs additional work
+- This approach will replace MSBuild-based test execution once fully validated
+
+### In Docker Container
+
+```powershell
+# Current working approach (MSBuild)
+docker run --rm -v "${PWD}:C:\src" -w C:\src fw-build:ltsc2022 `
+  powershell -NoLogo -Command "msbuild FieldWorks.proj /p:Configuration=Debug /p:Platform=x64 /p:action=test"
+
+# Future approach (dotnet test - when adapter discovery is fixed)
+docker run --rm -v "${PWD}:C:\src" -w C:\src fw-build:ltsc2022 `
+  powershell -NoLogo -Command "C:\dotnet\dotnet.exe test FieldWorks.sln --configuration Debug"
 ```
 
 ## References
-- Test data: `TestLangProj/`
+- **Build Infrastructure**: `Build/FieldWorks.targets` for MSBuild test tasks
+- **Test Data**: `TestLangProj/` for integration test data
+- **Build Instructions**: `.github/instructions/build.instructions.md` for build and test execution

Build/mkall.targets

@@ -734,7 +734,7 @@
 			<Architecture Condition="'$(Platform)'=='x64'">64</Architecture>
 			<Architecture Condition="'$(Platform)'!='x64'">32</Architecture>
 			<GeckoDir Condition="'$(OS)'=='Windows_NT'"
-				>$(PackagesDir)/Geckofx60.$(Architecture).60.0.54</GeckoDir
+				>$(PackagesDir)/Geckofx60.$(Architecture).60.0.56</GeckoDir
 			>
 		</PropertyGroup>
 		<ItemGroup>

Directory.Build.props

@@ -8,6 +8,19 @@
 		<Platforms Condition="'$(Platforms)' == ''">x64</Platforms>
 		<!-- Force 64-bit MSBuild host to avoid crashes loading 64-bit native DLLs in build tasks -->
 		<PreferredToolArchitecture>x64</PreferredToolArchitecture>
+		<!-- Disable determinism to allow wildcard versions in CommonAssemblyInfo.cs -->
+		<Deterministic>false</Deterministic>
+	</PropertyGroup>
+	<PropertyGroup Label="AssemblyInfo Policy">
+		<!--
+			CommonAssemblyInfoTemplate Policy:
+			All managed projects must link Src/CommonAssemblyInfo.cs to ensure consistent versioning and metadata.
+			When linking the template, disable SDK auto-generation to prevent CS0579 duplicate attribute errors.
+
+			Usage:
+			<Compile Include="..\..\CommonAssemblyInfo.cs" Link="Properties\CommonAssemblyInfo.cs" />
+			<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
+		-->
 	</PropertyGroup>
 	<PropertyGroup Label="Shared Paths for Traversal Build">
 		<!-- Root directory paths -->
@@ -42,4 +55,16 @@
 			Nested test folders must also be explicitly excluded.
 		-->
 	</ItemGroup>
+	<!-- Modern test infrastructure for all test projects -->
+	<PropertyGroup Condition="'$(IsTestProject)' == 'true'">
+		<!-- For .NET Framework projects, ensure NuGet package assemblies are copied to output directory -->
+		<!-- This is required for dotnet test to discover test adapters -->
+		<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
+	</PropertyGroup>
+	<ItemGroup Condition="'$(IsTestProject)' == 'true'">
+		<!-- Microsoft.NET.Test.Sdk enables 'dotnet test' support (VSTest platform) -->
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
+		<!-- NUnit3TestAdapter enables NUnit test discovery for VSTest -->
+		<PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
+	</ItemGroup>
 </Project>

Lib/src/ScrChecks/ScrChecksTests/ScrChecksTests.csproj

@@ -24,9 +24,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="NUnit" Version="4.4.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="5.2.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="9.0.9" />
     <PackageReference Include="SIL.LCModel.Core" Version="11.0.0-*" />
     <PackageReference Include="SIL.LCModel.Core.Tests" Version="11.0.0-*" PrivateAssets="All" />
     <PackageReference Include="SIL.LCModel.Utils" Version="11.0.0-*" />

Post-Install-Setup.ps1

@@ -82,9 +82,10 @@ if (Test-Path $dotnetSdkPath) {
         $workloadLocator = Join-Path $msbuildSdkPath 'Microsoft.NET.SDK.WorkloadAutoImportPropsLocator\Sdk'
         if (-not (Test-Path $workloadLocator)) {
             New-Item -ItemType Directory -Path $workloadLocator -Force | Out-Null
-            # Create empty Sdk.props and Sdk.targets
+            # Create empty Sdk.props, Sdk.targets, and AutoImport.props
             Set-Content -Path (Join-Path $workloadLocator 'Sdk.props') -Value '<?xml version="1.0" encoding="utf-8"?><Project />'
             Set-Content -Path (Join-Path $workloadLocator 'Sdk.targets') -Value '<?xml version="1.0" encoding="utf-8"?><Project />'
+            Set-Content -Path (Join-Path $workloadLocator 'AutoImport.props') -Value '<?xml version="1.0" encoding="utf-8"?><Project />'
         }
 
         # Create stub for WorkloadManifestTargetsLocator (not present in .NET 8.0.100)

Src/AssemblyInfoForTests.cs

@@ -43,5 +43,4 @@
 // Allow creating COM objects from manifest file important that it comes after InitializeIcu
 [assembly: CreateComObjectsFromManifest]
 
-// This is for testing VersionInfoProvider in FwUtils
-[assembly: AssemblyInformationalVersion("9.0.6 45470 Alpha")]
+// CommonAssemblyInfo.cs now provides the informational version for all assemblies.

Src/CacheLight/CacheLightTests/AssemblyInfo.cs

@@ -0,0 +1,2 @@
+using System.Reflection;
+using System.Runtime.CompilerServices;

Src/CacheLight/CacheLightTests/CacheLightTests.csproj

@@ -38,4 +38,9 @@
     <ProjectReference Include="../../Common/ViewsInterfaces/ViewsInterfaces.csproj" />
     <ProjectReference Include="../CacheLight.csproj" />
   </ItemGroup>
+  <ItemGroup>
+    <Compile Include="..\..\CommonAssemblyInfo.cs">
+      <Link>Properties\CommonAssemblyInfo.cs</Link>
+    </Compile>
+  </ItemGroup>
 </Project>