Skip to content

Remove or clarify dependency on tus-server #7

@jonleighton

Description

@jonleighton

This plugin defines a dependency on tus-server (a Ruby implementation of a Tus server) in the gemspec. However, it never actually requires any files from that gem.

That said, it does implicitly depend on tus-server in this line:

rescue ::Tus::NotFound

That constant is defined in tus-server here.

Therefore, if I use shrine-tus without explicitly requiring tus-server, then I'll get a NameError if I hit an error in this method.

There are two potential solutions:

  1. Remove the dependency on tus-server. This would be my preference - I don't think shrine-tus as a Tus client should care about what server implementation is used. (On my project, we're using tusd, therefore we don't want/need the tus-server gem at all.)
  2. Require tus/errors so that the constant gets defined.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions