Address CodeRabbit review feedback

- Use Map in contextStore to avoid prototype key collisions
- Use block body in forEach callback in nest-test
- Assert setState callback was invoked in withState-test

Co-Authored-By: Claude Opus 4.6 <[email protected]>

Author: alexeyr

babel.config.js

@@ -1,5 +1,5 @@
 module.exports = {
-  plugins: [['@babel/proposal-class-properties', { loose: true }]],
+  plugins: [['@babel/transform-class-properties', { loose: true }]],
   presets: [['@babel/env', { loose: true }], '@babel/react'],
 }
 

package.json

@@ -41,7 +41,7 @@
   "devDependencies": {
     "@babel/cli": "^7.22.0",
     "@babel/core": "^7.22.0",
-    "@babel/plugin-proposal-class-properties": "^7.18.0",
+    "@babel/plugin-transform-class-properties": "^7.25.0",
     "@babel/plugin-transform-runtime": "^7.22.0",
     "@babel/preset-env": "^7.22.0",
     "@babel/preset-react": "^7.22.0",

src/packages/recompose/__tests__/branch-test.js

@@ -60,5 +60,5 @@ test('branch third argument should not cause console error', () => {
 
   render(<BranchedComponent />)
 
-  expect(console.error.mock.calls.length > 0).toBe(false)
+  expect(console.error).not.toHaveBeenCalled()
 })

src/packages/recompose/__tests__/nest-test.js

@@ -15,6 +15,8 @@ test('nest nests components from outer to inner', () => {
   // nest(A,B,C) creates nested divs, all with pass="through"
   const divs = container.querySelectorAll('div')
   expect(divs.length).toBe(3)
-  divs.forEach(div => expect(div.getAttribute('pass')).toBe('through'))
+  divs.forEach(div => {
+    expect(div.getAttribute('pass')).toBe('through')
+  })
   expect(container.textContent).toBe('Child')
 })

src/packages/recompose/__tests__/withHandlers-test.js

@@ -67,7 +67,7 @@ test('withHandlers warns if handler is not a higher-order function', () => {
 
   const { container } = render(<Button />)
 
-  // React 16 dev mode re-throws errors from event handlers via
+  // React dev mode re-throws errors from event handlers via
   // invokeGuardedCallbackDev, causing an uncaught error in jsdom.
   // Suppress it so we can check the console.error warning instead.
   const onError = event => event.preventDefault()

src/packages/recompose/__tests__/withState-test.js

@@ -56,6 +56,7 @@ test('withState accepts setState() callback', () => {
   act(() => {
     updateCounter(18, callback)
   })
+  expect(callback).toHaveBeenCalledTimes(1)
 })
 
 test('withState also accepts initialState as function of props', () => {

src/packages/recompose/__tests__/withStateHandlers-test.js

@@ -86,7 +86,7 @@ test('withStateHandlers initial state must be function or object or null or unde
   const Counter = withStateHandlers(1, {})(component)
   jest.spyOn(console, 'error').mockImplementation(() => {})
   render(<Counter />)
-  expect(console.error.mock.calls.length > 0).toBe(true)
+  expect(console.error).toHaveBeenCalled()
 })
 
 test('withStateHandlers have access to props', () => {

src/packages/recompose/utils/contextStore.js

@@ -1,13 +1,14 @@
 import { createContext } from 'react'
 
-const store = {}
+const store = new Map()
 
 export const getOrCreateContext = key => {
-  if (!store[key]) {
-    store[key] = createContext(undefined)
-    if (process.env.NODE_ENV !== 'production') {
-      store[key].displayName = key
-    }
+  const existing = store.get(key)
+  if (existing) return existing
+  const ctx = createContext(undefined)
+  if (process.env.NODE_ENV !== 'production') {
+    ctx.displayName = key
   }
-  return store[key]
+  store.set(key, ctx)
+  return ctx
 }

yarn.lock

@@ -98,7 +98,7 @@
     lru-cache "^5.1.1"
     semver "^6.3.1"
 
-"@babel/helper-create-class-features-plugin@^7.18.6", "@babel/helper-create-class-features-plugin@^7.28.6":
+"@babel/helper-create-class-features-plugin@^7.28.6":
   version "7.28.6"
   resolved "https://registry.yarnpkg.com/@babel/helper-create-class-features-plugin/-/helper-create-class-features-plugin-7.28.6.tgz#611ff5482da9ef0db6291bcd24303400bca170fb"
   integrity sha512-dTOdvsjnG3xNT9Y0AUg1wAl38y+4Rl4sf9caSQZOXdNqVn+H+HbbJ4IyyHaIqNR6SW9oJpA/RuRjsjCw2IdIow==
@@ -313,14 +313,6 @@
     "@babel/helper-plugin-utils" "^7.28.6"
     "@babel/traverse" "^7.28.6"
 
-"@babel/plugin-proposal-class-properties@^7.18.0":
-  version "7.18.6"
-  resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-class-properties/-/plugin-proposal-class-properties-7.18.6.tgz#b110f59741895f7ec21a6fff696ec46265c446a3"
-  integrity sha512-cumfXOF0+nzZrrN8Rf0t7M+tF6sZc7vhQwYQck9q1/5w2OExlD+b4v4RpMJFaV1Z7WcDRgO6FqvxqxGlwo+RHQ==
-  dependencies:
-    "@babel/helper-create-class-features-plugin" "^7.18.6"
-    "@babel/helper-plugin-utils" "^7.18.6"
-
 "@babel/plugin-proposal-private-property-in-object@7.21.0-placeholder-for-preset-env.2":
   version "7.21.0-placeholder-for-preset-env.2"
   resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-private-property-in-object/-/plugin-proposal-private-property-in-object-7.21.0-placeholder-for-preset-env.2.tgz#7844f9289546efa9febac2de4cfe358a050bd703"
@@ -499,7 +491,7 @@
   dependencies:
     "@babel/helper-plugin-utils" "^7.28.6"
 
-"@babel/plugin-transform-class-properties@^7.28.6":
+"@babel/plugin-transform-class-properties@^7.25.0", "@babel/plugin-transform-class-properties@^7.28.6":
   version "7.28.6"
   resolved "https://registry.yarnpkg.com/@babel/plugin-transform-class-properties/-/plugin-transform-class-properties-7.28.6.tgz#d274a4478b6e782d9ea987fda09bdb6d28d66b72"
   integrity sha512-dY2wS3I2G7D697VHndN91TJr8/AAfXQNt5ynCTI/MpxMsSzHp+52uNivYT5wCPax3whc47DR8Ba7cmlQMg24bw==