[BUG] CPack variables are leaking into my project when using FetchContent

[koenvandesande]

Describe the bug
When I try to use CPack on my project (after adding Redis++ using FetchContent), it now tries to build a Debian package.

Could add the CPack area inside a guard so it is only built when Redis++ is a top-level project? This prevents it from being added when using FetchContent.

if(PROJECT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
  include(CPack)
endif()

[koenvandesande]

This also silences warnings about CPack having already been included:

CMake Warning at /usr/local/lib/python3.12/dist-packages/cmake/data/share/cmake-3.31/Modules/CPack.cmake:510 (message):
  CPack.cmake has already been included!!

[koenvandesande]

The cleaner way to do it might be to guard include(CPack) and all calls to install() behind an option called e.g. REDIS_PLUS_PLUS_INSTALL. That is how other projects typically do it.
Because otherwise, the installation of my project will install e.g. all header files of Redis++ as well.

[sewenew]

@koenvandesande Thanks for the advice! I'm not familiar with cpack, and I can call include(CPack) only if it's a top-level project (or have an option to enable/disable it).

However, redis-plus-plus depends on hiredis, whose CMakeLists.txt file does not do these jobs either. Is it a problem, even if redis-plus-plus fix it?

Regards