Merged
Conversation
SurrealDB was replaced by PostgreSQL and the migration is complete. This removes the SurrealDB client, persistence service, migration tooling, config files, and all fallback logic in PostgresPersistentService. Co-Authored-By: Claude Opus 4.6 <[email protected]>
After removing SurrealDB fallback, these methods return an empty list instead of null when no records are found. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: munishchouhan <[email protected]>
munishchouhan
approved these changes
Mar 4, 2026
Member
|
Tested successfully in local |
Collaborator
Author
|
nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate/package (DataMigrationService, MigrationOnly annotation, DataMigrateCache) and its testsPostgresPersistentService— load methods now returnnull/empty instead of falling back to SurrealDBStringUtils.surrealId()method and all call sites inWaveScanRecordandScanVulnerability@MigrationOnlyannotation usage fromFusionVersionStringDeserializerapplication-surrealdb.yml,application-surrealdb-legacy.yml, anddocs/db-migration.mdLocalPersistenceServiceguard fromnotEnv=surrealdbtonotEnv=postgresTest plan
./gradlew compileGroovy— passes./gradlew compileTestGroovy— passes./gradlew test)🤖 Generated with Claude Code