Multi-platform container builds via job queue#982
Closed
pditommaso wants to merge 4 commits intomasterfrom
Closed
Conversation
|
|
||
| def 'should fail to extract platform from unknown image name'() { | ||
| when: | ||
| ManifestAssembler.extractPlatform([:], 'repo:some-tag') |
Member
There was a problem hiding this comment.
extractPlatform does not exist
Refactor ContainerPlatform to support multi-arch builds natively, replacing MultiContainerPlatform with a unified model. Fan out security scans per architecture since Trivy only accepts a single --platform flag. Key changes: - Consolidate ContainerPlatform to handle both single and multi-arch - Add ScanIds helper for encoding/decoding per-platform scan IDs - Fan out scans in ContainerScanServiceImpl per architecture - Add BuildRequest.withScanId() for propagating multi-scan IDs - Update views and email templates for per-arch scan links - Poll all per-arch scans in ContainerStatusServiceImpl - Extract ScanIds.populateScanBinding() to DRY scan binding logic Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pditommaso
force-pushed
the
multi-platform
branch
from
6e4870c to
8adb8ac
Compare
Collaborator
Author
|
Alternative implementation #985 |
Collaborator
Author
|
Closing in favour of #985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JobManager/JobHandlerinfrastructure (MultiBuildjob type) instead of rawCompletableFuturethreads, gaining consistent monitoring, timeout handling, and cleanupManifestAssemblercreates and pushes OCI manifest lists using the registry HTTP API directlymultiPlatformboolean) onBuildRequest,ScanRequestandScanEntrysurvives all serialization boundaries (Moshi/Redis), ensuring correct platform display (linux/amd64,linux/arm64) across build history, scan pages, and email notificationsNew files
MultiPlatformBuildService— orchestrator, implementsJobHandler<MultiBuildEntry>MultiBuildRequest/MultiBuildEntry/MultiBuildStateStore— state model for multi-build jobsManifestAssembler— creates & pushes OCI Image Index via registry APIMultiContainerPlatform—ContainerPlatformsubclass for composite platform displayKey design decisions
scanId=null,noEmail=true); scan and notification run once on the composite imageMultiBuildjobs skippendingQueue(no K8s resources) and go directly toprocessingQueueBuildStateStoreTest plan
MultiPlatformBuildServiceTest— job completion, failure, timeout, exceptionMultiBuildRequestTest/MultiBuildEntryTest— state modelManifestAssemblerTest— manifest list constructionContainerScanServiceImplTest/ScanEntryTest/WaveScanRecordTest🤖 Generated with Claude Code