Memory Leak Fixes: Release CFArrayRef and App Instances (#43)

* fix mem leaks

* Remove dstore file

Author: chevonc

lib/macos.mm

@@ -28,37 +28,41 @@ bool _requestAccessibility(bool showDialog) {
 
   for (NSDictionary *info in (NSArray *)windowList) {
     NSNumber *windowNumber = info[(id)kCGWindowNumber];
-    
+
     if ([windowNumber intValue] == handle) {
+      CFRelease(windowList);
       return info;
     }
   }
 
+  CFRelease(windowList);
   return NULL;
 }
 
 AXUIElementRef getAXWindow(int pid, int handle) {
   auto app = AXUIElementCreateApplication(pid);
 
-  NSArray *windows;
-  AXUIElementCopyAttributeValues(app, kAXWindowsAttribute, 0, 100, (CFArrayRef *) &windows);
+  CFArrayRef windows;
+  AXUIElementCopyAttributeValues(app, kAXWindowsAttribute, 0, 100, &windows);
 
-  for (id child in windows) {
+  for (id child in  (NSArray *)windows) {
     auto window = (AXUIElementRef) child;
 
     CGWindowID windowId;
     _AXUIElementGetWindow(window, &windowId);
 
     if (windowId == handle) {
+      CFRelease(windows);
       return window;
     }
   }
 
+  CFRelease(windows);
   return NULL;
 }
 
 void cacheWindow(int handle, int pid) {
-  if (_requestAccessibility(false)) { 
+  if (_requestAccessibility(false)) {
     if (windowsMap.find(handle) == windowsMap.end()) {
       windowsMap[handle] = getAXWindow(pid, handle);
     }
@@ -115,6 +119,7 @@ AXUIElementRef getAXWindowById(int handle) {
     arr[i] = vec[i];
   }
 
+  CFRelease(windowList);
   return arr;
 }
 
@@ -130,11 +135,17 @@ AXUIElementRef getAXWindowById(int handle) {
 
     auto app = [NSRunningApplication runningApplicationWithProcessIdentifier: [ownerPid intValue]];
 
-    if (![app isActive]) continue;
+    if (![app isActive]) {
+      [app release];
+      continue;
+    }
 
+    [app release];
+    CFRelease(windowList);
     return Napi::Number::New(env, [windowNumber intValue]);
-  }  
+  }
 
+  CFRelease(windowList);
   return Napi::Number::New(env, 0);
 }
 
@@ -147,17 +158,18 @@ AXUIElementRef getAXWindowById(int handle) {
 
   if (wInfo) {
     NSNumber *ownerPid = wInfo[(id)kCGWindowOwnerPID];
-    auto app = [NSRunningApplication runningApplicationWithProcessIdentifier: [ownerPid intValue]];
+    NSRunningApplication *app = [NSRunningApplication runningApplicationWithProcessIdentifier: [ownerPid intValue]];
 
     auto obj = Napi::Object::New(env);
     obj.Set("processId", [ownerPid intValue]);
     obj.Set("path", [app.bundleURL.path UTF8String]);
 
     cacheWindow(handle, [ownerPid intValue]);
-  
+
+    [app release];
     return obj;
   }
- 
+
   return Napi::Object::New(env);
 }
 
@@ -222,7 +234,7 @@ AXUIElementRef getAXWindowById(int handle) {
     CFTypeRef sizeStorage = (CFTypeRef)(AXValueCreate((AXValueType)kAXValueCGSizeType, (const void *)&size));
     AXUIElementSetAttributeValue(win, kAXSizeAttribute, sizeStorage);
   }
-  
+
   return Napi::Boolean::New(env, true);
 }
 
@@ -305,4 +317,4 @@ AXUIElementRef getAXWindowById(int handle) {
     return exports;
 }
 
-NODE_API_MODULE(addon, Init)
+NODE_API_MODULE(addon, Init)