fix: getting window process path on Windows

Author: sentialx

example.js

@@ -4,20 +4,4 @@ console.time("getActiveWindow");
 const window = windowManager.getActiveWindow();
 console.timeEnd("getActiveWindow");
 
-console.time("getTitle");
-console.log(window.getTitle());
-console.timeEnd("getTitle");
-
-console.time("getBounds");
-console.log(window.getBounds());
-console.timeEnd("getBounds");
-
-console.time("setBounds");
-window.setBounds({ x: 0, y: 0 });
-console.timeEnd("setBounds");
-
-windowManager.on("window-activated", window => {
-  console.log(window.getTitle());
-});
-
-console.log(windowManager.getWindows());
+console.log(window.path);

lib/windows.cc

@@ -42,13 +42,15 @@ Process getWindowProcess(HWND handle) {
     DWORD pid{0};
     GetWindowThreadProcessId(handle, &pid);
 
+    HANDLE pHandle{OpenProcess(PROCESS_QUERY_LIMITED_INFORMATION, false, pid)};
+
     DWORD dwSize{MAX_PATH};
     wchar_t exeName[MAX_PATH]{};
 
-    QueryFullProcessImageNameW(handle, 0, exeName, &dwSize);
+    QueryFullProcessImageNameW(pHandle, 0, exeName, &dwSize);
 
-    std::wstring wspath(exeName);
-    std::string path(wspath.begin(), wspath.end());
+    auto wspath(exeName);
+    auto path = toUtf8(wspath);
 
     return {static_cast<int>(pid), path};
 }
@@ -186,11 +188,11 @@ Napi::Boolean setWindowBounds(const Napi::CallbackInfo &info) {
     Napi::Env env{info.Env()};
 
     Napi::Object bounds{info[1].As<Napi::Object>()};
+    auto handle{getValueFromCallbackData<HWND>(info, 0)};
 
-    BOOL b{MoveWindow(getValueFromCallbackData<HWND>(info, 0),
-                      bounds.Get("x").ToNumber(), bounds.Get("y").ToNumber(),
-                      bounds.Get("width").ToNumber(),
-                      bounds.Get("height").ToNumber(), true)};
+    BOOL b{MoveWindow(
+        handle, bounds.Get("x").ToNumber(), bounds.Get("y").ToNumber(),
+        bounds.Get("width").ToNumber(), bounds.Get("height").ToNumber(), true)};
 
     return Napi::Boolean::New(env, b);
 }

package-lock.json

@@ -40,7 +40,6 @@
   "files": [
     "dist/",
     "binding.gyp",
-    "compile.js",
     "lib/"
   ]
 }

package.json

@@ -53,10 +53,10 @@ export class Window {
     if (platform() === "win32") {
       const sf = windowManager.getScaleFactor(this.getMonitor());
 
-      bounds.x = Math.round(bounds.x / sf);
-      bounds.y = Math.round(bounds.y / sf);
-      bounds.width = Math.round(bounds.width / sf);
-      bounds.height = Math.round(bounds.height / sf);
+      bounds.x = Math.floor(bounds.x / sf);
+      bounds.y = Math.floor(bounds.y / sf);
+      bounds.width = Math.floor(bounds.width / sf);
+      bounds.height = Math.floor(bounds.height / sf);
     }
 
     return bounds;
@@ -70,10 +70,10 @@ export class Window {
     if (platform() === "win32") {
       const sf = windowManager.getScaleFactor(this.getMonitor());
 
-      newBounds.x = Math.round(newBounds.x * sf);
-      newBounds.y = Math.round(newBounds.y * sf);
-      newBounds.width = Math.round(newBounds.width * sf);
-      newBounds.height = Math.round(newBounds.height * sf);
+      newBounds.x = Math.floor(newBounds.x * sf);
+      newBounds.y = Math.floor(newBounds.y * sf);
+      newBounds.width = Math.floor(newBounds.width * sf);
+      newBounds.height = Math.floor(newBounds.height * sf);
 
       addon.setWindowBounds(this.id, newBounds);
     } else if (platform() === "darwin") {