-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
Description
There are a couple of options that we can use in the config file that I think are too coupled with the code. Meaning: I think they should be optional because not every dataset needs these options and at the moment the code forces one to have them in the config file. There is a caveat that I already mentioned in the issue #66: most of these things are in the ChunkDataset class and maybe we should have more than one template for a dataset. Anyways, imo it is still worth thinking if these things are really needed or can be optional:
datasets.py- line 329: if I don't have any statistics, this doesn't work. Should one always have statistics? If so, why?
- line 363: forces one to have
transformin the config file. - line 457: forces one to have
offsetin the config file. Probably useget("offset", 0)is a better idea. - line 461: forces one to have
phase_shiftsin the data. Is this extremely necessary? Maybe check before accessing the_phase_shitsattribute or set a default value that makes sense for the_phase_shifts? I think this breaks the code if one passesphase_shift_per_signalasFalseto theSequenceInterpolatorand then tries to use it.
interpolators.py- line 100: forces one to have
phase_shift_per_signalin the config file. Maybe change tometa.get('phase_shift_per_signal', False)?
- line 100: forces one to have