Compilation note in SNRZFindPulse

[dfloer]

The was a small ABI change in GCC 7.1.

Compiling on GCC 8.3.0 (and later, probably) gives the two notes.

/usr/include/c++/8.3.0/bits/vector.tcc: In member function 'void std::vector<_Tp, _Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Args&& ...) [with _Args = {FixedPulseDetector<float>}; _Tp = FixedPulseDetector<float>; _Alloc = std::allocator<FixedPulseDetector<float> >]':
/usr/include/c++/8.3.0/bits/vector.tcc:413:7: note: parameter passing for argument of type 'std::vector<FixedPulseDetector<float> >::iterator' {aka '__gnu_cxx::__normal_iterator<FixedPulseDetector<float>*, std::vector<FixedPulseDetector<float> > >'} changed in GCC 7.1
       vector<_Tp, _Alloc>::
       ^~~~~~~~~~~~~~~~~~~

and

/usr/include/c++/8.3.0/bits/vector.tcc: In constructor 'SpectralPulseFinder::SpectralPulseFinder(int, int, int, int, int, int, int, double, double, double)':
/usr/include/c++/8.3.0/bits/vector.tcc:109:4: note: parameter passing for argument of type '__gnu_cxx::__normal_iterator<FixedPulseDetector<float>*, std::vector<FixedPulseDetector<float> > >' changed in GCC 7.1
    _M_realloc_insert(end(), std::forward<_Args>(__args)...);
    ^~~~~~~~~~~~~~~~~

Currently, as everything should be compiled with GCC 7.1 or later, we can safely ignore this note by passing g++ -Wno-psabi.