wip

Author: silesky

packages/signals/signals/src/core/signals/signals.ts

@@ -38,11 +38,11 @@ export class Signals implements ISignals {
   private globalSettings: SignalGlobalSettings
   constructor(settingsConfig: SignalsSettingsConfig = {}) {
     this.globalSettings = new SignalGlobalSettings(settingsConfig)
-    this.buffer = getSignalBuffer(this.globalSettings.signalBuffer)
-    this.signalEmitter = this.getSignalEmitter(settingsConfig.middleware)
     if (settingsConfig.debug) {
       this.debug()
     }
+    this.buffer = getSignalBuffer(this.globalSettings.signalBuffer)
+    this.signalEmitter = this.getSignalEmitter(settingsConfig.middleware)
 
     // We register the generators (along with the signal emitter) so they start collecting signals before the plugin is started.
     // Otherwise, we would wait until analytics is loaded, which would skip things like page network URL changes.

packages/signals/signals/src/plugin/signals-plugin.ts

@@ -29,16 +29,9 @@ export class SignalsPlugin implements Plugin, SignalsAugmentedFunctionality {
   public signals: Signals
   constructor(settings: SignalsPluginSettingsConfig = {}) {
     assertBrowserEnv()
-    // assign to window for debugging purposes
-    Object.assign(window, { SegmentSignalsPlugin: this })
-
-    if (settings.enableDebugLogging) {
-      logger.enableLogging('debug')
-    }
 
-    logger.debug(`SignalsPlugin v${version} initializing`, {
-      settings,
-    })
+    // assign to window.SegmentSignalsPlugin for debugging purposes (e.g window.SegmentSignalsPlugin.debug())
+    Object.assign(window, { SegmentSignalsPlugin: this })
 
     this.signals = new Signals({
       debug: settings.debug,
@@ -60,6 +53,10 @@ export class SignalsPlugin implements Plugin, SignalsAugmentedFunctionality {
       signalStorageType: settings.signalStorageType,
       middleware: settings.middleware,
     })
+
+    logger.debug(`SignalsPlugin v${version} initializing`, {
+      settings,
+    })
   }
 
   isLoaded() {
@@ -92,7 +89,8 @@ export class SignalsPlugin implements Plugin, SignalsAugmentedFunctionality {
   /**
    * Enable redaction and disable ingestion of signals. Also, logs signals to the console.
    */
-  debug(...args: Parameters<typeof this.signals['debug']>): void {
+  debug(...args: Parameters<typeof this.signals['debug']>): this {
     this.signals.debug(...args)
+    return this
   }
 }

packages/signals/signals/src/types/settings.ts

@@ -13,18 +13,12 @@ export interface SignalsPluginSettingsConfig {
   processSignal?: string | ProcessSignal
 
   /**
-   * Enable debug mode. Same as ?debug=true in the URL or SignalsPlugin.debug(true)
-   * This sets the log level to 'info', disables redaction, and enables signals ingestion
+   * Enable debug mode. Same as ?segment_signals_debug=true in the URL
+   * This sets the log level to 'info', disables redaction, and enables signals ingestion (sending signals to segment)
    * @default false
    */
   debug?: boolean
 
-  /**
-   * Add console debug logging
-   * @default false
-   */
-  enableDebugLogging?: boolean
-
   /**
    * Disable redaction of signals
    * @default false