Fix VTA call-graph invocation from HelperAnalyses (#805)

Author: fabianbs96

.gitignore

@@ -33,6 +33,8 @@ log/*
 # MS VS Code
 .vscode/
 
+.devcontainer/
+
 # Eclipse
 .cproject
 .project

include/phasar/ControlFlow/CallGraphAnalysisType.h

@@ -22,6 +22,12 @@ enum class CallGraphAnalysisType {
   Invalid
 };
 
+[[nodiscard]] constexpr bool
+needsAliasInfo(CallGraphAnalysisType CGTy) noexcept {
+  return CGTy == CallGraphAnalysisType::OTF ||
+         CGTy == CallGraphAnalysisType::VTA;
+}
+
 std::string toString(CallGraphAnalysisType CGA);
 
 CallGraphAnalysisType toCallGraphAnalysisType(llvm::StringRef S);

lib/PhasarLLVM/HelperAnalyses.cpp

@@ -94,8 +94,8 @@ LLVMBasedICFG &HelperAnalyses::getICFG() {
     } else {
       ICF = std::make_unique<LLVMBasedICFG>(
           &getProjectIRDB(), CGTy, std::move(EntryPoints), &getTypeHierarchy(),
-          CGTy == CallGraphAnalysisType::OTF ? &getAliasInfo() : nullptr,
-          SoundnessLevel, AutoGlobalSupport);
+          needsAliasInfo(CGTy) ? &getAliasInfo() : nullptr, SoundnessLevel,
+          AutoGlobalSupport);
     }
   }