Skip to content

Commit 243554e

Browse files
Fix transform_to_data_extent converting labels to images (#791)
* Add test case for issue 783 * Pass parameter return_regions_as_labels=True to rasterize to preserve labels --------- Co-authored-by: Luca Marconato <m.lucalmer@gmail.com>
1 parent 803a66e commit 243554e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/spatialdata/_core/operations/_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ def transform_to_data_extent(
125125
target_width=target_width,
126126
target_height=None,
127127
target_depth=None,
128+
return_regions_as_labels=True,
128129
)
129130
sdata_to_return_elements[element_name] = rasterized
130131
else:

tests/core/operations/test_spatialdata_operations.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
PointsModel,
1818
ShapesModel,
1919
TableModel,
20+
get_model,
2021
get_table_keys,
2122
)
2223
from spatialdata.testing import assert_elements_dict_are_identical, assert_spatial_data_objects_are_identical
@@ -474,6 +475,7 @@ def test_transform_to_data_extent(full_sdata: SpatialData, maintain_positioning:
474475
for element in elements:
475476
before = full_sdata[element]
476477
after = sdata[element]
478+
assert get_model(after) == get_model(before)
477479
data_extent_before = get_extent(before, coordinate_system="global")
478480
data_extent_after = get_extent(after, coordinate_system="global")
479481
# huge tolerance because of the bug with pixel perfectness

0 commit comments

Comments
 (0)