Skip to content

Commit 53b9801

Browse files
elwerOutlyingWestElias Werner
authored
Fix/animation with tqdm repairing (#47)
* Fix spinner animation with tqdm output and refactor Score-P stream reading - Spinner no longer overlaps with tqdm due to proper threading.Event handling - Score-P stdout and stderr are read in separate threads with chunked reading - Animation is disabled in multicell mode when needed - README.md and error logging improved * multicellmode_timestamps removed from reading streams functions * remove MCM from child process, check for multiple truthy values * formatting, linter and bugfix in truthy values eval * logging in files fixed, minor stream reading improvements * disabling animations hint added * getting stuck while reading pipes fixed * KernelTestLogError fix * hint message improved; logging dir renamed to logs_scorep_jupyter * make log directory relative to project root * error logs without suppressing and Logging Configuration section in README.md update * logs directory name changed * preserve subprocess output in variables to show later; hint message corrected * hint logic changed to be shown in all cases --------- Co-authored-by: OutlyingWest <[email protected]> Co-authored-by: Elias Werner <[email protected]>
1 parent 43e8776 commit 53b9801

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/scorep_jupyter/kernel_messages.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import os
12
from enum import Enum, auto
23

34
from .logging_config import LOGGING

src/scorep_jupyter/userpersistence.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,6 @@ def stop(self, done_message="Done."):
501501

502502

503503
def create_busy_spinner(lock=None, stop_event=None, is_multicell_final=False):
504-
505504
is_enabled = str(
506505
os.getenv("SCOREP_JUPYTER_DISABLE_PROCESSING_ANIMATIONS")
507506
).lower() not in ["true", "1", "t"]

0 commit comments

Comments
 (0)