Skip to content

Commit 6228713

Browse files
authored
fix: increase timeout for discovery (#149)
1 parent be02b14 commit 6228713

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

synapse/cli/__main__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def setup_device_uri(args):
3737
if not is_valid_ip(args.uri):
3838
# User passed in a name
3939
console = Console()
40-
device_ip = find_device_by_name(args.uri, console)
40+
device_ip = find_device_by_name(args.uri, console, False, 60)
4141
if not device_ip:
4242
return None
4343
args.uri = device_ip

synapse/utils/discover.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,16 +57,19 @@ def discover(timeout_sec=DISCOVERY_TIMEOUT_SEC):
5757
return list(discover_iter(timeout_sec))
5858

5959

60-
def find_device_by_name(name, console, include_rpc_port=False):
60+
def find_device_by_name(
61+
name,
62+
console,
63+
include_rpc_port=False,
64+
discovery_timeout_sec=5,
65+
):
6166
"""Find a device by name using the discovery process."""
6267
with console.status(
6368
f"Searching for device with name {name}...", spinner="bouncingBall"
6469
):
6570
# We are broadcasting data every 1 second
66-
socket_timeout_sec = 1
67-
discovery_timeout_sec = 5
6871
found_devices = []
69-
devices = discover_iter(socket_timeout_sec, discovery_timeout_sec)
72+
devices = discover_iter(1, discovery_timeout_sec)
7073
for device in devices:
7174
if device.name.lower() == name.lower():
7275
if include_rpc_port:

0 commit comments

Comments
 (0)