chore: Typescript plugin update (#107)

haifeng-li-at-salesforce · web-flow · commit 21b3e9f64c28 · 2025-03-24T10:05:04.000-07:00
* chore: update ts rule tester to 8.27.0

* fix: revert back the package version

* fix: clean-up redundant code
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -74,9 +74,8 @@
         "@types/eslint": "^8.56.10",
         "@types/estree": "^1.0.6",
         "@types/jest": "^29.5.14",
-        "@typescript-eslint/eslint-plugin": "^7.8.0",
-        "@typescript-eslint/parser": "^7.18.0",
-        "@typescript-eslint/rule-tester": "^7.8.0",
+        "@typescript-eslint/parser": "^8.27.0",
+        "@typescript-eslint/rule-tester": "^8.27.0",
         "conventional-changelog-conventionalcommits": "^8.0.0",
         "eslint": "^8.57.0",
         "eslint-plugin-eslint-plugin": "^6.4.0",
@@ -94,7 +93,7 @@
         "ts-node": "^10.9.2",
         "typescript": "^5.8.2",
         "typescript-eslint": "^8.17.0"
-   },
+    },
     "peerDependencies": {
         "eslint": ">=7"
     },
diff --git a/test/rules/apex/apex-import.spec.ts b/test/rules/apex/apex-import.spec.ts
@@ -8,13 +8,10 @@
 import { RuleTester } from '@typescript-eslint/rule-tester';
 
 import { rule, APEX_IMPORT_RULE_ID } from '../../../src/rules/apex/apex-import';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
-const ruleTester = new RuleTester({
-    parser: '@typescript-eslint/parser'
-});
+const ruleTester = new RuleTester();
 
-ruleTester.run(createScopedModuleRuleName(APEX_IMPORT_RULE_ID), rule, {
+ruleTester.run(APEX_IMPORT_RULE_ID, rule as any, {
     valid: [
         {
             code: `
diff --git a/test/rules/graphql/no-aggregate-query-supported.spec.ts b/test/rules/graphql/no-aggregate-query-supported.spec.ts
@@ -9,11 +9,9 @@ import {
     rule,
     NO_AGGREGATE_QUERY_SUPPORTED_RULE_ID
 } from '../../../src/rules/graphql/no-aggregate-query-supported';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
-
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_AGGREGATE_QUERY_SUPPORTED_RULE_ID), rule as any, {
+ruleTester.run(NO_AGGREGATE_QUERY_SUPPORTED_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-fiscal-date-filtering-supported.spec.ts b/test/rules/graphql/no-fiscal-date-filtering-supported.spec.ts
@@ -12,7 +12,7 @@ import {
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run('@salesforce/lwc-mobile/no-fiscal-date-filtering-supported', rule as any, {
+ruleTester.run(NO_FISCAL_DATE_FILTER_SUPPORTED_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-more-than-1-parent-record.spec.ts b/test/rules/graphql/no-more-than-1-parent-record.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_MORE_THAN_1_PARENT_RECORD_RULE_ID
 } from '../../../src/rules/graphql/no-more-than-1-parent-record';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_MORE_THAN_1_PARENT_RECORD_RULE_ID), rule as any, {
+ruleTester.run(NO_MORE_THAN_1_PARENT_RECORD_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-more-than-100-fields.spec.ts b/test/rules/graphql/no-more-than-100-fields.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_MORE_THAN_100_FIELDS_RULE_ID
 } from '../../../src/rules/graphql/no-more-than-100-fields';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_MORE_THAN_100_FIELDS_RULE_ID), rule as any, {
+ruleTester.run(NO_MORE_THAN_100_FIELDS_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-more-than-3-children-entities.spec.ts b/test/rules/graphql/no-more-than-3-children-entities.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_MORE_THAN_3_CHILD_ENTITIES_RULE_ID
 } from '../../../src/rules/graphql/no-more-than-3-child-entities';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_MORE_THAN_3_CHILD_ENTITIES_RULE_ID), rule as any, {
+ruleTester.run(NO_MORE_THAN_3_CHILD_ENTITIES_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-more-than-3-root-entities.spec.ts b/test/rules/graphql/no-more-than-3-root-entities.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_MORE_THAN_3_ROOT_ENTITIES_RULE_ID
 } from '../../../src/rules/graphql/no-more-than-3-root-entities';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_MORE_THAN_3_ROOT_ENTITIES_RULE_ID), rule as any, {
+ruleTester.run(NO_MORE_THAN_3_ROOT_ENTITIES_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-mutation-supported.spec.ts b/test/rules/graphql/no-mutation-supported.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_MUTATION_SUPPORTED_RULE_ID
 } from '../../../src/rules/graphql/no-mutation-supported';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_MUTATION_SUPPORTED_RULE_ID), rule as any, {
+ruleTester.run(NO_MUTATION_SUPPORTED_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/no-semi-anti-join-supported.spec.ts b/test/rules/graphql/no-semi-anti-join-supported.spec.ts
@@ -9,11 +9,10 @@ import {
     rule,
     NO_SEMI_ANTI_JOIN_SUPPORTED_RULE_ID
 } from '../../../src/rules/graphql/no-semi-anti-join-supported';
-import { createScopedModuleRuleName } from '../../../src/util/rule-helpers';
 
 import { ruleTester } from '../../shared';
 
-ruleTester.run(createScopedModuleRuleName(NO_SEMI_ANTI_JOIN_SUPPORTED_RULE_ID), rule as any, {
+ruleTester.run(NO_SEMI_ANTI_JOIN_SUPPORTED_RULE_ID, rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/rules/graphql/unsupported-scope.spec.ts b/test/rules/graphql/unsupported-scope.spec.ts
@@ -12,7 +12,7 @@ import {
 } from '../../../src/rules/graphql/unsupported-scope';
 import { ruleTester } from '../../shared';
 
-ruleTester.run('@salesforce/lwc-mobile/offline-graphql-unsupported-scope', rule as any, {
+ruleTester.run('offline-graphql-unsupported-scope', rule as any, {
     valid: [
         {
             code: /* GraphQL */ `
diff --git a/test/shared.ts b/test/shared.ts
@@ -6,12 +6,13 @@
  */
 
 import { RuleTester } from '@typescript-eslint/rule-tester';
+import { parseForESLint } from '@graphql-eslint/eslint-plugin';
 
-const RULE_TESTER_CONFIG = {
-    parser: '@graphql-eslint/eslint-plugin',
-    parserOptions: {
-        graphQLConfig: {}
+export const ruleTester = new RuleTester({
+    languageOptions: {
+        parser: { parseForESLint },
+        parserOptions: {
+            graphQLConfig: {}
+        }
     }
-};
-
-export const ruleTester = new RuleTester(RULE_TESTER_CONFIG);
+});

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ import {`
`12`	`12`
`13`	`13`	`import { ruleTester } from '../../shared';`
`14`	`14`
`15`		`-ruleTester.run('@salesforce/lwc-mobile/no-fiscal-date-filtering-supported', rule as any, {`
	`15`	`+ruleTester.run(NO_FISCAL_DATE_FILTER_SUPPORTED_RULE_ID, rule as any, {`
`16`	`16`	`valid: [`
`17`	`17`	`{`
`18`	`18`	code: /* GraphQL */ `