fix: avoid errors for LwcBundle.getBundleKey

Author: haifeng-li-at-salesforce

lib/lwc-bundle.js

@@ -125,15 +125,16 @@ class LwcBundle {
     /**
      * Gets a unique key for this bundle based on its js file since komaci only supports js files. This key is used as file name for further linting.
      *
-     * @returns {string} A unique key in the format `<base file name>_<uuid>.<extension>`
+     * @returns {string} A unique key in the format `<base file name>_<uuid>.js`
      */
     getBundleKey() {
-        if (!this.#js) {
-            throw new Error('Cannot generate bundle key: no js file exists');
+        const primaryFile = this.primaryFile;
+        if (!primaryFile) {
+            throw new Error('Cannot generate bundle key: no primary file exists');
         }
 
-        const { name, ext } = parse(this.#js.filename);
-        return `${name}_${this.#primaryFileUuidKey}${ext}`;
+        const { name } = parse(primaryFile.filename);
+        return `${name}_${this.#primaryFileUuidKey}.js`;
     }
 
     /**

lib/processor.js

@@ -127,16 +127,12 @@ class BundleAnalyzer {
         // Get the unique key for this bundle, which will be used as the filename for ESLint processing. It should always be a js file since komaci only supports js files.
         const uniqueFilename = this.#lwcBundle.getBundleKey();
 
-        // For JavaScript files, we need to return the original text so that ESLint can parse it
-        // and properly handle disable comments. For all other file types (like HTML), we return
-        // the JS content from the bundle so that rules can run and report violations targeting
+        // For JavaScript files, we need to return the JS content from the bundle so that ESLint can parse it
+        // and properly handle disable comments. For HTML files, we return
+        // the JS content too so that rules can run and report violations targeting
         // the HTML file.
-        if (fileExtension === '.js') {
-            return [{ text, filename: uniqueFilename }];
-        } else {
-            // Return JS content so ESLint can parse it and rules can run
-            return [{ text: this.#lwcBundle.js?.content || '', filename: uniqueFilename }];
-        }
+
+        return [{ text: this.#lwcBundle.js?.content || '', filename: uniqueFilename }];
     };
 
     /**

test/lib/lwc-bundle.js

@@ -191,10 +191,10 @@ describe('LwcBundle', () => {
             expect(key).to.match(/^test_[0-9a-f-]+\.js$/);
         });
 
-        it('should throw error when no js file exists', () => {
+        it('should throw error when no primary file exists', () => {
             const bundle = LwcBundle.lwcBundleFromContent('test', undefined, 'html content');
             expect(() => bundle.getBundleKey()).to.throw(
-                'Cannot generate bundle key: no js file exists'
+                'Cannot generate bundle key: no primary file exists'
             );
         });
     });

test/lib/processor.js

@@ -65,14 +65,15 @@ describe('BundleAnalyzer', () => {
             expect(result[0].filename).to.equal(bundleAnalyzer.lwcBundle.getBundleKey());
         });
 
-        it('should throw error when preprocessing html file with existing bundle that has no js file', () => {
+        it('should process html file with existing bundle', () => {
             const htmlContent = '<template></template>';
             bundleAnalyzer.setLwcBundleFromContent('test', undefined, htmlContent);
+            bundleAnalyzer.lwcBundle.setPrimaryFileByContent(htmlContent);
 
-            expect(() => bundleAnalyzer.preprocess(htmlContent, 'test.html')).to.throw(
-                Error,
-                'Cannot generate bundle key: no js file exists'
-            );
+            const result = bundleAnalyzer.preprocess(htmlContent, 'test.html');
+            expect(result).to.have.length(1);
+            expect(result[0].text).to.equal('');
+            expect(result[0].filename).to.equal(bundleAnalyzer.lwcBundle.getBundleKey());
         });
 
         it('should return empty array when no matching file found in bundle', () => {

test/lib/rules/programmatic-bundle-lint.js

@@ -118,53 +118,6 @@ export default class TestComponent extends LightningElement {
         expect(htmlViolation.line).toBeGreaterThan(0);
     });
 
-    it('should handle multiple HTML templates', () => {
-        const jsContent = `
-import { LightningElement } from 'lwc';
-export default class MyComponent extends LightningElement {
-    get value() {
-        const x = 1;
-        return x;
-    }
-}`;
-
-        const htmlContent1 = `<template><div>{value}</div></template>`;
-        const htmlContent2 = `<template><div>Second template</div></template>`;
-
-        // Set up bundle with multiple HTML templates
-        bundleAnalyzer.setLwcBundleFromContent(
-            'myComponent',
-            jsContent,
-            htmlContent1,
-            htmlContent2
-        );
-
-        const pluginPrefix = '@salesforce/lwc-graph-analyzer';
-        const config = {
-            ...baseConfig,
-            plugins: { [pluginPrefix]: lwcGraphAnalyzer },
-            rules: {
-                [`${pluginPrefix}/no-getter-contains-more-than-return-statement`]: 'error'
-            }
-        };
-
-        const linter = new Linter();
-
-        // Lint JS file
-        const jsErrors = linter.verify(jsContent, config, {
-            filename: 'myComponent.js'
-        });
-
-        // Should have violation because getter is referenced in HTML
-        expect(jsErrors.length).toBeGreaterThan(0);
-        const violation = jsErrors.find(
-            (err) =>
-                err.ruleId ===
-                '@salesforce/lwc-graph-analyzer/no-getter-contains-more-than-return-statement'
-        );
-        expect(violation).toBeDefined();
-    });
-
     it('should return empty violations when no errors exist', () => {
         const jsContent = `
 import { LightningElement } from 'lwc';

test/lib/util/bundle-state-manager.js

@@ -36,11 +36,11 @@ describe('BundleStateManager', () => {
             expect(bundleStateManager.getBundleByKey(bundle.getBundleKey())).to.equal(bundle);
         });
 
-        it('should return defined key when bundle has js file', () => {
+        it('should return undefined key when bundle has no primary file', () => {
             const jsContent = 'export default class Test {}';
             const bundle = LwcBundle.lwcBundleFromContent('test', jsContent);
             const key = bundleStateManager.addBundleState(bundle);
-            expect(key).to.not.be.undefined;
+            expect(key).to.be.undefined;
         });
     });