fix: revert changes for html lint

Author: haifeng-li-at-salesforce

lib/lwc-bundle.js

@@ -123,18 +123,18 @@ class LwcBundle {
     }
 
     /**
-     * Gets a unique key for this bundle based on its js file since komaci only supports js files. This key is used as file name for further linting.
+     * Gets a unique key for this bundle based on its primary file
      *
-     * @returns {string} A unique key in the format `<base file name>_<uuid>.js`
+     * @returns {string} A unique key in the format `<base file name>_<uuid>.<extension>`
      */
     getBundleKey() {
         const primaryFile = this.primaryFile;
         if (!primaryFile) {
             throw new Error('Cannot generate bundle key: no primary file exists');
         }
 
-        const { name } = parse(primaryFile.filename);
-        return `${name}_${this.#primaryFileUuidKey}.js`;
+        const { name, ext } = parse(primaryFile.filename);
+        return `${name}_${this.#primaryFileUuidKey}${ext}`;
     }
 
     /**

lib/processor.js

@@ -124,15 +124,18 @@ class BundleAnalyzer {
 
         setLwcBundleCacheEntry(this.#lwcBundle);
 
-        // Get the unique key for this bundle, which will be used as the filename for ESLint processing. It should always be a js file since komaci only supports js files.
+        // Get the unique key for this bundle, which will be used as the filename for ESLint processing
         const uniqueFilename = this.#lwcBundle.getBundleKey();
 
-        // For JavaScript files, we need to return the JS content from the bundle so that ESLint can parse it
-        // and properly handle disable comments. For HTML files, we return
-        // the JS content too so that rules can run and report violations targeting
-        // the HTML file.
-
-        return [{ text: this.#lwcBundle.js?.content || '', filename: uniqueFilename }];
+        // For JavaScript files, we need to return the original text so that ESLint can parse it
+        // and properly handle disable comments. For all other file types (like HTML), we return
+        // an empty string to prevent ESLint from attempting to parse them, since our rules
+        // don't need the parsed AST for non-JS files.
+        if (fileExtension === '.js') {
+            return [{ text, filename: uniqueFilename }];
+        } else {
+            return [{ text: '', filename: uniqueFilename }];
+        }
     };
 
     /**

test/lib/lwc-bundle.js

@@ -192,7 +192,7 @@ describe('LwcBundle', () => {
         });
 
         it('should throw error when no primary file exists', () => {
-            const bundle = LwcBundle.lwcBundleFromContent('test', undefined, 'html content');
+            const bundle = LwcBundle.lwcBundleFromContent('test', 'js content', 'html content');
             expect(() => bundle.getBundleKey()).to.throw(
                 'Cannot generate bundle key: no primary file exists'
             );

test/lib/rules/programmatic-bundle-lint.js

@@ -86,11 +86,6 @@ export default class TestComponent extends LightningElement {
             htmlContent // HTML content
         );
 
-        // 5. Lint HTML file
-        const htmlErrors = linter.verify(htmlContent, config, {
-            filename: 'testComponent.html'
-        });
-
         // Verify we got violations for the JS file
         // The displayValue getter violates the rule because it's referenced in HTML
         expect(jsErrors.length).toBeGreaterThan(0);
@@ -105,17 +100,6 @@ export default class TestComponent extends LightningElement {
         );
         expect(jsViolation.message).toBe('Getters can only contain a return statement.');
         expect(jsViolation.line).toBeGreaterThan(0);
-
-        expect(htmlErrors.length).toBe(1);
-        const htmlViolation = htmlErrors[0];
-        expect(htmlViolation).toBeDefined();
-        expect(htmlViolation.ruleId).toBe(
-            '@salesforce/lwc-graph-analyzer/no-composition-on-unanalyzable-property-non-public'
-        );
-        expect(htmlViolation.message).toBe(
-            "This child component references an unanalyzable property 'descriptionValue' that’s not a public property."
-        );
-        expect(htmlViolation.line).toBeGreaterThan(0);
     });
 
     it('should return empty violations when no errors exist', () => {
@@ -144,23 +128,13 @@ export default class MyComponent extends LightningElement {
             filename: 'myComponent.js'
         });
 
-        const htmlErrors = linter.verify(htmlContent, config, {
-            filename: 'myComponent.html'
-        });
-
         // No violations expected since we're using a simple property, not a getter
         const jsViolations = jsErrors.filter(
             (err) =>
                 err.ruleId ===
                 '@salesforce/lwc-graph-analyzer/no-getter-contains-more-than-return-statement'
         );
-        const htmlViolations = htmlErrors.filter(
-            (err) =>
-                err.ruleId ===
-                '@salesforce/lwc-graph-analyzer/no-getter-contains-more-than-return-statement'
-        );
 
         expect(jsViolations.length).toBe(0);
-        expect(htmlViolations.length).toBe(0);
     });
 });