Prepare 'errorformat' locally because editing sh files can reset it

Author: sakhnik

lua/nvimgdb.lua

@@ -3,13 +3,11 @@
 local log = require 'nvimgdb.log'
 
 ---@class NvimGdb globally accessible plugin entry point
----@field public efmmgr EfmMgr errorformat manager
 ---@field private apps table<number, App> collection of debugger sessions {tabpage -> App}
 ---@field private apps_size number count of running debugger sessions
 
 -- Global instance
 NvimGdb = {
-  efmmgr = require 'nvimgdb.efmmgr',
   apps = {},
   apps_size = 0,
   mt = {},
@@ -111,7 +109,6 @@ function NvimGdb.cleanup(tab)
       if NvimGdb.apps_size == 0 then
         -- Cleanup commands, autocommands etc
         NvimGdb.global_cleanup()
-        NvimGdb.efmmgr.cleanup()
         app:get_win():unset_keymaps()
       end
       app:cleanup(tab)

lua/nvimgdb/app.lua

@@ -16,7 +16,6 @@ local NvimGdb = require'nvimgdb'
 ---@field private parser ParserImpl debugger output parser
 ---@field private tabpage_created boolean indicates whether the tabpage was created and needs to be closed during cleanup
 local App = {}
-App.efmmgr = require 'nvimgdb.efmmgr'
 App.__index = App
 
 ---Create a new instance of the debugger in the current tabpage.
@@ -85,9 +84,6 @@ function App.new(backend_name, client_cmd)
   local parser_actions = require'nvimgdb.parser_actions'.new(self.cursor, self.win)
   self.parser = self.backend.create_parser(parser_actions, self.proxy)
 
-  -- Setup 'errorformat' for the given backend.
-  App.efmmgr.setup(self.backend.get_error_formats())
-
   return self
 end
 
@@ -117,9 +113,6 @@ function App:cleanup(tab)
     destr()
   end
 
-  -- Remove from 'errorformat' for the given backend.
-  App.efmmgr.teardown(self.backend.get_error_formats())
-
   -- Destroy the parser
   self.parser:cleanup()
 

lua/nvimgdb/win.lua

@@ -306,11 +306,16 @@ function Win:lopen(cmd, mods)
       self:_with_saved_win(false, function()
         self:_ensure_jump_window()
         vim.api.nvim_win_call(self.jump_win, function()
+          local efmmgr = require 'nvimgdb.efmmgr'
+          local backend = NvimGdb.here.backend
+          -- Setup 'errorformat' for the given backend. Do it locally because 'efm' can change be reset when editing files.
+          efmmgr.setup(backend.get_error_formats())
           log.debug({win = self.jump_win, valid = vim.api.nvim_win_is_valid(self.jump_win), llist = llist})
           local res = vim.fn.setloclist(0, {}, ' ', {lines = llist})
           log.debug({res = res, loclist = vim.fn.getloclist(0, {lines = 1})})
           vim.cmd(mods .. ' lopen')
           log.debug({win = vim.api.nvim_get_current_win(), loclist = vim.fn.getloclist(vim.api.nvim_get_current_win())})
+          efmmgr.teardown(backend.get_error_formats())
         end)
       end)
     end)