Discard pull request approval status on autoplan #6280
Description
Community Note
- Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
- Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
- If you are interested in working on this issue or have submitted a pull request, please leave a comment.
- I'd be willing to implement this feature (contributing guide)
Describe the user story
Currently, the --discard-approval-on-plan option resets the PR approval status when the atlantis plan command is triggered via a PR comment.
In the case of autoplan execution, the PR approval status is preserved, even if the project configuration was changed by an additional commit.
This is related to the fact that in the run function of the PlanCommandRunner struct there is a code section responsible for resetting the PR approval, whereas in the runAutoplan function there is no such logic.
Describe the solution you'd like
It seems logical to also reset the PR approval status in the case of autoplan, meaning when a new commit is added that changes the project.
Describe the drawbacks of your solution
I don’t see any issues with adding this functionality, especially since the option description in the documentation states that the PR approval is reset when a new plan is executed.