Updates for review

Author: Doug Edey

README.md

@@ -97,15 +97,15 @@ Here are the Markdown snippets for the two badges:
 
 ## Using this Gem for testing custom cops
 
-You can use this gem to test your own cops, by using the `Rubocop::Minitest::Test` test class, you'll get `assert_offense`, `assert_correction`, and `assert_no_offense` helpers
+You can use this gem to test your own cops, by using the `RuboCop::Minitest::Test` test class, you'll get `assert_offense`, `assert_correction`, and `assert_no_offense` helpers
 
 ```ruby
 
 require "rubocop/minitest/support"
 require "custom_cops/my_cop"
 
 module CustomCops
-  class MyCopTest < Rubocop::Minitest::Test
+  class MyCopTest < RuboCop::Minitest::Test
     test "registers offense" do
       assert_offense(<<~RUBY)
         class FooTest < Minitest::Test
@@ -158,9 +158,24 @@ module CustomCops
         end
       RUBY
     end
+
+    # You can set the `@cop` attribute to override the auto-detected cop and provide configuration options
+    test "override cop configuration" do
+      cop_config = RuboCop::Config.new('Minitest/MultipleAssertions' => { 'Max' => 1 })
+      @cop = RuboCop::Cop::Minitest::MultipleAssertions.new(cop_config)
+
+      assert_offense(<<~RUBY)
+        class FooTest < Minitest::Test
+          def test_asserts_twice
+          ^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [2/1].
+            assert_equal(foo, bar)
+            assert_empty(array)
+          end
+        end
+      RUBY
+    end
   end
 end
-
 ```
 
 ## Contributing

changelog/new_make_test_class_reusable_by_consumers.md

@@ -1 +1 @@
-* Allow `Rubocop::Minitest::Test` to be used by consumers of the gem to test custom cops.
+* Allow `RuboCop::Minitest::Test` to be used by consumers of the gem to test custom cops.

lib/rubocop/minitest/support.rb

@@ -9,7 +9,7 @@
 require 'rubocop/rspec/expect_offense'
 require 'rubocop/cop/legacy/corrector'
 
-module Rubocop
+module RuboCop
   module Minitest
     # Minitest base test class that adds `assert_offense` and `assert_no_offenses`
     #
@@ -23,36 +23,44 @@ module Minitest
     #
     # @example Usage
     #
-    #   assert_offense(<<~RUBY)
-    #     class FooTest < Minitest::Test
-    #       def test_do_something
-    #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
-    #       end
+    #   class AssertNilTest < RuboCop::Minitest::Test
+    #     test "fails when using assert_equal(nil, ...)" do
+    #       assert_offense(<<~RUBY)
+    #         class FooTest < Minitest::Test
+    #           def test_do_something
+    #             assert_equal(nil, somestuff)
+    #             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
+    #           end
+    #         end
+    #       RUBY
     #     end
-    #   RUBY
+    #   end
     #
     # Autocorrection can be tested using `assert_correction` after
     # `assert_offense`.
     #
     # @example `assert_offense` and `assert_correction`
     #
-    #   assert_offense(<<~RUBY)
-    #     class FooTest < Minitest::Test
-    #       def test_do_something
-    #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
-    #       end
-    #     end
-    #   RUBY
+    #   class AssertNilTest < RuboCop::Minitest::Test
+    #      test "autocorrects  when using assert_equal(nil, ...)" do
+    #        assert_offense(<<~RUBY)
+    #          class FooTest < Minitest::Test
+    #           def test_do_something
+    #             assert_equal(nil, somestuff)
+    #             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
+    #           end
+    #         RUBY
     #
-    #   assert_correction(<<~RUBY)
-    #     class FooTest < Minitest::Test
-    #       def test_do_something
-    #         assert_nil(somestuff)
+    #         assert_correction(<<~RUBY)
+    #           class FooTest < Minitest::Test
+    #             def test_do_something
+    #               assert_nil(somestuff)
+    #             end
+    #           end
+    #         RUBY
     #       end
     #     end
-    #   RUBY
+    #   end
     #
     # If you do not want to specify an offense then use the
     # companion method `assert_no_offenses`. This method is a much
@@ -65,17 +73,20 @@ module Minitest
     #
     # @example `assert_offense` and `assert_no_corrections`
     #
-    #   assert_offense(<<~RUBY)
-    #     class FooTest < Minitest::Test
-    #       def test_do_something
-    #         assert_equal(nil, somestuff)
-    #         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
-    #       end
-    #     end
-    #   RUBY
-    #
-    #   assert_no_corrections
+    #   class AssertNilTest < RuboCop::Minitest::Test
+    #     test "no autocorrections"
+    #       assert_offense(<<~RUBY)
+    #         class FooTest < Minitest::Test
+    #           def test_do_something
+    #             assert_equal(nil, somestuff)
+    #             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer using `assert_nil(somestuff)`.
+    #           end
+    #         end
+    #       RUBY
     #
+    #       assert_no_corrections
+    #     end
+    #   end
     class Test < ::Minitest::Test
       class << self
         # Helper to define a test method using a String. Under the hood, it replaces
@@ -193,6 +204,7 @@ def assert_correction(correction, loop: true)
       def setup_assertion
         RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
         RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
+        raise('Could not autodetect cop.') if @cop.nil?
       end
 
       def inspect_source(source, cop, file = nil)

test/project_test.rb

@@ -2,7 +2,7 @@
 
 require_relative 'test_helper'
 
-class ProjectTest < Rubocop::Minitest::Test
+class ProjectTest < RuboCop::Minitest::Test
   def setup
     @issues = []
     @bodies = []

test/rubocop/cop/minitest/assert_empty_literal_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertEmptyLiteralTest < Rubocop::Minitest::Test
+class AssertEmptyLiteralTest < RuboCop::Minitest::Test
   def test_registers_offense_when_asserting_empty_array
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test

test/rubocop/cop/minitest/assert_empty_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertEmptyTest < Rubocop::Minitest::Test
+class AssertEmptyTest < RuboCop::Minitest::Test
   def test_registers_offense_when_using_assert_with_empty
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test

test/rubocop/cop/minitest/assert_equal_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertEqualTest < Rubocop::Minitest::Test
+class AssertEqualTest < RuboCop::Minitest::Test
   def test_registers_offense_when_using_assert_equal_operator_with_string
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test

test/rubocop/cop/minitest/assert_in_delta_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertInDeltaTest < Rubocop::Minitest::Test
+class AssertInDeltaTest < RuboCop::Minitest::Test
   def test_registers_offense_when_using_assert_equal_with_float_as_expected_value
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test

test/rubocop/cop/minitest/assert_includes_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertIncludesTest < Rubocop::Minitest::Test
+class AssertIncludesTest < RuboCop::Minitest::Test
   def test_registers_offense_when_using_assert_with_include
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test

test/rubocop/cop/minitest/assert_instance_of_test.rb

@@ -2,7 +2,7 @@
 
 require_relative '../../../test_helper'
 
-class AssertInstanceOfTest < Rubocop::Minitest::Test
+class AssertInstanceOfTest < RuboCop::Minitest::Test
   def test_registers_offense_when_using_assert_with_instance_of
     assert_offense(<<~RUBY)
       class FooTest < Minitest::Test