avoid include active record test fixtures if use_active_record = false`

Author: moofkit

example_app_generator/no_active_record/spec/verify_no_fixture_setup_spec.rb

@@ -1,21 +1,6 @@
-# Pretend that ActiveRecord::Rails is defined and this doesn't blow up
-# with `config.use_active_record = false`.
-# Trick the other spec that checks that ActiveRecord is
-# *not* defined by wrapping it in RSpec::Rails namespace
-# so that it's reachable from RSpec::Rails::FixtureSupport.
-# NOTE: this has to be defined before requiring `rails_helper`.
-module RSpec
-  module Rails
-    module ActiveRecord
-      module TestFixtures
-      end
-    end
-  end
-end
-
 require 'rails_helper'
 
-RSpec.describe 'Example App', :use_fixtures, type: :model do
+RSpec.describe 'Example App', type: :model do
   it "does not set up fixtures" do
     expect(defined?(fixtures)).not_to be
   end

lib/rspec/rails/fixture_support.rb

@@ -2,52 +2,50 @@ module RSpec
   module Rails
     # @private
     module FixtureSupport
-      if defined?(ActiveRecord::TestFixtures)
-        extend ActiveSupport::Concern
-        include RSpec::Rails::SetupAndTeardownAdapter
-        include RSpec::Rails::MinitestLifecycleAdapter
-        include RSpec::Rails::MinitestAssertionAdapter
-        include ActiveRecord::TestFixtures
-
-        # @private prevent ActiveSupport::TestFixtures to start a DB transaction.
-        # Monkey patched to avoid collisions with 'let(:name)' since Rails 6.1
-        def run_in_transaction?
-          current_example_name = (RSpec.current_example && RSpec.current_example.metadata[:description])
-          use_transactional_tests && !self.class.uses_transaction?(current_example_name)
-        end
-
-        included do
-          if RSpec.configuration.use_active_record?
-            include Fixtures
+      extend ActiveSupport::Concern
+
+      included do
+        if RSpec.configuration.use_active_record? && defined?(ActiveRecord::TestFixtures)
+          include RSpec::Rails::SetupAndTeardownAdapter
+          include RSpec::Rails::MinitestLifecycleAdapter
+          include RSpec::Rails::MinitestAssertionAdapter
+          include ActiveRecord::TestFixtures
+          include Fixtures
+
+          # @private prevent ActiveSupport::TestFixtures to start a DB transaction.
+          # Monkey patched to avoid collisions with 'let(:name)' since Rails 6.1
+          def run_in_transaction?
+            current_example_name = (RSpec.current_example && RSpec.current_example.metadata[:description])
+            use_transactional_tests && !self.class.uses_transaction?(current_example_name)
+          end
 
-            self.fixture_paths = RSpec.configuration.fixture_paths
+          self.fixture_paths = RSpec.configuration.fixture_paths
 
-            self.use_transactional_tests = RSpec.configuration.use_transactional_fixtures
-            self.use_instantiated_fixtures = RSpec.configuration.use_instantiated_fixtures
+          self.use_transactional_tests = RSpec.configuration.use_transactional_fixtures
+          self.use_instantiated_fixtures = RSpec.configuration.use_instantiated_fixtures
 
-            fixtures RSpec.configuration.global_fixtures if RSpec.configuration.global_fixtures
-          end
+          fixtures RSpec.configuration.global_fixtures if RSpec.configuration.global_fixtures
         end
+      end
 
-        module Fixtures
-          extend ActiveSupport::Concern
+      module Fixtures
+        extend ActiveSupport::Concern
 
-          class_methods do
-            def fixtures(*args)
-              super.tap do
-                fixture_sets.each_pair do |method_name, fixture_name|
-                  proxy_method_warning_if_called_in_before_context_scope(method_name, fixture_name)
-                end
+        class_methods do
+          def fixtures(*args)
+            super.tap do
+              fixture_sets.each_pair do |method_name, fixture_name|
+                proxy_method_warning_if_called_in_before_context_scope(method_name, fixture_name)
               end
             end
+          end
 
-            def proxy_method_warning_if_called_in_before_context_scope(method_name, fixture_name)
-              define_method(method_name) do |*args, **kwargs, &blk|
-                if RSpec.current_scope == :before_context_hook
-                  RSpec.warn_with("Calling fixture method in before :context ")
-                else
-                  access_fixture(fixture_name, *args, **kwargs, &blk)
-                end
+          def proxy_method_warning_if_called_in_before_context_scope(method_name, fixture_name)
+            define_method(method_name) do |*args, **kwargs, &blk|
+              if RSpec.current_scope == :before_context_hook
+                RSpec.warn_with("Calling fixture method in before :context ")
+              else
+                access_fixture(fixture_name, *args, **kwargs, &blk)
               end
             end
           end

spec/rspec/rails/fixture_support_spec.rb

@@ -69,5 +69,25 @@ def expect_to_pass(group)
       failure_reporter.exceptions.map { |e| raise e }
       expect(result).to be true
     end
+
+    context "with use_active_record set to false" do
+      it "does not support fixture_path/fixture_paths" do
+        allow(RSpec.configuration).to receive(:use_active_record) { false }
+        group = RSpec::Core::ExampleGroup.describe do
+          include FixtureSupport
+        end
+
+        expect(group).not_to respond_to(:fixture_paths)
+      end
+
+      it "does not include ActiveRecord::TestFixtures" do
+        allow(RSpec.configuration).to receive(:use_active_record) { false }
+        group = RSpec::Core::ExampleGroup.describe do
+          include FixtureSupport
+        end
+
+        expect(group).not_to include(ActiveRecord::TestFixtures)
+      end
+    end
   end
 end