Use keyword arguments for Immediate#initialize (closes #63).

Author: postmodern

lib/ronin/asm/immediate.rb

@@ -55,7 +55,7 @@ class Immediate < Operand
       # @param [nil, 1, 2, 4, 8] width
       #   The size in bytes of the value.
       #
-      def initialize(value,width=nil)
+      def initialize(value, width: nil)
         @value = value.to_i
         @width = width || if @value == 0
                             1

lib/ronin/asm/program.rb

@@ -300,7 +300,7 @@ def byte(operand)
             width: 1
           )
         else
-          Immediate.new(operand,1)
+          Immediate.new(operand, width: 1)
         end
       end
 
@@ -324,7 +324,7 @@ def word(operand)
             width: 2
           )
         else
-          Immediate.new(operand,2)
+          Immediate.new(operand, width: 2)
         end
       end
 
@@ -348,7 +348,7 @@ def dword(operand)
             width: 4
           )
         else
-          Immediate.new(operand,4)
+          Immediate.new(operand, width: 4)
         end
       end
 
@@ -372,7 +372,7 @@ def qword(operand)
             width: 8
           )
         else
-          Immediate.new(operand,8)
+          Immediate.new(operand, width: 8)
         end
       end
 

spec/immediate_spec.rb

@@ -8,7 +8,7 @@
     context "with a width" do
       let(:width) { 2 }
 
-      subject { described_class.new(value,width) }
+      subject { described_class.new(value, width: width) }
 
       it "must set the width" do
         expect(subject.width).to eq(width)
@@ -20,7 +20,7 @@
     context "when #width is 1" do
       let(:width) { 1 }
 
-      subject { described_class.new(value,width) }
+      subject { described_class.new(value, width: width) }
 
       it "must return :imm8" do
         expect(subject.type).to eq(:imm8)
@@ -30,7 +30,7 @@
     context "when #width is 2" do
       let(:width) { 2 }
 
-      subject { described_class.new(value,width) }
+      subject { described_class.new(value, width: width) }
 
       it "must return :imm16" do
         expect(subject.type).to eq(:imm16)
@@ -40,7 +40,7 @@
     context "when #width is 4" do
       let(:width) { 4 }
 
-      subject { described_class.new(value,width) }
+      subject { described_class.new(value, width: width) }
 
       it "must return :imm32" do
         expect(subject.type).to eq(:imm32)
@@ -50,7 +50,7 @@
     context "when #width is 8" do
       let(:width) { 8 }
 
-      subject { described_class.new(value,width) }
+      subject { described_class.new(value, width: width) }
 
       it "must return :imm64" do
         expect(subject.type).to eq(:imm64)

spec/instruction_spec.rb

@@ -7,7 +7,7 @@
 
 describe Ronin::ASM::Instruction do
   let(:register)  { Ronin::ASM::Register.new(:eax, width: 4) }
-  let(:immediate) { Ronin::ASM::Immediate.new(0xff, 1) }
+  let(:immediate) { Ronin::ASM::Immediate.new(0xff, width: 1) }
 
   describe "#initialize" do
     let(:name)     { :mov }

spec/syntax/att_spec.rb

@@ -19,7 +19,7 @@
   end
 
   describe ".emit_immediate" do
-    let(:operand) { Ronin::ASM::Immediate.new(255, 1) }
+    let(:operand) { Ronin::ASM::Immediate.new(255, width: 1) }
 
     it "must prepend a '$' to the immediate" do
       expect(subject.emit_immediate(operand)).to eq("$0xff")
@@ -87,7 +87,7 @@
 
     context "with one operand" do
       context "with width of 1" do
-        let(:immediate)   { Ronin::ASM::Immediate.new(0x80, 1) }
+        let(:immediate)   { Ronin::ASM::Immediate.new(0x80, width: 1) }
         let(:instruction) { Ronin::ASM::Instruction.new(:int, immediate) }
 
         it "must not append a size specifier to the instruction name" do
@@ -98,7 +98,7 @@
 
     context "with multiple operands" do
       let(:register)    { Ronin::ASM::Register.new(:eax, width: 4) }
-      let(:immediate)   { Ronin::ASM::Immediate.new(0xff, 1)  }
+      let(:immediate)   { Ronin::ASM::Immediate.new(0xff, width: 1)  }
       let(:instruction) { Ronin::ASM::Instruction.new(:mov, register, immediate) }
 
       it "must add a size specifier to the instruction name" do

spec/syntax/intel_spec.rb

@@ -19,7 +19,7 @@
   end
 
   describe ".emit_immediate" do
-    let(:operand) { Ronin::ASM::Immediate.new(255, 1) }
+    let(:operand) { Ronin::ASM::Immediate.new(255, width: 1) }
 
     it "must prepend a size specifier" do
       expect(subject.emit_immediate(operand)).to eq("BYTE 0xff")
@@ -96,7 +96,7 @@
 
     context "with multiple operands" do
       let(:register)    { Ronin::ASM::Register.new(:eax, width: 4) }
-      let(:immediate)   { Ronin::ASM::Immediate.new(0xff, 1)  }
+      let(:immediate)   { Ronin::ASM::Immediate.new(0xff, width: 1)  }
       let(:instruction) { Ronin::ASM::Instruction.new(:mov, register, immediate) }
 
       it "must emit the operands" do