address bug #1834

egnor · egnor · commit ad5288c94e43 · 2025-01-15T12:25:11.000-08:00
diff --git a/packages/html/src/index.ts b/packages/html/src/index.ts
@@ -34,10 +34,12 @@ const defaultTemplate = async ({
   title,
   addScriptsToHead
 }: RollupHtmlTemplateOptions) => {
+  // Only directly <script>-load entry chunks; others are loaded indirectly
   let scripts = (files.js || [])
-    .map(({ fileName }) => {
+    .filter((file) => file.type === 'chunk' && file.isEntry)
+    .map((file) => {
       const attrs = makeHtmlAttributes(attributes.script);
-      return `<script src="${publicPath}${fileName}"${attrs}></script>`;
+      return `<script src="${publicPath}${file.fileName}"${attrs}></script>`;
     })
     .join('\n');
 
diff --git a/packages/html/test/fixtures/catwoman.js b/packages/html/test/fixtures/catwoman.js
@@ -0,0 +1,3 @@
+if (Math.random() % 2) {
+  import('./batman.js');
+}
diff --git a/packages/html/test/snapshots/test.js.md b/packages/html/test/snapshots/test.js.md
@@ -327,6 +327,46 @@ Generated by [AVA](https://avajs.dev).
       },
     ]
 
+## dynamic_imports_not_loaded
+
+> Snapshot 1
+
+    [
+      {
+        code: `if (Math.random() % 2) {␊
+          import('./batman-w40geAFS.js');␊
+        }␊
+        `,
+        fileName: 'catwoman.js',
+        map: null,
+        source: undefined,
+      },
+      {
+        code: `␊
+        `,
+        fileName: 'batman-w40geAFS.js',
+        map: null,
+        source: undefined,
+      },
+      {
+        code: undefined,
+        fileName: 'index.html',
+        map: undefined,
+        source: `␊
+        <!doctype html>␊
+        <html lang="en">␊
+          <head>␊
+            <meta charset="utf-8">␊
+            <title>Rollup Bundle</title>␊
+            ␊
+          </head>␊
+          <body>␊
+            <script src="catwoman.js" type="module"></script>␊
+          </body>␊
+        </html>`,
+      },
+    ]
+
 ## template
 
 > Snapshot 1
diff --git a/packages/html/test/snapshots/test.js.snap b/packages/html/test/snapshots/test.js.snap
diff --git a/packages/html/test/test.js b/packages/html/test/test.js
@@ -108,6 +108,15 @@ test.serial('imports', async (t) => {
   t.snapshot(code);
 });
 
+test.serial('dynamic_imports_not_loaded', async (t) => {
+  const bundle = await rollup({
+    input: 'catwoman.js',
+    plugins: [html()]
+  });
+  const code = await getCode(bundle, { dir: 'output', format: 'esm' }, true);
+  t.snapshot(code);
+});
+
 test.serial('template', async (t) => {
   const bundle = await rollup({
     input: 'batman.js',

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+if (Math.random() % 2) {`
	`2`	`+ import('./batman.js');`
	`3`	`+}`