Correct error handling for when Recurly returns no records

Author: Huy Nguyen

lib/client.js

@@ -43,7 +43,7 @@
               // 200–299 success
               if (res.statusCode >= 200 && res.statusCode <= 299) {
                 if (responsedata === '') {
-                  return _cb(res);
+                  return _cb(res, new Error('Response has no data'));
                 }
                 return parser.parseString(responsedata, function (err, result) {
                   return _cb(res, null, result);
@@ -83,7 +83,7 @@
           }
           if (callback.length === 2) {
             if (err) {
-              return callback(_wrap_response(res, err));
+              return callback(err, _wrap_response(res, null));
             }
             return callback(null, _wrap_response(res, data));
 

lib/utils.js

@@ -76,10 +76,14 @@ exports.makeEachSeriesIterator = function(client, route, endpointName, singleIte
           return callback(error);
         }
 
+        var records = result.data[endpointName][singleItemName];
+        if (!records) {
+          return callback(new Error('Response has no data'));
+        }
+
         var links,
             nextQueryString,
             nextCursor,
-            records,
             isLimitHit;
 
         // Parse out the next cursor
@@ -91,7 +95,6 @@ exports.makeEachSeriesIterator = function(client, route, endpointName, singleIte
           }
         }
 
-        records = result.data[endpointName][singleItemName];
         isLimitHit = limit && (count + records.length) > limit;
         if (isLimitHit) {
           // We will be over the limit, so slice down