-
Notifications
You must be signed in to change notification settings - Fork 557
feat/basketball #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SkalskiP
wants to merge
22
commits into
main
Choose a base branch
from
feat/basketball
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat/basketball #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/basketball_radar
…ith the scale from draw_court and fixed typo that used draw_pitch instead of draw_court
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basketball support across config, rendering, and exports. Provide
BasketballCourtConfigurationwith NBA and FIBA presets, unit conversion,and geometry data for vertices and edges. Expose a clean public API through
__all__so users import the new pieces directly.Add initial drawing and shot state features. Include
draw_courtfor courtrendering and
draw_made_and_miss_on_courtfor make and miss overlays.Introduce
ShotEventTrackerto manage shot start, made, missed, deadline,and cooldown using frame based thresholds. Keep names and arguments clear
and consistent.