Eslint arreglos y chau warnings test

NicoGarcia12 · NicoGarcia12 · commit f4c3c0fbdeca · 2025-09-26T11:18:59.000-03:00
diff --git a/build/demo-release.ts b/build/demo-release.ts
@@ -3,12 +3,12 @@ import * as fs from 'fs';
 import { cmd } from './util';
 
 /* eslint-disable @typescript-eslint/no-var-requires */
-var ghpages: any = require('gh-pages');
+var ghpages: typeof import('gh-pages') = require('gh-pages');
 var dir: string = path.resolve(path.join(__dirname, '../', 'demo-dist'));
 
 // CNAME FILE
 cmd('mkdir ', [`-p ${dir}`]);
-fs.writeFile(`${dir}/CNAME`, 'ngx-jsonapi.reyesoft.com', function(err: any) {
+fs.writeFile(`${dir}/CNAME`, 'ngx-jsonapi.reyesoft.com', function(err: NodeJS.ErrnoException | null) {
     if (err) {
         return console.log(err);
     }
diff --git a/build/tasks.ts b/build/tasks.ts
@@ -5,7 +5,7 @@ import * as util from './util';
  * Cleans the top level dist folder. All npm-ready packages are created
  * in the dist folder.
  */
-export function removeDistFolder(config: Config): Promise<string> {
+export function removeDistFolder(_config: Config): Promise<string> {
     return util.exec('rimraf', ['./dist']);
 }
 
@@ -133,7 +133,7 @@ export async function createUmdBundles(config: Config): Promise<void> {
  * Removes any leftover TypeScript files from previous compilation steps,
  * leaving any type definition files in place
  */
-export async function cleanTypeScriptFiles(config: Config): Promise<void> {
+export async function cleanTypeScriptFiles(_config: Config): Promise<void> {
     const tsFilesGlob: string = './dist/**/*.ts';
     const dtsFilesFlob: string = './dist/**/*.d.ts';
     const filesToRemove: Array<string> = await util.getListOfFiles(tsFilesGlob, dtsFilesFlob);
@@ -198,7 +198,7 @@ export async function removeRemainingSourceMapFiles(config: Config): Promise<voi
  * Copies the type definition files and NGC metadata files to
  * the root of the distribution
  */
-export async function copyTypeDefinitionFiles(config: Config): Promise<void> {
+export async function copyTypeDefinitionFiles(_config: Config): Promise<void> {
     /*
   const packages = util.getTopLevelPackages(config);
   const files = await util.getListOfFiles(
@@ -246,7 +246,7 @@ export async function minifyUmdBundles(config: Config): Promise<void> {
 export async function copyDocs(config: Config): Promise<void> {
     const packages: Array<string> = util.getTopLevelPackages(config);
 
-    await mapAsync(packages, async pkg => {
+    await mapAsync(packages, async _pkg => {
         // const source = `./src/${pkg}`;
         const source: string = `.`;
         // const target = `./dist/${pkg}`;
@@ -262,7 +262,7 @@ export async function copyDocs(config: Config): Promise<void> {
 export async function copyPackageJsonFiles(config: Config):Promise<void> {
     const packages: Array<string> = util.getAllPackages(config);
 
-    await mapAsync(packages, async pkg => {
+    await mapAsync(packages, async _pkg => {
         // const source = `./src/${pkg}`;
         const source: string = `./src`;
         // const target = `./dist/${pkg}`;
@@ -275,7 +275,7 @@ export async function copyPackageJsonFiles(config: Config):Promise<void> {
 /**
  * Removes the packages folderPromise<void>
  */
-export async function removePackagesFolder(config: Config): Promise<void> {
+export async function removePackagesFolder(_config: Config): Promise<void> {
     await util.removeRecursively('./dist');
 }
 
@@ -287,8 +287,6 @@ export async function publishToRepo(config: Config): Promise<void> {
         const SOURCE_DIR: string = `./dist/${pkg}`;
         const REPO_URL: string = `git@github.com:ngrx/${pkg}-builds.git`;
         const REPO_DIR: string = `./tmp/${pkg}`;
-        const SHA: string = await util.git([`rev-parse HEAD`]);
-        const SHORT_SHA: string = await util.git([`rev-parse --short HEAD`]);
         const COMMITTER_USER_NAME: string = await util.git([
             `--no-pager show -s --format='%cN' HEAD`
         ]);
@@ -326,8 +324,8 @@ export async function publishToRepo(config: Config): Promise<void> {
 
 export function mapAsync<T>(
     list: Array<T>,
-    mapFn: (v: T, i: number) => Promise<any>
-): Promise<any> {
+    mapFn: (v: T, i: number) => Promise<unknown>
+): Promise<unknown> {
     return Promise.all(list.map(mapFn));
 }
 
diff --git a/build/util.ts b/build/util.ts
@@ -5,8 +5,10 @@ import * as fsExtra from 'fs-extra';
 import * as path from 'path';
 import * as rimraf from 'rimraf';
 import { Config, PackageDescription } from './config';
+import * as ora from 'ora';
 
-export type RunnerFn = (config: Config) => Promise<any>;
+
+export type RunnerFn = (config: Config) => Promise<unknown>;
 export type TaskDef = [string, RunnerFn];
 export type BaseFn = (command: string) => string;
 
@@ -104,16 +106,14 @@ export function getPackageFilePath(pkg: string, filename: string): string {
 }
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
-const sorcery: any = require('sorcery');
+const sorcery: typeof import('sorcery') = require('sorcery');
 export async function mapSources(file: string): Promise<void> {
-    const chain: any = await sorcery.load(file);
+    const chain = await sorcery.load(file);
     chain.write();
 }
 
-// eslint-disable-next-line @typescript-eslint/no-var-requires
-const ora: any = require('ora');
-async function runTask(name: string, taskFn: () => Promise<any>): Promise<void> {
-    const spinner: any = ora(name);
+async function runTask(name: string, taskFn: () => Promise<unknown>): Promise<void> {
+    const spinner = ora(name);
 
     try {
         spinner.start();
diff --git a/demo/app/app.component.ts b/demo/app/app.component.ts
@@ -20,10 +20,10 @@ export class AppComponent /* implements OnInit */ {
         jsonapiCore.loadingsDone = (): void => {
             this.loading = '';
         };
-        jsonapiCore.loadingsOffline = (error): void => {
+        jsonapiCore.loadingsOffline = (_error): void => {
             this.loading = 'No connection!!!';
         };
-        jsonapiCore.loadingsError = (error): void => {
+        jsonapiCore.loadingsError = (_error): void => {
             this.loading = 'No connection 2!!!';
         };
     }
diff --git a/demo/app/authors/components/author.component.ts b/demo/app/authors/components/author.component.ts
@@ -21,7 +21,7 @@ export class AuthorComponent {
     public constructor(
         protected authorsService: AuthorsService,
         protected photosService: PhotosService,
-        booksService: BooksService,
+        _booksService: BooksService,
         private route: ActivatedRoute
     ) {
         route.params.subscribe(({ id }) => {
@@ -50,7 +50,7 @@ export class AuthorComponent {
             .save
             /* { include: ['book'] } */
             ()
-            .subscribe((success) => {
+            .subscribe((_success) => {
                 console.log('author saved', author.toObject());
             });
     }
@@ -66,7 +66,7 @@ export class AuthorComponent {
         currentAuthor.attributes.name = newName || currentAuthor.attributes.name;
         console.log('author data for save with book include', currentAuthor.toObject({ include: ['books'] }));
         console.log('author data for save without any include', currentAuthor.toObject());
-        currentAuthor.save(/* { include: ['book'] } */).subscribe((success) => {
+        currentAuthor.save(/* { include: ['book'] } */).subscribe((_success) => {
             console.log('author saved', currentAuthor.toObject());
         });
     }
diff --git a/demo/app/authors/components/authors.component.spec.ts b/demo/app/authors/components/authors.component.spec.ts
@@ -7,17 +7,17 @@ import { BooksService } from '../../books/books.service';
 import { AuthorsComponent } from './authors.component';
 import { DocumentCollection, JsonapiConfig, JSONAPI_STORE_SERVICE, JSONAPI_RIPPER_SERVICE, StoreService, JsonRipper } from 'ngx-jsonapi';
 import { provideNgxJsonapiStandalone } from 'ngx-jsonapi/ngx-jsonapi.provider';
-import { ActivatedRoute } from '@angular/router';
+import { ActivatedRoute, Params } from '@angular/router';
 
 describe('AuthorsComponent', () => {
     let component: AuthorsComponent;
     let fixture: ComponentFixture<AuthorsComponent>;
 
-    const queryParams$: BehaviorSubject<any> = new BehaviorSubject<any>({});
+    const queryParams$: BehaviorSubject<Params> = new BehaviorSubject<Params>({});
 
-    const authorsServiceMock: any = {
+    const authorsServiceMock: AuthorsService = {
         all: () => of(new DocumentCollection())
-    };
+    } as AuthorsService;
 
     beforeEach(waitForAsync(() => {
         TestBed.configureTestingModule({
diff --git a/demo/app/authors/components/authors.component.ts b/demo/app/authors/components/authors.component.ts
@@ -2,7 +2,7 @@ import { BooksService } from './../../books/books.service';
 import { Component } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { RouterModule, ActivatedRoute } from '@angular/router';
-import { DocumentCollection, Photo } from 'ngx-jsonapi';
+import { DocumentCollection } from 'ngx-jsonapi';
 import { AuthorsService, Author } from './../authors.service';
 import { CollectionInfoComponent } from '../../shared/collection-info.component';
 import { CollectionPaginatorComponent } from '../../shared/collection-paginator.component';
@@ -20,7 +20,7 @@ export class AuthorsComponent {
     public constructor(
         private route: ActivatedRoute,
         private authorsService: AuthorsService,
-        booksService: BooksService
+        _booksService: BooksService
     ) {
         route.queryParams.subscribe(({ page }) => {
             authorsService
diff --git a/demo/app/books/books.service.ts b/demo/app/books/books.service.ts
@@ -32,13 +32,13 @@ export class BooksService extends Service<Book> {
     public ttl: number = 1;
 
     // executed before get data from server
-    public parseFromServer(attributes: any): void {
+    public parseFromServer(attributes: { title: string; [key: string]: unknown }): void {
         attributes.title = '📖 ' + attributes.title;
     }
 
     // executed before send to server
-    public parseToServer(attributes: any): void {
-        if ('title' in attributes) {
+    public parseToServer(attributes: { title?: string; [key: string]: unknown }): void {
+        if ('title' in attributes && typeof attributes.title === 'string') {
             attributes.title = attributes.title.replace('📖 ', '');
         }
     }
diff --git a/demo/app/books/components/books.component.ts b/demo/app/books/components/books.component.ts
@@ -42,7 +42,7 @@ export class BooksComponent {
         });
     }
 
-    public getAll(remotefilter: any): void {
+    public getAll(remotefilter: Record<string, unknown>): void {
         // we add some remote filter
         remotefilter.date_published = {
             since: '1983-01-01',
@@ -63,7 +63,7 @@ export class BooksComponent {
             },
             (error) => console.log('error books controller', error)
         );
-        books$.toPromise().then((success) => console.log('books loaded PROMISE'));
+        books$.toPromise().then((_success) => console.log('books loaded PROMISE'));
     }
 
     public delete(book: Resource): void {
diff --git a/demo/app/photos/photos.component.ts b/demo/app/photos/photos.component.ts
@@ -1,6 +1,6 @@
-import { Component, OnInit, ViewEncapsulation } from '@angular/core';
+import { Component } from '@angular/core';
 
-import { Service, DocumentCollection } from 'ngx-jsonapi';
+import { DocumentCollection } from 'ngx-jsonapi';
 import { Photo, PhotosService } from './photos.service';
 
 @Component({
@@ -22,9 +22,9 @@ export class PhotosComponent {
         this.makeRequest(5);
     }
 
-    public makeRequest(id: any): void {
+    public makeRequest(id: number): void {
         this.photosService.all().subscribe((photos) => {
-            this.photos = photos as any;
+            this.photos = photos as DocumentCollection<Photo>;
             console.log('photos success', id, this.photos);
         });
     }
diff --git a/demo/app/photos/photos.service.ts b/demo/app/photos/photos.service.ts
@@ -1,5 +1,5 @@
 import { Injectable } from '@angular/core';
-import { Service, Resource, Autoregister } from 'ngx-jsonapi';
+import { Service, Resource } from 'ngx-jsonapi';
 
 @Injectable()
 export class PhotosService extends Service {
diff --git a/demo/app/systems/systems.component.ts b/demo/app/systems/systems.component.ts
@@ -20,7 +20,7 @@ export class SystemsComponent {
         private route: ActivatedRoute,
         private authorsService: SystemsService
     ) {
-        route.queryParams.subscribe(({ page }) => {
+        route.queryParams.subscribe(({ _page }) => {
             authorsService.all().subscribe(
                 (systems) => {
                     this.systems = systems;
diff --git a/demo/app/systems/systems.service.ts b/demo/app/systems/systems.service.ts
@@ -3,8 +3,13 @@ import { Service, Resource, DocumentCollection } from 'ngx-jsonapi';
 import { Book } from '../books/books.service';
 import { Photo } from '../photos/photos.service';
 
+export interface SystemAttributes {
+    name?: string;
+    description?: string;
+}
+
 export class System extends Resource {
-    public attributes: any;
+    public attributes: SystemAttributes;
 
     public relationships: {
         books: DocumentCollection<Book>;
diff --git a/demo/environments/environment.prod.ts b/demo/environments/environment.prod.ts
@@ -1,4 +1,9 @@
-export const environment: { [key: string]: any } = {
+export interface Environment {
+    production: boolean;
+    jsonapi_url: string;
+}
+
+export const environment: Environment = {
     production: true,
     jsonapi_url: '//jsonapiplayground.reyesoft.com/v2/'
 };
diff --git a/demo/environments/environment.ts b/demo/environments/environment.ts
@@ -3,7 +3,13 @@
 // `ng build --env=prod` then `environment.prod.ts` will be used instead.
 // The list of which env maps to which file can be found in `angular-cli.json`.
 
-export const environment: { [key: string]: any } = {
+interface Environment {
+    production: boolean;
+    jsonapi_url: string;
+    api_saldo: string;
+}
+
+export const environment: Environment = {
     production: false,
     jsonapi_url: '//jsonapiplayground.reyesoft.com/v2/',
     api_saldo: 'https://api.saldo.com.ar/v3/'
diff --git a/demo/main.ts b/demo/main.ts
@@ -1,7 +1,7 @@
 import './polyfills';
 
 import { bootstrapApplication } from '@angular/platform-browser';
-import { enableProdMode, importProvidersFrom } from '@angular/core';
+import { enableProdMode } from '@angular/core';
 import { provideRouter } from '@angular/router';
 import { provideHttpClient } from '@angular/common/http';
 import { environment } from './environments/environment';
diff --git a/eslint.config.js b/eslint.config.js
@@ -30,8 +30,11 @@ module.exports = [
     },
     rules: {
       // Basic TypeScript rules
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        { varsIgnorePattern: '_', argsIgnorePattern: '_' }
+      ],
       '@typescript-eslint/no-empty-function': 'error',
       '@typescript-eslint/no-var-requires': 'error',
 
diff --git a/jest.base.config.js b/jest.base.config.js
@@ -1,22 +1,20 @@
 module.exports = {
     preset: 'jest-preset-angular',
     setupFilesAfterEnv: ['<rootDir>/setup-jest.ts'],
-    transform: { 
-        '^.+\\.(ts|mjs|js|html)$': [
-            'jest-preset-angular',
-            {
-                tsconfig: '<rootDir>/tsconfig.spec.json',
-                stringifyContentPathRegex: '\\.(html|svg)$'
-            }
-        ]
-    },
+    transform: { '^.+.(ts|mjs|js|html)$': 'jest-preset-angular' },
     moduleFileExtensions: ['ts', 'js', 'mjs', 'html', 'json'],
     transformIgnorePatterns: ['node_modules/(?!(lodash-es|@angular|zone.js|ngx-jsonapi|@ngrx|@ngxs)/)'],
     modulePathIgnorePatterns: ['dist'],
     moduleNameMapper: {
         '^lodash-es$': 'lodash',
         '^ngx-jsonapi/(?!db)(.*)': '<rootDir>/projects/ngx-jsonapi-lib/src/$1'
     },
+    globals: {
+        'ts-jest': {
+            tsconfig: '<rootDir>/tsconfig.spec.json',
+            stringifyContentPathRegex: '\\.(html|svg)$'
+        }
+    },
     snapshotSerializers: [
         'jest-preset-angular/build/serializers/no-ng-attributes',
         'jest-preset-angular/build/serializers/ng-snapshot',
diff --git a/jest.demo.config.js b/jest.demo.config.js
diff --git a/jest.lib.config.js b/jest.lib.config.js

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,13 @@ export class BooksService extends Service<Book> {`
`32`	`32`	`public ttl: number = 1;`
`33`	`33`
`34`	`34`	`// executed before get data from server`
`35`		`- public parseFromServer(attributes: any): void {`
	`35`	`+ public parseFromServer(attributes: { title: string; [key: string]: unknown }): void {`
`36`	`36`	`attributes.title = '📖 ' + attributes.title;`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`// executed before send to server`
`40`		`- public parseToServer(attributes: any): void {`
`41`		`- if ('title' in attributes) {`
	`40`	`+ public parseToServer(attributes: { title?: string; [key: string]: unknown }): void {`
	`41`	`+ if ('title' in attributes && typeof attributes.title === 'string') {`
`42`	`42`	`attributes.title = attributes.title.replace('📖 ', '');`
`43`	`43`	`}`
`44`	`44`	`}`