chore: removed react-native-permissions and replaced with built-in camera permission handlers

Author: ignaciosantise

wallets/rn_cli_wallet/ios/Podfile

@@ -9,16 +9,10 @@ end
 
 # Use it to require both react-native's and this package's scripts:
 node_require('react-native/scripts/react_native_pods.rb')
-node_require('react-native-permissions/scripts/setup.rb')
 
 platform :ios, min_ios_version_supported
 prepare_react_native_project!
 
-setup_permissions([
-  'Camera',
-  'Notifications'
-])
-
 
 linkage = ENV['USE_FRAMEWORKS']
 if linkage != nil

wallets/rn_cli_wallet/ios/Podfile.lock

@@ -2619,34 +2619,6 @@ PODS:
     - ReactCommon/turbomodule/core
     - SocketRocket
     - Yoga
-  - RNPermissions (5.4.2):
-    - boost
-    - DoubleConversion
-    - fast_float
-    - fmt
-    - glog
-    - hermes-engine
-    - RCT-Folly
-    - RCT-Folly/Fabric
-    - RCTRequired
-    - RCTTypeSafety
-    - React-Core
-    - React-debug
-    - React-Fabric
-    - React-featureflags
-    - React-graphics
-    - React-ImageManager
-    - React-jsi
-    - React-NativeModulesApple
-    - React-RCTFabric
-    - React-renderercss
-    - React-rendererdebug
-    - React-utils
-    - ReactCodegen
-    - ReactCommon/turbomodule/bridging
-    - ReactCommon/turbomodule/core
-    - SocketRocket
-    - Yoga
   - RNScreens (4.16.0):
     - boost
     - DoubleConversion
@@ -2890,7 +2862,6 @@ DEPENDENCIES:
   - "RNCClipboard (from `../node_modules/@react-native-clipboard/clipboard`)"
   - RNDeviceInfo (from `../node_modules/react-native-device-info`)
   - RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
-  - RNPermissions (from `../node_modules/react-native-permissions`)
   - RNScreens (from `../node_modules/react-native-screens`)
   - "RNSentry (from `../node_modules/@sentry/react-native`)"
   - RNSVG (from `../node_modules/react-native-svg`)
@@ -3076,8 +3047,6 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native-device-info"
   RNGestureHandler:
     :path: "../node_modules/react-native-gesture-handler"
-  RNPermissions:
-    :path: "../node_modules/react-native-permissions"
   RNScreens:
     :path: "../node_modules/react-native-screens"
   RNSentry:
@@ -3176,7 +3145,6 @@ SPEC CHECKSUMS:
   RNCClipboard: 4b58c780f63676367640f23c8e114e9bd0cf86ac
   RNDeviceInfo: bcce8752b5043a623fe3c26789679b473f705d3c
   RNGestureHandler: f1dd7f92a0faa2868a919ab53bb9d66eb4ebfcf5
-  RNPermissions: 304745e60937128f77f79a64e342295549d829da
   RNScreens: 0bbf16c074ae6bb1058a7bf2d1ae017f4306797c
   RNSentry: bbaa7ef3a4b131bc947de327ed9e47a054ce0978
   RNSVG: 8c0bbfa480a24b24468f1c76bd852a4aac3178e6
@@ -3185,6 +3153,6 @@ SPEC CHECKSUMS:
   VisionCamera: 30b358b807324c692064f78385e9a732ce1bebfe
   Yoga: edeb9900b9e5bb5b27b9a6a2d5914e4fe4033c1b
 
-PODFILE CHECKSUM: 198cfec3fad83c0e3af1672f94f8de0ffc5f2180
+PODFILE CHECKSUM: 37b3abb743131d0d701e76db155ef06d7f5954ad
 
 COCOAPODS: 1.14.3

wallets/rn_cli_wallet/ios/RNWeb3Wallet/Debug-Info.plist

@@ -58,8 +58,6 @@
 	</dict>
 	<key>NSCameraUsageDescription</key>
 	<string>Allow access to the camera to scan codes</string>
-	<key>NSLocationWhenInUseUsageDescription</key>
-	<string>Our app does not request this permission or utilize this functionality but it is included in our info.plist since our app utilizes the react-native-permissions library.</string>
 	<key>UIBackgroundModes</key>
 	<array>
 		<string>fetch</string>

wallets/rn_cli_wallet/ios/RNWeb3Wallet/Info.plist

@@ -58,8 +58,6 @@
 	</dict>
 	<key>NSCameraUsageDescription</key>
 	<string>Allow access to the camera to scan codes</string>
-	<key>NSLocationWhenInUseUsageDescription</key>
-	<string>Our app does not request this permission or utilize this functionality but it is included in our info.plist since our app utilizes the react-native-permissions library.</string>
 	<key>RCTNewArchEnabled</key>
 	<true/>
 	<key>UIBackgroundModes</key>

wallets/rn_cli_wallet/ios/RNWeb3Wallet/Internal-Info.plist

@@ -58,8 +58,6 @@
 	</dict>
 	<key>NSCameraUsageDescription</key>
 	<string>Allow access to the camera to scan codes</string>
-	<key>NSLocationWhenInUseUsageDescription</key>
-	<string>Our app does not request this permission or utilize this functionality but it is included in our info.plist since our app utilizes the react-native-permissions library.</string>
 	<key>UIBackgroundModes</key>
 	<array>
 		<string>fetch</string>

wallets/rn_cli_wallet/package.json

@@ -53,7 +53,6 @@
     "react-native-get-random-values": "1.11.0",
     "react-native-mmkv": "3.3.3",
     "react-native-modal": "14.0.0-rc.1",
-    "react-native-permissions": "5.4.2",
     "react-native-quick-base64": "2.2.2",
     "react-native-quick-crypto": "0.7.17",
     "react-native-safe-area-context": "5.6.1",

wallets/rn_cli_wallet/src/screens/Scan/index.tsx

@@ -1,13 +1,13 @@
-import {useEffect, useState} from 'react';
-import {Platform, StyleSheet, TouchableOpacity, View, Text} from 'react-native';
+import {useEffect,} from 'react';
+import { StyleSheet, TouchableOpacity, View, Text} from 'react-native';
 
 import {
   Camera,
   Code,
   useCameraDevice,
   useCodeScanner,
+  useCameraPermission,  // Add this
 } from 'react-native-vision-camera';
-import {request, PERMISSIONS, RESULTS} from 'react-native-permissions';
 import {useIsFocused} from '@react-navigation/native';
 import {SafeAreaView} from 'react-native-safe-area-context';
 
@@ -19,7 +19,7 @@ type Props = RootStackScreenProps<'Scan'>;
 
 export default function Scan({navigation}: Props) {
   const device = useCameraDevice('back', {physicalDevices: ['wide-angle-camera']});
-  const [showCamera, setShowCamera] = useState(false);
+  const {hasPermission, requestPermission} = useCameraPermission();  // Add this
 
   // 2. Only activate Camera when the app is focused and this screen is currently opened
   const isActive = useIsFocused();
@@ -42,16 +42,10 @@ export default function Scan({navigation}: Props) {
   };
 
   useEffect(() => {
-    request(
-      Platform.OS === 'ios'
-        ? PERMISSIONS.IOS.CAMERA
-        : PERMISSIONS.ANDROID.CAMERA,
-    ).then(result => {
-      if (result === RESULTS.GRANTED) {
-        setShowCamera(true);
-      }
-    });
-  }, []);
+    if (!hasPermission) {
+      requestPermission();
+    }
+  }, [hasPermission, requestPermission]);
 
   return (
     <SafeAreaView style={StyleSheet.absoluteFill}>
@@ -64,7 +58,7 @@ export default function Scan({navigation}: Props) {
         />
       </TouchableOpacity>
 
-      {showCamera && device ? (
+      {hasPermission && device ? (
         <Camera
           style={StyleSheet.absoluteFill}
           device={device}
@@ -78,4 +72,4 @@ export default function Scan({navigation}: Props) {
       )}
     </SafeAreaView>
   );
-}
+}

wallets/rn_cli_wallet/yarn.lock

@@ -4264,7 +4264,6 @@ __metadata:
     react-native-get-random-values: 1.11.0
     react-native-mmkv: 3.3.3
     react-native-modal: 14.0.0-rc.1
-    react-native-permissions: 5.4.2
     react-native-quick-base64: 2.2.2
     react-native-quick-crypto: 0.7.17
     react-native-safe-area-context: 5.6.1
@@ -10386,20 +10385,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"react-native-permissions@npm:5.4.2":
-  version: 5.4.2
-  resolution: "react-native-permissions@npm:5.4.2"
-  peerDependencies:
-    react: ">=18.1.0"
-    react-native: ">=0.70.0"
-    react-native-windows: ">=0.70.0"
-  peerDependenciesMeta:
-    react-native-windows:
-      optional: true
-  checksum: fac680b7d85fb979806156d6c9f90dee9c8299b83eb9d2d82bee50aec4baa71b0f5d3cf79e8bf02345e67f77d6cb0fbfbe7e54d02b6822de0ae2e0d9323a6614
-  languageName: node
-  linkType: hard
-
 "react-native-quick-base64@npm:2.2.2, react-native-quick-base64@npm:^2.2.2":
   version: 2.2.2
   resolution: "react-native-quick-base64@npm:2.2.2"