Should loop setting use `localStorage` instead?

[polyipseity]

ampcast/src/services/mediaPlayback/mediaPlaybackSettings.ts

Lines 7 to 13 in 4904b2c

	get loop(): boolean {
	return session.getBoolean('loop');
	},
	set loop(loop: boolean) {
	session.setBoolean('loop', loop);
	},

Refer to the code above. Currently the loop button uses sessionStorage. This means when I close and reopen the tab, the loop setting is reset to false. If I install the app as a web app (on iOS), when I reopen the web app, it is also reset to false.

I feel like the loop setting should use localStorage, so that it persists when I reopen the tab/web app. It would also be more inline with other media players, e.g. VLC, Apple Music, where the loop settings are kept when you reopen them.

[rekkyrosso]

I honestly thought that was better as it might be confusing if you came back in a month and wondered why the track kept repeating.

I'll have a think about it. Maybe I need to add expiration to my storage object.

[polyipseity]

This could be a new setting to change the behavior/set the expiration time.