Skip to content

Commit b662ca2

Browse files
authored
Made custom_renderers optional
1 parent c348bd7 commit b662ca2

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

reflex/components/datadisplay/dataeditor.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from reflex.utils.imports import ImportDict, ImportVar
1515
from reflex.utils.serializers import serializer
1616
from reflex.vars import get_unique_variable_name
17-
from reflex.vars.base import Var
17+
from reflex.vars.base import Var, VarData
1818
from reflex.vars.function import FunctionStringVar
1919
from reflex.vars.sequence import ArrayVar
2020

@@ -184,7 +184,6 @@ class DataEditor(NoSSRComponent):
184184
lib_dependencies: list[str] = [
185185
"lodash@4.17.21",
186186
"react-responsive-carousel@3.2.23",
187-
"@glideapps/glide-data-grid-cells@6.0.3",
188187
]
189188

190189
# Number of rows.
@@ -368,7 +367,7 @@ class DataEditor(NoSSRComponent):
368367
on_search_close: EventHandler[no_args_event_spec]
369368

370369
# Custom cell renderers
371-
custom_renderers: Var[Any] = Var(_js_expr="allCells")
370+
custom_renderers: Var[Any]
372371

373372
def add_imports(self) -> ImportDict:
374373
"""Add imports for the component.
@@ -398,9 +397,6 @@ def add_custom_code(self) -> list[str]:
398397
"""
399398
return [
400399
"""
401-
import * as AllCells from "@glideapps/glide-data-grid-cells";
402-
const allCells = Object.values(AllCells).filter(x => x?.isMatch);
403-
404400
function reconstructGridSelection(selection) {
405401
if (!selection || typeof selection !== 'object') {
406402
return undefined;
@@ -528,6 +524,18 @@ def create(cls, *children, **props) -> Component:
528524
"reconstructGridSelection"
529525
).call(grid_selection)
530526

527+
if props.get("extended_cell_types") is not None:
528+
props["custom_renderers"] = Var(
529+
"allCells",
530+
_var_data=VarData(
531+
imports={
532+
"@glideapps/glide-data-grid-cells@6.0.3": ImportVar(
533+
tag="allCells", is_default=False
534+
)
535+
}
536+
),
537+
)
538+
531539
grid = super().create(*children, **props)
532540
return Div.create(
533541
grid,

0 commit comments

Comments
 (0)