Skip to content

Commit 1cdcfb8

Browse files
committed
small followups
1 parent 26d2839 commit 1cdcfb8

1 file changed

Lines changed: 34 additions & 43 deletions

File tree

docs/app/reflex_docs/pages/docs/component.py

Lines changed: 34 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -182,47 +182,39 @@ def render_select(prop: PropDocumentation, component: type[Component], prop_dict
182182
prop_dict[prop.name] = var
183183

184184
if prop.name == "color_scheme":
185-
return rx.popover.root(
186-
rx.popover.trigger(
187-
rx.box(
188-
rx.button(
189-
rx.text(var, class_name="font-small"),
190-
# Match the select.trigger svg icon
191-
rx.html(
192-
"""<svg width="9" height="9" viewBox="0 0 9 9" fill="currentcolor" xmlns="http://www.w3.org/2000/svg" class="rt-SelectIcon" aria-hidden="true"><path d="M0.135232 3.15803C0.324102 2.95657 0.640521 2.94637 0.841971 3.13523L4.5 6.56464L8.158 3.13523C8.3595 2.94637 8.6759 2.95657 8.8648 3.15803C9.0536 3.35949 9.0434 3.67591 8.842 3.86477L4.84197 7.6148C4.64964 7.7951 4.35036 7.7951 4.15803 7.6148L0.158031 3.86477C-0.0434285 3.67591 -0.0536285 3.35949 0.135232 3.15803Z"></path></svg>"""
193-
),
194-
color_scheme=var,
195-
variant="surface",
196-
class_name="w-32 justify-between",
197-
),
198-
),
185+
return ui.popover(
186+
trigger=rx.button(
187+
rx.text(var, class_name="text-sm font-medium"),
188+
ui.icon("ArrowDown01Icon"),
189+
color_scheme=var,
190+
variant="surface",
191+
class_name="w-32 justify-between cursor-pointer",
199192
),
200-
rx.popover.content(
201-
rx.box(
202-
*[
203-
rx.box(
204-
rx.icon(
205-
"check",
206-
size=15,
207-
display=rx.cond(var == color, "block", "none"),
208-
class_name="text-gray-12 absolute top-1/2 left-1/2 translate-x-[-50%] translate-y-[-50%]",
209-
),
210-
bg=f"var(--{color}-9)",
211-
on_click=PropDocsState.setvar(f"{name}", color),
212-
border=rx.cond(
213-
var == color,
214-
"2px solid var(--gray-12)",
215-
"2px solid transparent",
216-
),
217-
class_name="relative shrink-0 rounded-md size-8 cursor-pointer box-border",
218-
)
219-
for color in list(map(str, type_.__args__))
220-
if color != ""
221-
],
222-
class_name="grid grid-cols-[repeat(6,2rem)] gap-3",
223-
),
224-
class_name="w-fit",
193+
content=rx.box(
194+
*[
195+
rx.box(
196+
rx.icon(
197+
"check",
198+
size=15,
199+
display=rx.cond(var == color, "block", "none"),
200+
class_name="text-gray-12 absolute top-1/2 left-1/2 translate-x-[-50%] translate-y-[-50%]",
201+
),
202+
bg=f"var(--{color}-9)",
203+
on_click=PropDocsState.setvar(f"{name}", color),
204+
border=rx.cond(
205+
var == color,
206+
"2px solid var(--gray-12)",
207+
"2px solid transparent",
208+
),
209+
class_name="relative shrink-0 rounded-md size-8 cursor-pointer box-border",
210+
)
211+
for color in list(map(str, type_.__args__))
212+
if color != ""
213+
],
214+
class_name="grid grid-cols-[repeat(6,2rem)] gap-3 p-3",
225215
),
216+
align="start",
217+
class_name="w-fit",
226218
)
227219
literal_values = [str(a) for a in type_.__args__ if str(a) != ""]
228220
return _pill_row(literal_values, var, setter)
@@ -462,8 +454,7 @@ def generate_props(
462454
)
463455

464456
table_header_class_name = (
465-
"text-xs text-secondary-11 w-auto justify-start pl-4 font-semibold "
466-
"uppercase tracking-wider"
457+
"text-xs text-secondary-11 w-auto justify-start pl-4 font-semibold capitalize"
467458
)
468459

469460
prop_dict = {}
@@ -768,7 +759,7 @@ def _render_dynamic_prop(indent: str, p, var) -> rx.Component:
768759
)
769760
for prop, control in interactive_controls
770761
],
771-
class_name="flex flex-col gap-3 border border-secondary-4 rounded-md p-4 bg-secondary-2 mb-4 w-full",
762+
class_name="flex flex-col gap-3 border border-secondary-4 rounded-md p-4 bg-secondary-1 mb-4 w-full",
772763
)
773764

774765
return rx.vstack(
@@ -807,7 +798,7 @@ def _render_dynamic_prop(indent: str, p, var) -> rx.Component:
807798
class_name=ui.cn(table_header_class_name, "w-[18rem]"),
808799
),
809800
),
810-
class_name="bg-secondary-3",
801+
class_name="bg-secondary-2",
811802
),
812803
body,
813804
variant="surface",

0 commit comments

Comments
 (0)