[PHPUnit120] Skip non-mock object on AllowMockObjectsWithoutExpectationsAttributeRector (#656)

* [PHPUnit120] Skip non-mock object on AllowMockObjectsWithoutExpectationsAttributeRector

* Fix

Author: samsonasik

rules-tests/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector/Fixture/skip_not_mock_object.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+use Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Source\ClassToStub;
+
+final class SkipNotMockObject extends TestCase
+{
+    private ClassToStub $foo;
+
+    public function setUp(): void
+    {
+        parent::setUp();
+
+        $foo = self::createStub(ClassToStub::class);
+        $foo->method('foo')->willReturn('error');
+
+        $this->foo = $foo;
+    }
+
+    public function test()
+    {
+       $this->foo->foo();
+    }
+}

rules-tests/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector/Source/ClassToStub.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit120\Rector\Class_\AllowMockObjectsWithoutExpectationsAttributeRector\Source;
+
+class ClassToStub
+{
+    public function foo(): string
+    {
+        return 'error';
+    }
+}

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -15,6 +15,8 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ReflectionProvider;
+use PHPStan\Type\NeverType;
+use PHPStan\Type\ObjectType;
 use Rector\Doctrine\NodeAnalyzer\AttributeFinder;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PHPUnit\Enum\PHPUnitAttribute;
@@ -296,6 +298,14 @@ private function isMissingExpectsOnMockObjectMethodCallInSetUp(Class_ $class): b
                 continue;
             }
 
+            $type = $this->getType($methodCall->var);
+            if (
+                // never type check is needed for fixture with mock final class, example use is possibly by dg/bypass-finals
+                ! $type instanceof NeverType &&
+                ! $this->isObjectType($methodCall->var, new ObjectType(PHPUnitClassName::MOCK_OBJECT))) {
+                continue;
+            }
+
             if ($methodCall->var instanceof Variable || $methodCall->var instanceof PropertyFetch) {
                 return true;
             }