matches

TomasVotruba · TomasVotruba · commit 61390c8b1f3c · 2026-01-25T12:24:42.000+01:00
diff --git a/src/ValueObject/Pattern/RegexPattern.php b/src/ValueObject/Pattern/RegexPattern.php
@@ -4,21 +4,26 @@
 
 namespace Rector\Behastan\ValueObject\Pattern;
 
-use Entropy\Utils\Regex;
+use Entropy\Attributes\RelatedTest;
+use Rector\Behastan\Tests\ValueObject\Pattern\RegexPatternTest;
 
+#[RelatedTest(RegexPatternTest::class)]
 final class RegexPattern extends AbstractPattern
 {
     public function isRegexPatternNeccessary(): bool
     {
-        $matches = Regex::match($this->pattern, '~^/(?<body>(?:\\\\/|[^/])*)/$~');
-        if ($matches === []) {
+        // match <delim>body<delim> with same delimiter, no modifiers
+        if (! preg_match('~^(?<d>.)(?<body>(?:\\\\.|(?!\k<d>).)*)\k<d>$~', $this->pattern, $matches)) {
             return true;
         }
 
         $body = $matches['body'];
 
         // ignore ^ at start and $ at end
+        /** @var string $body */
         $body = preg_replace('~^\^~', '', $body);
+
+        /** @var string $body */
         $body = preg_replace('~(?<!\\\\)\$$~', '', $body);
 
         // any unescaped regex meta char => needs regex
diff --git a/tests/ValueObject/Pattern/RegexPatternTest.php b/tests/ValueObject/Pattern/RegexPatternTest.php
@@ -19,5 +19,8 @@ public function test(): void
 
         $regexPattern = new RegexPattern('/^I do this and that$/', 'someFilePath', 123, 'SomeClass', 'someMethod');
         $this->assertFalse($regexPattern->isRegexPatternNeccessary());
+
+        $regexPattern = new RegexPattern('#^I do this and that$#', 'someFilePath', 123, 'SomeClass', 'someMethod');
+        $this->assertFalse($regexPattern->isRegexPatternNeccessary());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,5 +19,8 @@ public function test(): void`
`19`	`19`
`20`	`20`	`$regexPattern = new RegexPattern('/^I do this and that$/', 'someFilePath', 123, 'SomeClass', 'someMethod');`
`21`	`21`	`$this->assertFalse($regexPattern->isRegexPatternNeccessary());`
	`22`	`+`
	`23`	`+ $regexPattern = new RegexPattern('#^I do this and that$#', 'someFilePath', 123, 'SomeClass', 'someMethod');`
	`24`	`+ $this->assertFalse($regexPattern->isRegexPatternNeccessary());`
`22`	`25`	`}`
`23`	`26`	`}`