clean code

Author: aojunhao123

src/Tooltip.tsx

@@ -94,10 +94,6 @@ const Tooltip = React.forwardRef<TooltipRef, TooltipProps>((props, ref) => {
     extraProps.popupVisible = props.visible;
   }
 
-  const handleVisibleChange = (nextVisible: boolean) => {
-    onVisibleChange?.(nextVisible);
-  };
-
   // ========================= Arrow ==========================
   // Process arrow configuration
   const mergedArrow = React.useMemo(() => {
@@ -148,7 +144,7 @@ const Tooltip = React.forwardRef<TooltipRef, TooltipProps>((props, ref) => {
       ref={triggerRef}
       popupAlign={align}
       getPopupContainer={getTooltipContainer}
-      onOpenChange={handleVisibleChange}
+      onOpenChange={onVisibleChange}
       afterOpenChange={afterVisibleChange}
       popupMotion={motion}
       defaultPopupVisible={defaultVisible}

tests/index.test.tsx

@@ -502,36 +502,6 @@ describe('rc-tooltip', () => {
   });
 
   describe('children handling', () => {
-    it('should toggle aria-describedby with visibility', async () => {
-      const { container } = render(
-        <Tooltip trigger={['click']} overlay="tooltip content">
-          <button>Click me</button>
-        </Tooltip>,
-      );
-
-      const btn = container.querySelector('button');
-      expect(btn).not.toHaveAttribute('aria-describedby');
-
-      fireEvent.click(btn);
-      await waitFakeTimers();
-      const describedby = btn.getAttribute('aria-describedby');
-      expect(describedby).toBeTruthy();
-
-      fireEvent.click(btn);
-      await waitFakeTimers();
-      expect(btn).not.toHaveAttribute('aria-describedby');
-    });
-
-    it('should not pass aria-describedby when overlay is empty', () => {
-      const { container } = render(
-        <Tooltip id="test-id" overlay={null}>
-          <button>Click me</button>
-        </Tooltip>,
-      );
-
-      expect(container.querySelector('button')).not.toHaveAttribute('aria-describedby');
-    });
-
     it('should set aria-describedby immediately when defaultVisible is true', () => {
       const { container } = render(
         <Tooltip defaultVisible overlay="tooltip content">
@@ -542,22 +512,7 @@ describe('rc-tooltip', () => {
       expect(container.querySelector('button')).toHaveAttribute('aria-describedby');
     });
 
-    it('should only set aria-describedby for forceRender after visible', async () => {
-      const { container } = render(
-        <Tooltip forceRender trigger={['click']} overlay="tooltip content">
-          <button>Click me</button>
-        </Tooltip>,
-      );
-
-      const btn = container.querySelector('button');
-      expect(btn).not.toHaveAttribute('aria-describedby');
-
-      fireEvent.click(btn);
-      await waitFakeTimers();
-      expect(btn).toHaveAttribute('aria-describedby');
-    });
-
-    it('should remove aria-describedby when controlled hidden without destroy', () => {
+    it('should remove aria-describedby when controlled hidden', () => {
       const overlay = 'tooltip content';
       const { container, rerender } = render(
         <Tooltip overlay={overlay} visible>
@@ -576,25 +531,6 @@ describe('rc-tooltip', () => {
       expect(container.querySelector('button')).not.toHaveAttribute('aria-describedby');
     });
 
-    it('should remove aria-describedby when popup is destroyed on hide', async () => {
-      const { container } = render(
-        <Tooltip destroyOnHidden trigger={['click']} overlay="tooltip content">
-          <button>Click me</button>
-        </Tooltip>,
-      );
-
-      const btn = container.querySelector('button');
-      expect(btn).not.toHaveAttribute('aria-describedby');
-
-      fireEvent.click(btn);
-      await waitFakeTimers();
-      expect(btn).toHaveAttribute('aria-describedby');
-
-      fireEvent.click(btn);
-      await waitFakeTimers();
-      expect(btn).not.toHaveAttribute('aria-describedby');
-    });
-
     it('should preserve original props of children', () => {
       const onMouseEnter = jest.fn();