[RayJob] ClusterSelector shouldn't support SidecarMode (#4074)

* [RayJob] ClusterSelector shouldn't support SidecarMode

Signed-off-by: Future-Outlier <[email protected]>

* Trigger CI

Signed-off-by: Future-Outlier <[email protected]>

---------

Signed-off-by: Future-Outlier <[email protected]>

Author: Future-Outlier

ray-operator/controllers/ray/utils/validation.go

@@ -177,6 +177,9 @@ func ValidateRayJobSpec(rayJob *rayv1.RayJob) error {
 		if len(clusterName) == 0 {
 			return fmt.Errorf("cluster name in ClusterSelector should not be empty")
 		}
+		if rayJob.Spec.SubmissionMode == rayv1.SidecarMode {
+			return fmt.Errorf("ClusterSelector is not supported in SidecarMode")
+		}
 	}
 
 	// InteractiveMode does not support backoffLimit > 1.

ray-operator/controllers/ray/utils/validation_test.go

@@ -901,6 +901,14 @@ func TestValidateRayJobSpec(t *testing.T) {
 			},
 			expectError: true,
 		},
+		{
+			name: "SidecarMode doesn't support ClusterSelector",
+			spec: rayv1.RayJobSpec{
+				SubmissionMode:  rayv1.SidecarMode,
+				ClusterSelector: map[string]string{"ray.io/cluster": "ray-cluster"},
+			},
+			expectError: true,
+		},
 		{
 			name: "failed to get cluster name in ClusterSelector map",
 			spec: rayv1.RayJobSpec{