Skip to content

Commit 74860ff

Browse files
machichimamachichima
authored
test: add LastTransition to fix test (#4132)
1 parent e36183d commit 74860ff

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

‎ray-operator/controllers/ray/rayjob_controller_test.go‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2147,7 +2147,7 @@ var _ = Context("RayJob with different submission modes", func() {
21472147

21482148
// Update the submitter Kubernetes Job to Complete.
21492149
conditions := []batchv1.JobCondition{
2150-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2150+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
21512151
}
21522152
job.Status.Conditions = conditions
21532153
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2304,7 +2304,7 @@ var _ = Context("RayJob with different submission modes", func() {
23042304

23052305
// Update the submitter Kubernetes Job to Complete.
23062306
conditions := []batchv1.JobCondition{
2307-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2307+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
23082308
}
23092309
job.Status.Conditions = conditions
23102310
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2461,7 +2461,7 @@ var _ = Context("RayJob with different submission modes", func() {
24612461

24622462
// Update the submitter Kubernetes Job to Complete.
24632463
conditions := []batchv1.JobCondition{
2464-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2464+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
24652465
}
24662466
job.Status.Conditions = conditions
24672467
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2601,7 +2601,7 @@ var _ = Context("RayJob with different submission modes", func() {
26012601

26022602
// Update the submitter Kubernetes Job to Complete.
26032603
conditions := []batchv1.JobCondition{
2604-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2604+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
26052605
}
26062606
job.Status.Conditions = conditions
26072607
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2727,7 +2727,7 @@ var _ = Context("RayJob with different submission modes", func() {
27272727

27282728
// Update the submitter Kubernetes Job to Complete.
27292729
conditions := []batchv1.JobCondition{
2730-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2730+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
27312731
}
27322732
job.Status.Conditions = conditions
27332733
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2842,7 +2842,7 @@ var _ = Context("RayJob with different submission modes", func() {
28422842

28432843
// Update the submitter Kubernetes Job to Complete.
28442844
conditions := []batchv1.JobCondition{
2845-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2845+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
28462846
}
28472847
job.Status.Conditions = conditions
28482848
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -2971,7 +2971,7 @@ var _ = Context("RayJob with different submission modes", func() {
29712971

29722972
// Update the submitter Kubernetes Job to Complete.
29732973
conditions := []batchv1.JobCondition{
2974-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
2974+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
29752975
}
29762976
job.Status.Conditions = conditions
29772977
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -3133,7 +3133,7 @@ var _ = Context("RayJob with different submission modes", func() {
31333133

31343134
// Update the submitter Kubernetes Job to Complete.
31353135
conditions := []batchv1.JobCondition{
3136-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
3136+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
31373137
}
31383138
job.Status.Conditions = conditions
31393139
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -3325,7 +3325,7 @@ var _ = Context("RayJob with different submission modes", func() {
33253325

33263326
// Update the submitter Kubernetes Job to Complete.
33273327
conditions := []batchv1.JobCondition{
3328-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
3328+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
33293329
}
33303330
job.Status.Conditions = conditions
33313331
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -3484,7 +3484,7 @@ var _ = Context("RayJob with different submission modes", func() {
34843484

34853485
// Update the submitter Kubernetes Job to Complete.
34863486
conditions := []batchv1.JobCondition{
3487-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
3487+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
34883488
}
34893489
job.Status.Conditions = conditions
34903490
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -3644,7 +3644,7 @@ var _ = Context("RayJob with different submission modes", func() {
36443644

36453645
// Update the submitter Kubernetes Job to Complete.
36463646
conditions := []batchv1.JobCondition{
3647-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
3647+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
36483648
}
36493649
job.Status.Conditions = conditions
36503650
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())
@@ -3852,7 +3852,7 @@ var _ = Context("RayJob with different submission modes", func() {
38523852

38533853
// Update the submitter Kubernetes Job to Complete.
38543854
conditions := []batchv1.JobCondition{
3855-
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue},
3855+
{Type: batchv1.JobComplete, Status: corev1.ConditionTrue, LastTransitionTime: metav1.Now()},
38563856
}
38573857
job.Status.Conditions = conditions
38583858
Expect(k8sClient.Status().Update(ctx, job)).Should(Succeed())

0 commit comments

Comments
 (0)