Adding tests

Author: ayende

json_operation.go

@@ -28,6 +28,8 @@ func jsonOperationEntityChanged(newObj map[string]interface{}, documentInfo *doc
 
 func isJSONFloatEqual(oldPropVal float64, newProp interface{}) bool {
 	switch newPropVal := newProp.(type) {
+	case nil:
+		return false
 	case float64:
 		return oldPropVal == newPropVal
 	default:
@@ -39,6 +41,8 @@ func isJSONFloatEqual(oldPropVal float64, newProp interface{}) bool {
 
 func isJSONBoolEqual(oldPropVal bool, newProp interface{}) bool {
 	switch newPropVal := newProp.(type) {
+	case nil:
+		return false
 	case bool:
 		return oldPropVal == newPropVal
 	default:
@@ -50,6 +54,8 @@ func isJSONBoolEqual(oldPropVal bool, newProp interface{}) bool {
 
 func isJSONStringEqual(oldPropVal string, newProp interface{}) bool {
 	switch newPropVal := newProp.(type) {
+	case nil:
+		return false
 	case string:
 		return oldPropVal == newPropVal
 	default:

scripts/run_single_test.ps1

@@ -33,7 +33,7 @@ go clean -testcache
 
 #go test -tags for_tests -v -timeout 30s "-coverpkg=github.com/ravendb/ravendb-go-client" -covermode=atomic "-coverprofile=coverage.txt"  ./tests -run ^TestCachingOfDocumentInclude$
 
-go test -tags for_tests -v -race -timeout 60s ./tests -run ^TestLoad$
+go test -tags for_tests -v -race -timeout 60s ./tests -run ^TestNonNilTimeError$
 
 #go test -tags for_tests -v -race -timeout 60s ./tests -run ^TestAggressiveCaching$
 

tests/non_null_time.go

@@ -0,0 +1,50 @@
+package tests
+
+import (
+	"testing"
+	"time"
+
+	"github.com/ravendb/ravendb-go-client"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestNonNilTimeError(t *testing.T) {
+	driver := createTestDriver(t)
+	test_case_string_non_nil_error(t, driver)
+}
+
+func test_case_string_non_nil_error(t *testing.T, driver *RavenTestDriver) {
+
+	id := "customer1"
+
+	var err error
+	store := driver.getDocumentStoreMust(t)
+	defer store.Close()
+
+	var time time.Time
+	time, err = ravendb.ParseTime("2006-01-02T15:04:05.9999999Z")
+	rtime := ravendb.Time(time)
+
+	obj := &CustomerNilTime{
+		ID:        id,
+		CreatedAt: &rtime,
+	}
+
+	{
+		session := openSessionMust(t, store)
+		err = session.Store(obj)
+		assert.NoError(t, err)
+		session.SaveChanges()
+		session.Close()
+	}
+
+	{
+		session := openSessionMust(t, store)
+		var customer *CustomerNilTime
+		err = session.Load(&customer, id)
+
+		assert.True(t, customer.CreatedAt != nil)
+
+		session.Close()
+	}
+}

tests/nullable_time.go

@@ -0,0 +1,51 @@
+package tests
+
+import (
+	"testing"
+
+	"github.com/ravendb/ravendb-go-client"
+	"github.com/stretchr/testify/assert"
+)
+
+// Note: must rename as it conflicts with Order in order_test.go
+type CustomerNilTime struct {
+	ID        string        `json:"Id"`
+	CreatedAt *ravendb.Time `json:"createdAt"`
+}
+
+func TestNilTimeError(t *testing.T) {
+	driver := createTestDriver(t)
+	test_case_string_nil_error(t, driver)
+}
+
+func test_case_nil_time_error(t *testing.T, driver *RavenTestDriver) {
+
+	id := "customer1"
+
+	var err error
+	store := driver.getDocumentStoreMust(t)
+	defer store.Close()
+
+	obj := &CustomerNilTime{
+		ID:        id,
+		CreatedAt: nil,
+	}
+
+	{
+		session := openSessionMust(t, store)
+		err = session.Store(obj)
+		assert.NoError(t, err)
+		session.SaveChanges()
+		session.Close()
+	}
+
+	{
+		session := openSessionMust(t, store)
+		var customer *CustomerNilTime
+		err = session.Load(&customer, id)
+
+		assert.True(t, customer.CreatedAt == nil)
+
+		session.Close()
+	}
+}

tests/string_nil_save_changes_test.go

@@ -0,0 +1,54 @@
+package tests
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+// Note: must rename as it conflicts with Order in order_test.go
+type CustomerNilReference struct {
+	ID        string  `json:"Id"`
+	Reference *string `json:"reference"`
+	Name      string  `json:"name"`
+}
+
+func TestStringNilError(t *testing.T) {
+	driver := createTestDriver(t)
+	test_case_string_nil_error(t, driver)
+}
+
+func test_case_string_nil_error(t *testing.T, driver *RavenTestDriver) {
+
+	id := "customer1"
+	reference := "reference"
+
+	var err error
+	store := driver.getDocumentStoreMust(t)
+	defer store.Close()
+
+	obj := &CustomerNilReference{
+		ID:   id,
+		Name: "customer_name",
+	}
+
+	{
+		session := openSessionMust(t, store)
+		err = session.Store(obj)
+		assert.NoError(t, err)
+		session.SaveChanges()
+		session.Close()
+	}
+
+	{
+		session := openSessionMust(t, store)
+		var customer *CustomerNilReference
+		err = session.Load(&customer, id)
+
+		customer.Reference = &reference
+
+		session.SaveChanges()
+
+		session.Close()
+	}
+}