Skip to content

Commit dea79bd

Browse files
committed
no embedding headers
2 parents 9b24f05 + c95625b commit dea79bd

90 files changed

Lines changed: 5487 additions & 904 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.coderabbit.yaml

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
# SPDX-License-Identifier: Apache-2.0
3+
4+
reviews:
5+
profile: chill
6+
high_level_summary: true
7+
high_level_summary_in_walkthrough: true
8+
poem: false
9+
auto_review:
10+
enabled: true
11+
drafts: false
12+
base_branches:
13+
- "^main$"
14+
- "^release/.*"
15+
- "^hotfix/.*"
16+
ignore_usernames: ["rapids-bot", "GPUtester", "nv-automation-bot", "copy-pr-bot"]
17+
tools:
18+
markdownlint:
19+
enabled: true
20+
shellcheck:
21+
enabled: true
22+
gitleaks:
23+
enabled: true
24+
sequence_diagrams: false
25+
collapse_walkthrough: true
26+
27+
# Reduce noise from status messages
28+
request_changes_workflow: false
29+
review_status: false
30+
31+
# Path-specific review instructions
32+
# Note: Detailed C++/CUDA and Python review guidelines are in cpp/REVIEW_GUIDELINES.md and python/REVIEW_GUIDELINES.md
33+
path_instructions:
34+
- path: "docs/**/*"
35+
instructions: |
36+
For documentation changes, focus on:
37+
- Accuracy: Verify code examples compile and run correctly
38+
- Completeness: Check if API changes (parameters, return values, errors) are documented
39+
- Clarity: Flag confusing explanations, missing prerequisites, or unclear examples
40+
- Consistency: Version numbers, parameter types, and terminology match code
41+
- Missing docs: If PR changes public APIs without updating docs, flag as HIGH priority
42+
43+
- path: "c/include/cuvs/**/*"
44+
instructions: |
45+
For public C API headers, additionally check:
46+
- Doxygen documentation for all public functions/classes
47+
- API changes flagged for docs/ updates
48+
- Breaking changes require deprecation warnings and migration guide updates
49+
50+
- path: "cpp/include/cuvs/**/*"
51+
instructions: |
52+
For public C++ API headers, additionally check:
53+
- Doxygen documentation for all public functions/classes
54+
- API changes flagged for docs/ updates
55+
- Breaking changes require deprecation warnings and migration guide updates
56+
57+
- path: "notebooks/**/*"
58+
instructions: |
59+
For example notebooks:
60+
- Verify code examples match current API (parameter names, return types)
61+
- Flag outdated imports or deprecated API usage
62+
63+
- path: "ci/**/*"
64+
instructions: |
65+
For CI/build scripts:
66+
- Check for proper conda environment handling
67+
- Verify GPU availability checks before tests
68+
- Check for proper error handling and meaningful error messages
69+
70+
knowledge_base:
71+
opt_out: false
72+
code_guidelines:
73+
filePatterns:
74+
- "cpp/REVIEW_GUIDELINES.md"
75+
- "python/REVIEW_GUIDELINES.md"
76+
- "docs/source/contributing.md"
77+
- "docs/source/developer_guide.md"

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ cpp/scripts/run-cmake-format.sh @rapidsai/cuvs-cmake-codeowners
3131
/.github/ @rapidsai/ci-codeowners
3232
/ci/ @rapidsai/ci-codeowners
3333
/.shellcheckrc @rapidsai/ci-codeowners
34+
/.coderabbit.yaml @rapidsai/ci-codeowners
3435

3536
#packaging code owners
3637
/.pre-commit-config.yaml @rapidsai/packaging-codeowners

.github/workflows/pr.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,8 @@ jobs:
6868
files_yaml: |
6969
build_docs:
7070
- '**'
71+
- '!**/*/REVIEW_GUIDELINES.md'
72+
- '!.coderabbit.yaml'
7173
- '!.devcontainer/**'
7274
- '!.github/CODEOWNERS'
7375
- '!.github/ISSUE_TEMPLATE/**'
@@ -90,6 +92,8 @@ jobs:
9092
- '!thirdparty/LICENSES/**'
9193
test_cpp:
9294
- '**'
95+
- '!**/*/REVIEW_GUIDELINES.md'
96+
- '!.coderabbit.yaml'
9397
- '!.devcontainer/**'
9498
- '!.github/CODEOWNERS'
9599
- '!.github/ISSUE_TEMPLATE/**'
@@ -124,6 +128,8 @@ jobs:
124128
- '!thirdparty/LICENSES/**'
125129
test_java:
126130
- '**'
131+
- '!**/*/REVIEW_GUIDELINES.md'
132+
- '!.coderabbit.yaml'
127133
- '!.devcontainer/**'
128134
- '!.github/CODEOWNERS'
129135
- '!.github/ISSUE_TEMPLATE/**'
@@ -157,6 +163,8 @@ jobs:
157163
- '!thirdparty/LICENSES/**'
158164
test_python_conda:
159165
- '**'
166+
- '!**/*/REVIEW_GUIDELINES.md'
167+
- '!.coderabbit.yaml'
160168
- '!.devcontainer/**'
161169
- '!.github/CODEOWNERS'
162170
- '!.github/ISSUE_TEMPLATE/**'
@@ -194,6 +202,8 @@ jobs:
194202
- '!thirdparty/LICENSES/**'
195203
test_python_wheels:
196204
- '**'
205+
- '!**/*/REVIEW_GUIDELINES.md'
206+
- '!.coderabbit.yaml'
197207
- '!.devcontainer/**'
198208
- '!.github/CODEOWNERS'
199209
- '!.github/ISSUE_TEMPLATE/**'
@@ -236,6 +246,8 @@ jobs:
236246
- '!thirdparty/LICENSES/**'
237247
test_rust:
238248
- '**'
249+
- '!**/*/REVIEW_GUIDELINES.md'
250+
- '!.coderabbit.yaml'
239251
- '!.devcontainer/**'
240252
- '!.github/CODEOWNERS'
241253
- '!.github/ISSUE_TEMPLATE/**'
@@ -273,6 +285,8 @@ jobs:
273285
- '!thirdparty/LICENSES/**'
274286
test_go:
275287
- '**'
288+
- '!**/*/REVIEW_GUIDELINES.md'
289+
- '!.coderabbit.yaml'
276290
- '!.devcontainer/**'
277291
- '!.github/CODEOWNERS'
278292
- '!.github/ISSUE_TEMPLATE/**'

.pre-commit-config.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ repos:
4343
additional_dependencies: [toml]
4444
args: ["--config=pyproject.toml"]
4545
- repo: https://github.com/pre-commit/mirrors-clang-format
46-
rev: v20.1.4
46+
rev: v20.1.8
4747
hooks:
4848
- id: clang-format
4949
types_or: [c, c++, cuda]
@@ -96,10 +96,14 @@ repos:
9696
name: clang-format-with-cmake-placeholders
9797
entry: python3 ci/checks/clang_format_with_cmake_placeholders.py
9898
language: python
99-
additional_dependencies: [clang_format==20.1.4]
99+
additional_dependencies: [clang_format==20.1.8]
100100
files: |
101101
(?x)
102102
[.](cpp|cu|hpp|cuh)[.]in$
103+
# clang-format struggles with one of the placeholders in register_fatbin.cpp.in, so exclude it
104+
exclude: |
105+
(?x)
106+
^cpp/cmake/modules/register_fatbin[.]cpp[.]in$
103107
- repo: https://github.com/codespell-project/codespell
104108
rev: v2.4.1
105109
hooks:

ci/validate_wheel.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ PYDISTCHECK_ARGS=(
2121
if [[ "${package_dir}" == "python/libcuvs" ]]; then
2222
if [[ "${RAPIDS_CUDA_MAJOR}" == "12" ]]; then
2323
PYDISTCHECK_ARGS+=(
24-
--max-allowed-size-compressed '800Mi'
24+
--max-allowed-size-compressed '400Mi'
2525
)
2626
else
2727
PYDISTCHECK_ARGS+=(
28-
--max-allowed-size-compressed '450Mi'
28+
--max-allowed-size-compressed '250Mi'
2929
)
3030
fi
3131
elif [[ "${package_dir}" != "python/cuvs" ]]; then

conda/environments/all_cuda-129_arch-aarch64.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ dependencies:
88
- _go_select *=cgo
99
- breathe>=4.35.0
1010
- c-compiler
11-
- clang-tools==20.1.4
12-
- clang==20.1.4
11+
- clang-tools==20.1.8
12+
- clang==20.1.8
1313
- cmake>=3.30.4
1414
- cuda-nvcc
1515
- cuda-nvrtc-dev
@@ -26,7 +26,7 @@ dependencies:
2626
- go
2727
- graphviz
2828
- ipython
29-
- libclang==20.1.4
29+
- libclang==20.1.8
3030
- libcublas-dev
3131
- libcurand-dev
3232
- libcusolver-dev

conda/environments/all_cuda-129_arch-x86_64.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ dependencies:
88
- _go_select *=cgo
99
- breathe>=4.35.0
1010
- c-compiler
11-
- clang-tools==20.1.4
12-
- clang==20.1.4
11+
- clang-tools==20.1.8
12+
- clang==20.1.8
1313
- cmake>=3.30.4
1414
- cuda-nvcc
1515
- cuda-nvrtc-dev
@@ -26,7 +26,7 @@ dependencies:
2626
- go
2727
- graphviz
2828
- ipython
29-
- libclang==20.1.4
29+
- libclang==20.1.8
3030
- libcublas-dev
3131
- libcurand-dev
3232
- libcusolver-dev

conda/environments/all_cuda-131_arch-aarch64.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ dependencies:
88
- _go_select *=cgo
99
- breathe>=4.35.0
1010
- c-compiler
11-
- clang-tools==20.1.4
12-
- clang==20.1.4
11+
- clang-tools==20.1.8
12+
- clang==20.1.8
1313
- cmake>=3.30.4
1414
- cuda-nvcc
1515
- cuda-nvrtc-dev
@@ -26,7 +26,7 @@ dependencies:
2626
- go
2727
- graphviz
2828
- ipython
29-
- libclang==20.1.4
29+
- libclang==20.1.8
3030
- libcublas-dev
3131
- libcurand-dev
3232
- libcusolver-dev

conda/environments/all_cuda-131_arch-x86_64.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ dependencies:
88
- _go_select *=cgo
99
- breathe>=4.35.0
1010
- c-compiler
11-
- clang-tools==20.1.4
12-
- clang==20.1.4
11+
- clang-tools==20.1.8
12+
- clang==20.1.8
1313
- cmake>=3.30.4
1414
- cuda-nvcc
1515
- cuda-nvrtc-dev
@@ -26,7 +26,7 @@ dependencies:
2626
- go
2727
- graphviz
2828
- ipython
29-
- libclang==20.1.4
29+
- libclang==20.1.8
3030
- libcublas-dev
3131
- libcurand-dev
3232
- libcusolver-dev

conda/environments/bench_ann_cuda-129_arch-aarch64.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ channels:
66
- conda-forge
77
dependencies:
88
- c-compiler
9-
- clang-tools==20.1.4
10-
- clang==20.1.4
9+
- clang-tools==20.1.8
10+
- clang==20.1.8
1111
- click
1212
- cmake>=3.30.4
1313
- cuda-nvcc
@@ -24,7 +24,7 @@ dependencies:
2424
- gcc_linux-aarch64=14.*
2525
- glog>=0.6.0
2626
- h5py>=3.8.0
27-
- libclang==20.1.4
27+
- libclang==20.1.8
2828
- libcublas-dev
2929
- libcurand-dev
3030
- libcusolver-dev

0 commit comments

Comments
 (0)