Locking updates (#1655)

* Allow turning off teacher review for locked exercises

* Enhance user exercise state management for chapter-locking courses

* Refactor ExerciseBlock component to streamline chapter locking logic and update localization strings for improved clarity

* Add update function for teacher review setting and implement related tests

- Introduced `update_teacher_reviews_answer_after_locking` function to update the `teacher_reviews_answer_after_locking` field in the exercises table.
- Enhanced `move_chapter_exercises_to_manual_review` function to update the reviewing stage when exercises are fully graded.
- Added unit tests to verify the correct behavior of the new functionality, ensuring exercises transition to the reviewed and locked state as expected.

* Update system tests for chapter locking feature to reflect changes in student context and exercise visibility

* Fixes

Author: nygrenh

services/cms/src/blocks/Exercise/ExerciseSettings/ExerciseSettingsEditor.tsx

@@ -1,19 +1,22 @@
 "use client"
 
 import { css } from "@emotion/css"
+import { useQuery } from "@tanstack/react-query"
 import { InnerBlocks } from "@wordpress/block-editor"
 import { useContext } from "react"
 import { useTranslation } from "react-i18next"
 
 import PeerReviewEditor from "../../../components/PeerReviewEditor"
 import ExerciseBlockContext from "../../../contexts/ExerciseBlockContext"
 import PageContext from "../../../contexts/PageContext"
+import { fetchCourseById } from "../../../services/backend/courses"
 
 import Accordion from "@/shared-module/common/components/Accordion"
 import CheckBox from "@/shared-module/common/components/InputFields/CheckBox"
 import TextField from "@/shared-module/common/components/InputFields/TextField"
 import { baseTheme } from "@/shared-module/common/styles"
 import { respondToOrLarger } from "@/shared-module/common/styles/respond"
+import { assertNotNullOrUndefined } from "@/shared-module/common/utils/nullability"
 
 const ALLOWED_NESTED_BLOCKS = ["core/image", "core/paragraph", "core/list", "moocfi/latex"]
 
@@ -22,6 +25,13 @@ const ExerciseSettingsEditor = () => {
   const courseId = useContext(PageContext)?.page.course_id
   const { attributes, setAttributes } = useContext(ExerciseBlockContext)
 
+  const courseQuery = useQuery({
+    queryKey: ["course", courseId],
+    queryFn: () => fetchCourseById(assertNotNullOrUndefined(courseId)),
+    enabled: !!courseId,
+  })
+  const chapterLockingEnabled = courseQuery.data?.chapter_locking_enabled ?? false
+
   if (!attributes) {
     return null
   }
@@ -105,6 +115,18 @@ const ExerciseSettingsEditor = () => {
           `}
         />
       </div>
+      {courseId && chapterLockingEnabled && (
+        <CheckBox
+          label={t("teacher-reviews-answer-after-locking")}
+          checked={attributes.teacher_reviews_answer_after_locking ?? true}
+          onChangeByValue={(checked: boolean) => {
+            setAttributes({ teacher_reviews_answer_after_locking: checked })
+          }}
+          className={css`
+            margin-bottom: 1rem;
+          `}
+        />
+      )}
       {courseId && (
         <Accordion>
           <details>

services/cms/src/blocks/Exercise/index.tsx

@@ -21,6 +21,7 @@ export interface ExerciseAttributes {
   peer_or_self_review_config: string
   peer_or_self_review_questions_config: string
   use_course_default_peer_review: boolean
+  teacher_reviews_answer_after_locking?: boolean
 }
 
 /**
@@ -78,6 +79,10 @@ const ExerciseConfiguration: BlockConfiguration<ExerciseAttributes> = {
       type: "boolean",
       default: false,
     },
+    teacher_reviews_answer_after_locking: {
+      type: "boolean",
+      default: true,
+    },
   },
   edit: enforceExerciseIdDefined(ExerciseEditor),
   save: ExerciseSave,

services/cms/src/utils/documentSchemaProcessor.tsx

@@ -94,6 +94,8 @@ export function normalizeDocument(args: UnnormalizedDocument): CmsPageUpdate {
           : JSON.parse(exerciseAttributes.peer_or_self_review_questions_config),
       use_course_default_peer_or_self_review_config:
         exerciseAttributes.use_course_default_peer_review,
+      teacher_reviews_answer_after_locking:
+        exerciseAttributes.teacher_reviews_answer_after_locking ?? true,
     })
     exerciseCount = exerciseCount + 1
     let exerciseSlideCount = 0
@@ -264,6 +266,7 @@ export function denormalizeDocument(input: CmsPageUpdate): UnnormalizedDocument
             ? JSON.stringify(exercise.peer_or_self_review_questions)
             : "null",
         use_course_default_peer_review: exercise.use_course_default_peer_or_self_review_config,
+        teacher_reviews_answer_after_locking: exercise.teacher_reviews_answer_after_locking,
       },
     }
 

services/cms/tests/utils/documentSchemaProcessor.test.ts

@@ -98,6 +98,7 @@ const exampleCMSPageUpdate: CmsPageUpdate = {
           weight: 0.3,
         },
       ],
+      teacher_reviews_answer_after_locking: true,
       use_course_default_peer_or_self_review_config: false,
     },
   ],
@@ -150,6 +151,7 @@ const exampleUnnormalizedDocumentExerciseAttributes: ExerciseAttributes = {
     '[{"id":"f0ae5814-927d-4a38-a0c0-db66f08c2bee","course_id":"","exercise_id":"dd46fb67-d168-4554-b912-0018f812166d","processing_strategy":"AutomaticallyGradeOrManualReviewByAverage","accepting_threshold":"0.5","peer_reviews_to_give":"1","peer_reviews_to_receive":"1"}]',
   peer_or_self_review_questions_config:
     '[{"id":"f3c8eadd-75ca-409f-b1c6-31db65701930","peer_or_self_review_config_id":"f0ae5814-927d-4a38-a0c0-db66f08c2bee","answer_required":"true","order_number":"0","question":"how about...","question_type":"Essay","weight":0}]',
+  teacher_reviews_answer_after_locking: true,
   use_course_default_peer_review: false,
 }
 

services/headless-lms/migrations/20260217120000_add_teacher_reviews_answer_after_locking.down.sql

@@ -0,0 +1 @@
+ALTER TABLE exercises DROP COLUMN teacher_reviews_answer_after_locking;

services/headless-lms/migrations/20260217120000_add_teacher_reviews_answer_after_locking.up.sql

@@ -0,0 +1,6 @@
+ALTER TABLE exercises
+ADD COLUMN teacher_reviews_answer_after_locking BOOLEAN NOT NULL DEFAULT TRUE;
+
+COMMENT ON COLUMN exercises.teacher_reviews_answer_after_locking IS
+'When true (default), answers go to manual review when chapter is locked.
+When false, exercises with automated grading receive points immediately and lock without teacher review.';