Merge branch 'main' into crc_fail_event_async

Author: Gsantomaggio

RabbitMQ.Stream.Client/Reliable/DeduplicatingProducer.cs

@@ -39,22 +39,7 @@ public static async Task<DeduplicatingProducer> Create(DeduplicatingProducerConf
         var x = new DeduplicatingProducer()
         {
             _producer = await Producer
-                .Create(
-                    new ProducerConfig(producerConfig.StreamSystem, producerConfig.Stream)
-                    {
-                        _reference = producerConfig.Reference,
-                        ConfirmationHandler = producerConfig.ConfirmationHandler,
-                        ReconnectStrategy = producerConfig.ReconnectStrategy,
-                        ClientProvidedName = producerConfig.ClientProvidedName,
-                        SuperStreamConfig = producerConfig.SuperStreamConfig,
-                        MaxInFlight = producerConfig.MaxInFlight,
-                        MessagesBufferSize = producerConfig.MessagesBufferSize,
-                        TimeoutMessageAfter = producerConfig.TimeoutMessageAfter,
-                        Filter = producerConfig.Filter,
-                        Identifier = producerConfig.Identifier,
-                        ResourceAvailableReconnectStrategy = producerConfig.ResourceAvailableReconnectStrategy,
-
-                    }, logger)
+                .Create(producerConfig, logger)
                 .ConfigureAwait(false)
         };
         return x;

Tests/DeduplicationProducerTests.cs

@@ -3,6 +3,7 @@
 // Copyright (c) 2017-2023 Broadcom. All Rights Reserved. The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
 
 using System;
+using System.Collections.Generic;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
@@ -80,16 +81,22 @@ public async Task DeduplicationInActionSendingTheSameIdMessagesWontStore()
         SystemUtils.InitStreamSystemWithRandomStream(out var system, out var stream);
         var testPassed = new TaskCompletionSource<ulong>();
         const ulong TotalMessages = 1000UL;
-        var p = await DeduplicatingProducer.Create(
-            new DeduplicatingProducerConfig(system, stream, "my_producer_reference")
+        var dupConfig = new DeduplicatingProducerConfig(system, stream, "my_producer_reference")
+        {
+            ConfirmationHandler = async confirmation =>
             {
-                ConfirmationHandler = async confirmation =>
-                {
-                    if (confirmation.PublishingId == TotalMessages)
-                        testPassed.SetResult(TotalMessages);
-                    await Task.CompletedTask;
-                },
-            });
+                if (confirmation.PublishingId == TotalMessages)
+                    testPassed.SetResult(TotalMessages);
+                await Task.CompletedTask;
+            },
+        };
+        var statusInfoReceived = new List<StatusInfo>();
+        dupConfig.StatusChanged += (status) => { statusInfoReceived.Add(status); };
+
+        var p = await DeduplicatingProducer.Create(dupConfig);
+
+        Assert.Equal(ReliableEntityStatus.Initialization, statusInfoReceived[0].From);
+        Assert.Equal(ReliableEntityStatus.Open, statusInfoReceived[0].To);
         // first send and the messages are stored
         for (ulong i = 1; i <= TotalMessages; i++)
         {

docs/ReliableClient/README.md

@@ -1,17 +1,24 @@
 Best practices for reliable client
 ----------------------------------
 
-This is an example of hot to use the client in a reliable way. By following these best practices, you can ensure that your application will be able to recover from network failures and other issues.
+This is an example of how to use the client in a reliable way. By following these best practices, you can ensure
+that your application will be able to recover from network failures and other issues.
 
-the producer part is the most important, you need to block the sending of messages until the connection is established. This is done by using the `ManualResetEvent` method.
+The producer part is the most important: you need to block the sending of messages until the connection is established.
+This is done by using the [
+`ManualResetEvent`](https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/f3b131cf6688843f2d91854a9d35ebc91be54090/docs/ReliableClient/BestPracticesClient.cs#L251)
+class.
 
-you'd need also a list to store the messages that were not sent because the connection was not established.
-
-Use the `Identify` method to identify the producer or consumer it the logs.
-
-You should focus in how to deal with the entity `StatusChanged` events.
-
-You can customize the setting using `appsetting.json` file.
+You'll also need a list to store any messages that were not sent because the connection was not yet established.
 
+Use the [
+`Identifier`](https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/f3b131cf6688843f2d91854a9d35ebc91be54090/docs/ReliableClient/BestPracticesClient.cs#L193-L254)
+property to identify the producer or consumer in the logs.
 
+Focus on how to handle the entity-level [
+`StatusChanged`](https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/f3b131cf6688843f2d91854a9d35ebc91be54090/docs/ReliableClient/BestPracticesClient.cs#L279-L309)
+events.
 
+You can customize the settings by using the [
+`appsettings.json`](https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/f3b131cf6688843f2d91854a9d35ebc91be54090/docs/ReliableClient/appsettings.json)
+file.