Renaming window improvements

[reyaz006]

• Bug: when new name includes "new line" character, qbt breaks the file name or torrent name internally and unable to rename it again anymore. Might need to restart qbt or remove torrent to get around this. Maybe filter out these and other most obvious illegal characters automatically? It also fails at characters like ":", "/" and "?", and such failed attempts force user to try again, losing all changes he could possibly type/paste there previously.
• Bug: even though the window width tries to always adapt to the name length, it's sometimes off by several characters. Might be related to cases where name includes non-ANSI unicode characters, e.g. Japanese. Maybe just make it fixed and/or save its width if user expands it.
• Suggestion: by default hide extension from file renaming window input. Because in most cases user never needs to change it. For other cases, add an option to display it.

[rumplin]

hiding extensions is a bad idea and may cause security issues further in time.

[reyaz006]

Can you elaborate? I don't see how it can cause any security related issues. We are talking about rename window only, not the Content tab.

For me, hiding extensions would make it much easier to rename stuff since I do it very often. Extra symbols that I'm not going to change anyway are just a nuisance.

[rumplin]

myimage.jpg.exe -> myimage.jpg

[FranciscoPombal]

Can you elaborate? I don't see how it can cause any security related issues. We are talking about rename window only, not the Content tab.

For me, hiding extensions would make it much easier to rename stuff since I do it very often. Extra symbols that I'm not going to change anyway are just a nuisance.

Even though one usually doesn't want to alter the file extension, it is simply part of the file's name. One thing that seriously annoys me in Windows is that it hides file extensions by default. First thing I do usually is change that setting.

A possible solution for people who frequently rename files is to always open the renaming dialog with the cursor starting immediately before the right-most .. So, for example, somefile|.ext, where | represents the cursor.

[reyaz006]

myimage.jpg.exe -> myimage.jpg

So? What could possibly go wrong if a user downloads a torrent that contains myimage.jpg.exe, then uses qBittorrent to rename the myimage.jpg.exe into something_else.exe? Because that's what would happen in my proposed scenario - qbt would present the user with "myimage.jpg" when he decides to rename the executable file from torrent. How is that a security risk? A user downloaded a torrent with an executable virus and you think a renaming dialog is a good tool for letting him stay safe from it? Because apparently people like double-clicking executable malware with modified extension, or I may be missing something.

Even though one usually doesn't want to alter the file extension, it is simply part of the file's name.

I don't think this is a proper argument. Semantics (also arguable) vs. usability.

One thing that seriously annoys me in Windows is that it hides file extensions by default. First thing I do usually is change that setting.

This is completely unrelated because:

• we are talking about renaming dialog only.
• the option to show extension might be embedded into this very dialog itself for easy access.

A possible solution for people who frequently rename files is to always open the renaming dialog with the cursor starting immediately before the right-most .. So, for example, somefile|.ext, where | represents the cursor.

Sounds good enough for me, but I don't think it's a good alternative from developers point.

[reyaz006]

I'll try to rephrase the purpose of suggestion about the filename extension, for better understanding.

When user wants to rename a file from Content tab, he does not need to change filename extension in most cases, therefore presenting that part of the filename string in the input box of the rename window is usually unnecessary and unwanted.

The proposed default behavior is to hide extension, with an option to show it, because it would improve usability in most regular cases. Still, the opposite might be the default instead, with an option to hide extensions from the input box of the rename window.

Also, when extension is hidden, it still might be included in the rename window, to the right of the input box - as a static text, to keep the user aware of it.

[FranciscoPombal]

Sounds good enough for me, but I don't think it's a good alternative from developers point.

What do you mean?

Also, when extension is hidden, it still might be included in the rename window, to the right of the input box - as a static text, to keep the user aware of it.

This just sounds like a more complex version of my suggestion.

[reyaz006]

What do you mean?

I mean I can't come up with a good way to present this feature in options and it may overcomplicate the cases where rename window is triggered from elsewhere, e.g. from the torrents list. For example, I still prefer the current way - when qbt selects the whole file name by default, because in many cases I have a new name ready in my clipboard to paste it right away. Sometimes I only need to do this for torrents, sometimes only for filenames, sometimes for both - but every time I trigger it, I know what to expect.

If your suggestion is implemented - then either it will only be applied on Content tab, or it will be applied everywhere. Both options are not good for me.

• If qbt will select the full name of the torrent like always, but will put the cursor at specific place near the end in case with files, 2 things may happen:

1. If torrent name contains a fragment that is recognized as filename extension, the way it works will look differently and will confuse me somewhat, because I may not recognize fast enough what to expect, especially if torrent name is equal to file name with extension.
2. If I need to rename both torrent name and file name, I'll need to press Shift+Home (to select all where qbt did not do that) at one of the two windows, and I'll need to remember which one if I want to get it done faster.

• if qbt treats both torrent name and file name the same way when rename window is triggered, and if I need to rename both torrent name and file name, then I may again need to use Shift+Home at one of the two windows, or at both windows, while my proposed alternative would give a different option for such cases (mirrored actually, but I just assume probability of both ways are 50%) - pressing End (to go to end where qbt did not do that) when I need, which is 1 key less.

This just sounds like a more complex version of my suggestion.

Not to me... Your suggestion affects the way how automatic selection of the text happens in the rename window, making it more complex. My suggestion, in default case, makes it more simple and consistent - the whole text inside the input box will be selected for file names if extension is moved elsewhere or hidden.

Note, I don't suggest to change how torrent renaming works, so in case my suggestion is implemented, I expect the torrent name to be treated as it is now, so if it contains any extension it will be selected together with the rest of the text in the rename window. Reason for this is that user (in my opinion) rarely needs having any extensions in torrent names.

[fvpaz]

• Bug: when new name includes "new line" character, qbt breaks the file name or torrent name internally and unable to rename it again anymore. Might need to restart qbt or remove torrent to get around this. Maybe filter out these and other most obvious illegal characters automatically? It also fails at characters like ":", "/" and "?", and such failed attempts force user to try again, losing all changes he could possibly type/paste there previously.

Many times I have this issue with "\n" char, Anyone know a bypass for fix file name? Where is the torrent information stored?

[reyaz006]

If you rename a file in a single-file torrent in the Add dialog and include the / or \ character in the name, extra folder will be created and you won't be able to make it into a single-file. You'll have to remove a torrent and re-add it.

Like I said, automatic removal of illegal characters on renaming might help.