build: b_ndebug to if-release by default, add CI for ndebug builds

Author: Daniel Kolesa

.travis.yml

@@ -57,6 +57,10 @@ matrix:
       arch: amd64
       compiler: gcc
       env: LUA_VERSION=5.4.0 LUA_SRC=1 CC=gcc CXX=g++
+      - os: linux
+      arch: amd64
+      compiler: gcc
+      env: LUA_VERSION=5.4.0 LUA_SRC=1 BUILDTYPE=release CC=gcc CXX=g++
     - os: linux
       arch: amd64
       compiler: clang
@@ -248,28 +252,29 @@ script:
       for lua_ver in ${LUA_VERSION}; do
           local lua_maj=${lua_ver:0:3}
           lua_maj=${lua_maj/./}
+          local margs="--buildtype=${BUILDTYPE:-debugoptimized}"
           mkdir build${lua_maj} && cd build${lua_maj}
           if [ "$FFI_TOOLCHAIN" == "msvc" ]; then
               cmd.exe //C 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvarsall.bat' amd64 '&&' \
-              meson .. -Dlua_version=vendor -Dlibffi=vendor -Ddeps_dir=deps${lua_maj} '&&' \
+              meson .. -Dlua_version=vendor -Dlibffi=vendor -Ddeps_dir=deps${lua_maj} ${margs} '&&' \
               ninja all '&&' ninja test || exit 1
           elif [ "$FFI_TOOLCHAIN" = "msys2" ]; then
               meson .. -Dlua_version="${LUA_VERSION}" \
                   -Dlua_path="/C/tools/msys64/mingw64/bin/lua.exe" \
                   -Dshared_libffi=true \
-                  -Ddeps_dir=deps${lua_maj} || exit 1
+                  -Ddeps_dir=deps${lua_maj} ${margs} || exit 1
               ninja all && ninja test || exit 1
           else
               if [ -n "$LIBFFI_SRC" ]; then
                   meson .. -Dlua_version=vendor -Dlibffi=vendor \
-                    -Ddeps_dir=deps${lua_maj} || exit 1
+                    -Ddeps_dir=deps${lua_maj} ${margs} || exit 1
               elif [ -n "$LUA_SRC" ]; then
                   meson .. -Dlua_version=vendor -Dshared_libffi=true \
-                    -Ddeps_dir=deps${lua_maj} || exit 1
+                    -Ddeps_dir=deps${lua_maj} ${margs} || exit 1
               else
                   meson .. -Dlua_version="${LUA_VERSION}" \
                       -Dshared_libffi=true \
-                      -Ddeps_dir=deps${lua_maj} || exit 1
+                      -Ddeps_dir=deps${lua_maj} ${margs} || exit 1
               fi
               ninja all && ninja test || exit 1
           fi

meson.build

@@ -3,8 +3,8 @@
 project('cffi-lua', ['cpp'],
     version: '0.2.0',
     default_options: [
-        'buildtype=debugoptimized', 'cpp_std=c++14', 'warning_level=3',
-        'cpp_rtti=false', 'cpp_eh=none'
+        'buildtype=debugoptimized', 'b_ndebug=if-release', 'cpp_std=c++14',
+        'warning_level=3', 'cpp_rtti=false', 'cpp_eh=none'
     ],
     meson_version: '>=0.50'
 )

src/ast.cc

@@ -1220,6 +1220,7 @@ void c_record::set_fields(util::vector<field> fields) {
     auto ret = ffi_prep_cif(
         &cif, FFI_DEFAULT_ABI, 0, &p_ffi_type, nullptr
     );
+    static_cast<void>(ret); /* silence NDEBUG warnings */
     /* this should always succeed */
     assert(ret == FFI_OK);
 

src/parser.cc

@@ -2277,6 +2277,7 @@ static ast::c_record const *parse_record(lex_state &ls, bool *newst) {
     } else {
         char buf[32];
         auto wn = ls.request_name(buf, sizeof(buf));
+        static_cast<void>(wn); /* silence NDEBUG warnings */
         assert(wn < sizeof(buf));
         sname.append(buf);
     }
@@ -2411,6 +2412,7 @@ static ast::c_enum const *parse_enum(lex_state &ls) {
     } else {
         char buf[32];
         auto wn = ls.request_name(buf, sizeof(buf));
+        static_cast<void>(wn); /* silence NDEBUG warnings */
         assert(wn < sizeof(buf));
         ename.append(buf);
     }