Allow setting room sizes from the room (#4594)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Marco Acierno <[email protected]>

Author: marcoacierno

backend/api/conferences/types.py

@@ -270,11 +270,15 @@ def keynote(self, info: Info, slug: str) -> Keynote | None:
 
     @strawberry.field
     def talks(self, info: Info) -> list[ScheduleItem]:
-        return self.schedule_items.filter(type=ScheduleItemModel.TYPES.submission).all()
+        return (
+            self.schedule_items.filter(type=ScheduleItemModel.TYPES.submission)
+            .prefetch_related("rooms")
+            .all()
+        )
 
     @strawberry.field
     def talk(self, info: Info, slug: str) -> ScheduleItem | None:
-        return self.schedule_items.filter(slug=slug).first()
+        return self.schedule_items.filter(slug=slug).prefetch_related("rooms").first()
 
     @strawberry.field
     def ranking(self, info: Info, topic: strawberry.ID) -> RankRequest | None:

backend/api/schedule/mutations/book_schedule_item.py

@@ -56,13 +56,13 @@ def book_schedule_item(info: Info, id: strawberry.ID) -> BookScheduleItemResult:
     ):
         return UserNeedsConferenceTicket()
 
-    if schedule_item.attendees_total_capacity is None:
+    if schedule_item.actual_attendees_total_capacity is None:
         return ScheduleItemNotBookable()
 
     if schedule_item.attendees.filter(user_id=user_id).exists():
         return UserIsAlreadyBooked()
 
-    if schedule_item.attendees.count() >= schedule_item.attendees_total_capacity:
+    if schedule_item.attendees.count() >= schedule_item.actual_attendees_total_capacity:
         return ScheduleItemIsFull()
 
     ScheduleItemAttendee.objects.create(schedule_item=schedule_item, user_id=user_id)

backend/api/schedule/mutations/cancel_booking_schedule_item.py

@@ -30,7 +30,7 @@ def cancel_booking_schedule_item(
     schedule_item = ScheduleItem.objects.get(id=id)
     user_id = info.context.request.user.id
 
-    if schedule_item.attendees_total_capacity is None:
+    if schedule_item.actual_attendees_total_capacity is None:
         return ScheduleItemNotBookable()
 
     if not schedule_item.attendees.filter(user_id=user_id).exists():

backend/api/schedule/tests/test_book_spot_schedule_item.py

@@ -2,6 +2,7 @@
 
 from schedule.tests.factories import (
     DayFactory,
+    RoomFactory,
     ScheduleItemAttendeeFactory,
     ScheduleItemFactory,
     SlotFactory,
@@ -186,3 +187,69 @@ def test_user_cannot_book_any_event(graphql_client, user, simple_schedule_item,
     assert not ScheduleItemAttendee.objects.filter(
         schedule_item=schedule_item, user_id=user.id
     ).exists()
+
+
+def test_user_book_with_limited_capacity_from_room(
+    graphql_client, user, simple_schedule_item, mocker
+):
+    mocker.patch(
+        "api.schedule.mutations.book_schedule_item.user_has_admission_ticket",
+        return_value=True,
+    )
+
+    graphql_client.force_login(user)
+
+    schedule_item = simple_schedule_item
+    schedule_item.rooms.add(RoomFactory(attendees_total_capacity=10))
+    schedule_item.attendees_total_capacity = None
+    schedule_item.save()
+
+    ScheduleItemAttendeeFactory.create_batch(2, schedule_item=schedule_item)
+
+    response = graphql_client.query(
+        """mutation($id: ID!) {
+        bookScheduleItem(id: $id) {
+            __typename
+        }
+    }""",
+        variables={"id": schedule_item.id},
+    )
+
+    assert response["data"]["bookScheduleItem"]["__typename"] == "ScheduleItem"
+
+    assert ScheduleItemAttendee.objects.filter(
+        schedule_item=schedule_item, user_id=user.id
+    ).exists()
+
+
+def test_user_book_full_item_from_room(
+    graphql_client, user, simple_schedule_item, mocker
+):
+    mocker.patch(
+        "api.schedule.mutations.book_schedule_item.user_has_admission_ticket",
+        return_value=True,
+    )
+
+    graphql_client.force_login(user)
+
+    schedule_item = simple_schedule_item
+    schedule_item.rooms.add(RoomFactory(attendees_total_capacity=10))
+    schedule_item.attendees_total_capacity = None
+    schedule_item.save()
+
+    ScheduleItemAttendeeFactory.create_batch(11, schedule_item=schedule_item)
+
+    response = graphql_client.query(
+        """mutation($id: ID!) {
+        bookScheduleItem(id: $id) {
+            __typename
+        }
+    }""",
+        variables={"id": schedule_item.id},
+    )
+
+    assert response["data"]["bookScheduleItem"]["__typename"] == "ScheduleItemIsFull"
+
+    assert not ScheduleItemAttendee.objects.filter(
+        schedule_item=schedule_item, user_id=user.id
+    ).exists()

backend/api/schedule/types/schedule_item.py

@@ -30,9 +30,9 @@ class ScheduleItem:
     duration: int | None
     highlight_color: str | None
     language: Language
-    audience_level: Annotated[
-        "AudienceLevel", strawberry.lazy("api.conferences.types")
-    ] | None
+    audience_level: (
+        Annotated["AudienceLevel", strawberry.lazy("api.conferences.types")] | None
+    )
     youtube_video_id: str | None
     link_to: str
 
@@ -45,21 +45,21 @@ class ScheduleItem:
 
     @strawberry.field
     def has_limited_capacity(self) -> bool:
-        return self.attendees_total_capacity is not None
+        return self.actual_attendees_total_capacity is not None
 
     @strawberry.field
     def has_spaces_left(self) -> bool:
-        if self.attendees_total_capacity is None:
+        if self.actual_attendees_total_capacity is None:
             return True
 
-        return self.attendees_total_capacity - self.attendees.count() > 0
+        return self.actual_attendees_total_capacity - self.attendees.count() > 0
 
     @strawberry.field
     def spaces_left(self) -> int:
-        if self.attendees_total_capacity is None:
+        if self.actual_attendees_total_capacity is None:
             return 0
 
-        return self.attendees_total_capacity - self.attendees.count()
+        return self.actual_attendees_total_capacity - self.attendees.count()
 
     @strawberry.field
     def user_has_spot(self, info) -> bool:
@@ -124,7 +124,7 @@ def image(self, info) -> str | None:
 
         return info.context.request.build_absolute_uri(self.image.url)
 
-    @strawberry.field(name='slidoUrl')
+    @strawberry.field(name="slidoUrl")
     def _slido_url(self, info) -> str:
         if self.slido_url:
             return self.slido_url

backend/schedule/admin.py

@@ -341,7 +341,7 @@ class ScheduleItemAdmin(ConferencePermissionMixin, admin.ModelAdmin):
                     "link_to",
                     "slido_url",
                     "talk_manager",
-                    'livestreaming_room',
+                    "livestreaming_room",
                 )
             },
         ),
@@ -398,6 +398,9 @@ class ScheduleItemAdmin(ConferencePermissionMixin, admin.ModelAdmin):
         "invitation_link",
     )
 
+    def get_queryset(self, request):
+        return super().get_queryset(request).prefetch_related("rooms")
+
     def get_urls(self):
         return [
             path(
@@ -420,9 +423,9 @@ def export_attendees(self, request, object_id: int):
         export_data = csv_format.export_data(data)
         date_str = timezone.now().strftime("%Y-%m-%d")
         response = HttpResponse(export_data, content_type=csv_format.get_content_type())
-        response[
-            "Content-Disposition"
-        ] = f'attachment; filename="{schedule_item.slug}-attendees-{date_str}.csv"'
+        response["Content-Disposition"] = (
+            f'attachment; filename="{schedule_item.slug}-attendees-{date_str}.csv"'
+        )
         return response
 
     def email_speakers(self, request):
@@ -482,10 +485,10 @@ def email_speakers(self, request):
         return TemplateResponse(request, "email-speakers.html", context)
 
     def spaces_left(self, obj):
-        if obj.attendees_total_capacity is None:
+        if obj.actual_attendees_total_capacity is None:
             return None
 
-        return obj.attendees_total_capacity - obj.attendees.count()
+        return obj.actual_attendees_total_capacity - obj.attendees.count()
 
     def save_form(self, request, form, change):
         if form.cleaned_data["new_slot"]:
@@ -672,8 +675,14 @@ class RoomAdmin(OrderedModelAdmin):
     list_display = (
         "name",
         "type",
+        "attendees_total_capacity",
     )
     list_filter = ("type",)
+    fields = (
+        "name",
+        "type",
+        "attendees_total_capacity",
+    )
 
 
 class DayRoomThroughModelInline(OrderedTabularInline):

backend/schedule/migrations/0057_room_attendees_total_capacity.py

@@ -0,0 +1,18 @@
+# Generated by Django 5.2.8 on 2026-03-03 12:52
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('schedule', '0056_scheduleitem_livestreaming_room'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='room',
+            name='attendees_total_capacity',
+            field=models.PositiveIntegerField(blank=True, help_text='Maximum capacity for this room. Leave blank to not limit attendees.', null=True, verbose_name='default attendees total capacity'),
+        ),
+    ]

backend/schedule/models.py

@@ -31,6 +31,14 @@ class Room(models.Model):
 
     name = models.CharField(_("name"), max_length=100)
     type = models.CharField(_("type"), choices=TYPES, max_length=10, default=TYPES.talk)
+    attendees_total_capacity = models.PositiveIntegerField(
+        _("default attendees total capacity"),
+        null=True,
+        blank=True,
+        help_text=_(
+            "Maximum capacity for this room. Leave blank to not limit attendees."
+        ),
+    )
 
     def __str__(self):
         return self.name
@@ -318,6 +326,13 @@ class ScheduleItem(TimeStampedModel):
 
     objects = ScheduleItemQuerySet().as_manager()
 
+    @cached_property
+    def actual_attendees_total_capacity(self):
+        if self.attendees_total_capacity is not None:
+            return self.attendees_total_capacity
+        room = self.rooms.first()
+        return room.attendees_total_capacity if room else None
+
     @cached_property
     def speakers(self):
         speakers = []