chore: use pytest's new strict mode and fix duplicate tests (#10847)

Author: radoering

poetry.lock

@@ -74,7 +74,7 @@ coverage = ">=7.2.0"
 deepdiff = ">=6.3"
 responses = ">=0.25.8"
 jaraco-classes = ">=3.3.1"
-pytest = ">=8.0"
+pytest = ">=9.0"
 pytest-cov = ">=4.0"
 pytest-mock = ">=3.9"
 pytest-randomly = ">=3.12"
@@ -187,15 +187,15 @@ module = [
 ignore_missing_imports = true
 
 
-[tool.pytest.ini_options]
-addopts = [ "-n", "logical", "-ra", "--strict-config", "--strict-markers" ]
+[tool.pytest]
+strict = true
+addopts = [ "-n", "logical", "-ra" ]
 testpaths = ["tests"]
 markers = [
     "network: mark tests that require internet access",
-    "skip_git_mock: mark tests that should not auto-apply git_mock"
+    "skip_git_mock: mark tests that should not auto-apply git_mock",
 ]
 log_cli_level = "INFO"
-xfail_strict = true
 
 
 [tool.coverage.report]

pyproject.toml

@@ -394,37 +394,6 @@ def _configure_project_with_groups(poetry: Poetry, installed: Repository) -> Non
                 },
             ],
         ),
-        (
-            "--with time",
-            """\
-cachy    0.1.0 Cachy package
-pendulum 2.0.0 Pendulum package
-pytest   3.7.3 Pytest package
-""",
-        ),
-        (
-            "--with time --format json",
-            [
-                {
-                    "name": "cachy",
-                    "version": "0.1.0",
-                    "description": "Cachy package",
-                    "installed_status": "installed",
-                },
-                {
-                    "name": "pendulum",
-                    "version": "2.0.0",
-                    "description": "Pendulum package",
-                    "installed_status": "installed",
-                },
-                {
-                    "name": "pytest",
-                    "version": "3.7.3",
-                    "description": "Pytest package",
-                    "installed_status": "installed",
-                },
-            ],
-        ),
     ],
 )
 def test_show_basic_with_group_options(

tests/console/commands/test_show.py

@@ -90,7 +90,7 @@ def test_is_fresh(
         ("outdated", "2.3.0", False),
         ("valid", "2.2.1", True),
         ("legacy", "2.2.1", True),
-        ("outdated", "2.3.0", False),
+        ("outdated", "2.2.1", False),
     ],
 )
 def test_is_fresh_dependency_groups(

tests/packages/test_locker.py

@@ -102,10 +102,10 @@ def test_get_name_from_source_url(url: str) -> None:
     assert name == "poetry"
 
 
-@pytest.mark.parametrize(("tag"), ["my-tag", b"my-tag"])
+@pytest.mark.parametrize("tag", ["my-tag", b"my-tag"], ids=["str", "bytes"])
 def test_peeled_tag(tag: str | bytes) -> None:
-    tag = peeled_tag("my-tag")
-    assert tag == b"my-tag^{}"
+    tag_ref = peeled_tag(tag)
+    assert tag_ref == b"my-tag^{}"
 
 
 def test_get_remote_url(repo_mock: Repo) -> None: